MIME-Version: 1.0
References: 
 <CAA4eK1LT=03FUoLew8qvTay+xzmvO-gAMsh+kvMBVd6+yqi3kQ@mail.gmail.com>
 <CAHv8RjJNE1ZvWhsgL54iPsJhomhcG+-SGPN8AnnwdLmWt6A44A@mail.gmail.com>
 <OSCPR01MB14966D341D7E689DA6B78CAC4F5D92@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAHv8RjKbYaCRrzJzmU6gU0jt85xJftzVV-Hu9rXrkb1yFzYTtA@mail.gmail.com>
 <CALDaNm3wLKFjSJ-4fF4ACBaq+jH3fPeA68OmS3jc_smaOe=6Qw@mail.gmail.com>
 <CAHv8RjLqk07qQU_FNuyWSRCena_YYySGR6vNFAQ0kDTLmmq8Mg@mail.gmail.com>
In-Reply-To: 
 <CAHv8RjLqk07qQU_FNuyWSRCena_YYySGR6vNFAQ0kDTLmmq8Mg@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Thu, 20 Mar 2025 09:37:04 +0530
Message-ID: 
 <CALDaNm3pX+C61UDnN76sz+-irHdu03RTmBDCQb8fzVFu30CFkA@mail.gmail.com>
Subject: Re: Adding a '--clean-publisher-objects' option to
 'pg_createsubscriber' utility.
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Euler Taveira <euler@eulerto.com>,
	Peter Smith <smithpb2250@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>,
	Shlok Kyal <shlok.kyal.oss@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Amit Kapila <amit.kapila16@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm3pX%2BC61UDnN76sz%2B-irHdu03RTmBDCQb8fzVFu30CFkA%40mail.gmail.com>
Precedence: bulk

On Thu, 20 Mar 2025 at 09:06, Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
> The attached patch contains the suggested changes.

Couple of minor comments:
1) The second and third line comments can be in same line:
+# Create user-defined publications, wait for streaming replication to sync them
+# to the standby, then verify that '--remove'
+# removes them.

2) This comment can be in a single line:
+# In passing, also test the --enable-two-phase option and
+# --remove option

Regards,
Vignesh