Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBihd-00075U-5C for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Jul 2022 20:11:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBihb-0002Li-M7 for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Jul 2022 20:11:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBihb-0002LT-BS for pgsql-hackers@lists.postgresql.org; Wed, 13 Jul 2022 20:11:19 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBihY-0001sE-Kc for pgsql-hackers@lists.postgresql.org; Wed, 13 Jul 2022 20:11:18 +0000 Received: by mail-lj1-x22e.google.com with SMTP id p6so11915824ljc.8 for ; Wed, 13 Jul 2022 13:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yugabyte.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f99v3m11l5x6NVKVcd5ijfIiwDsT+LiyV20Tt3THbio=; b=Xqha9EUC/MakMj8Z0TMpI0ZgZYL8II1v0uf0xF5zROn+p9GIXvsrXu30TEqZyCvTJl vQiFXd0B0uetG+vk8FBfv5OPXdYBOjkeAvT1CiLX53uSRLfHpcIUJdefqRgg+6kWtvbD f6LdudltcBBr0ttjxEMKYGJxPjjX39A4zbLa0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f99v3m11l5x6NVKVcd5ijfIiwDsT+LiyV20Tt3THbio=; b=xC235e63sCkTnrhpppqzv9FYcItbzNFIqdMfP/sJOWhj1O1uEDjmTKAp7bqtcts1ph 0qHAJaalFlc/OsOViqNQefgpBgjC1Nme9IHrJPTsOfsPTVTm0Y7/cHJT2sjXZ9rOjM2x RVbmRriqn9O1lzyB7TgyLY74mLO2wSBhgz/UbSvTvZvJ0gAg1439TBH1hgm+pXdjmGun 40jseL1h5XwYjdHfctx4oGASda5/Jjg8PSZElUPhe1Mxw0y5UanORAP8Vivb3nq6U/HR TuBprBltws9oc6CofbVBGWluLkk4HzltJu+DTARqp42VU1Oh5xTJvVDK/OcLVJSHfqCJ IKGg== X-Gm-Message-State: AJIora/bvC2WlT6Je3qYanJpxOlRDztgJlfwybqDx7tEqlzMGfkY95jz TKDTu3Bg4ERBfXq3Ehn4+H7QEFUCsEdigeuinJTBy/FNUuJZ6w== X-Google-Smtp-Source: AGRyM1uFaGqyj/c2m37jmBqZGqQS0D7eiYoti7iu67tnnXCwKjraElD/SI3+idqqM6Z9fhxE1/LvuFmAoNc/vOGBTsI= X-Received: by 2002:a05:651c:160a:b0:25a:62a4:9085 with SMTP id f10-20020a05651c160a00b0025a62a49085mr2596651ljq.214.1657743074630; Wed, 13 Jul 2022 13:11:14 -0700 (PDT) MIME-Version: 1.0 References: <163714495450.16056.3566953095730878367@malur.postgresql.org> <82ed3466-9855-ccd6-e2a3-a3a92166ff01@postgrespro.ru> <2289dab9-1f2b-f46a-a0da-3b61223a2897@postgrespro.ru> In-Reply-To: <2289dab9-1f2b-f46a-a0da-3b61223a2897@postgrespro.ru> From: Zhihong Yu Date: Wed, 13 Jul 2022 13:17:30 -0700 Message-ID: Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands To: Dmitry Koval Cc: PostgreSQL Hackers Content-Type: multipart/alternative; boundary="00000000000017b80d05e3b563b6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000017b80d05e3b563b6 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 13, 2022 at 1:05 PM Dmitry Koval wrote: > Thanks you! > I've fixed all things mentioned. > > -- > With best regards, > Dmitry Koval > > Postgres Professional: http://postgrespro.com Hi, Toward the end of ATExecSplitPartition(): + /* Unlock new partition. */ + table_close(newPartRel, NoLock); Why is NoLock passed (instead of AccessExclusiveLock) ? Cheers --00000000000017b80d05e3b563b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jul 13, 2022 at 1:05 PM Dmitr= y Koval <d.koval@postgrespro.r= u> wrote:
Thanks you!
I've fixed all things mentioned.

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com
Hi,
Toward the end of=C2=A0ATExecSplitPartition():

+ =C2= =A0 =C2=A0 =C2=A0 /* Unlock new partition. */
+ =C2=A0 =C2=A0 =C2= =A0 table_close(newPartRel, NoLock);

=C2=A0Why is = NoLock passed (instead of AccessExclusiveLock) ?

C= heers
--00000000000017b80d05e3b563b6--