MIME-Version: 1.0
References: 
 <CAApHDvpHzfo92=R4W0+xVua3BUYCKMckWAmo-2t_KiXN-wYH=w@mail.gmail.com>
 <CAApHDvrXnUFNiYQiHv4Eu_rtbMPsKeVT-KG93_dD-ZYs9G5OnA@mail.gmail.com>
 <4493999.1py09z8qHF@aivenronan> <3163474.aeNJFYEL58@aivenronan>
 <CAApHDvqS-p57j++gLMyQXmttk_MM3u243dWQ54FyW-7=4GP+1Q@mail.gmail.com>
 <CAMbWs49hcB-Mj3MJTOesL5=y4oU+md=zEvDYdCBrOSaDvXLRGQ@mail.gmail.com>
 <CAApHDvr3JQv4_H7vfu5Djtw0ubKwGDwvNtPuphtaQY4utgj7bQ@mail.gmail.com>
 <CAMbWs4_hAK6+0Gk=vZX+ikSFBx=6981iFLGkgLObDkvvGpjogg@mail.gmail.com>
 <CAApHDvrai=tCuUhH=YUvDnysivzbabz4pGPGz_3SytysWmyNdg@mail.gmail.com>
 <CAMbWs49Xw1Sb4KOZx6CMGBjiCNvGCcAyXkwWRGNZivyYv2fGMg@mail.gmail.com>
 <CAApHDvqtmK7AprGs=uh2+BNyew6L3OpC7hPSe43uD-7m1Dtx7w@mail.gmail.com>
 <1138716.1659282591@sss.pgh.pa.us>
 <CALNJ-vTi+YDuAWKp4Z_Dv=mrz=aq81qTg0D7wzc8y7rS_+i_cw@mail.gmail.com>
In-Reply-To: 
 <CALNJ-vTi+YDuAWKp4Z_Dv=mrz=aq81qTg0D7wzc8y7rS_+i_cw@mail.gmail.com>
From: Zhihong Yu <zyu@yugabyte.com>
Date: Tue, 2 Aug 2022 12:38:22 -0700
Message-ID: 
 <CALNJ-vRMSMf7MPZ917pT8gGdtE95rrouCXReuNjOuoQYMOjdgQ@mail.gmail.com>
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, Richard Guo <guofenglinux@gmail.com>,
	Ronan Dunklau <ronan.dunklau@aiven.io>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
 Ranier Vilela <ranier.vf@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000c6af5f05e5472a3e"
Archived-At: 
 <https://www.postgresql.org/message-id/CALNJ-vRMSMf7MPZ917pT8gGdtE95rrouCXReuNjOuoQYMOjdgQ%40mail.gmail.com>
Precedence: bulk

--000000000000c6af5f05e5472a3e
Content-Type: multipart/alternative; boundary="000000000000c6af5c05e5472a3c"

--000000000000c6af5c05e5472a3c
Content-Type: text/plain; charset="UTF-8"

On Tue, Aug 2, 2022 at 11:02 AM Zhihong Yu <zyu@yugabyte.com> wrote:

>
>> Hi, David:
>
> I was looking at the final patch and noticed that setno field
> in agg_presorted_distinctcheck struct is never used.
>
> Looks like it was copied from neighboring struct.
>
> Can you take a look at the patch ?
>
> Thanks
>
>>
>
> Looks like setoff field is not used either.

Cheers

--000000000000c6af5c05e5472a3c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Aug 2, 2022 at 11:02 AM Zhiho=
ng Yu &lt;<a href=3D"mailto:zyu@yugabyte.com">zyu@yugabyte.com</a>&gt; wrot=
e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"l=
tr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><br>Hi, David:</blockquote><div>I was looking at the final patch and =
noticed that setno field in=C2=A0agg_presorted_distinctcheck struct is neve=
r used.</div><div><br></div><div>Looks like it was copied from neighboring =
struct.</div><div><br></div><div>Can you take a look at the patch ?</div><d=
iv><br></div><div>Thanks=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">=C2=A0</blockquote></div></div></blockquote><div>Looks like seto=
ff field is not used either.</div><div><br></div><div>Cheers=C2=A0</div></d=
iv></div>

--000000000000c6af5c05e5472a3c--

--000000000000c6af5f05e5472a3e
Content-Type: application/octet-stream;
	name="drop-setno-setoff-from-agg_presorted_distinctcheck.patch"
Content-Disposition: attachment;
	filename="drop-setno-setoff-from-agg_presorted_distinctcheck.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l6cl1l0n0>
X-Attachment-Id: f_l6cl1l0n0

ZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2V4ZWN1dG9yL2V4ZWNFeHByLmggYi9zcmMvaW5jbHVk
ZS9leGVjdXRvci9leGVjRXhwci5oCmluZGV4IDA3MzliMzg5ZjMuLmMxM2RmNzRkYzQgMTAwNjQ0
Ci0tLSBhL3NyYy9pbmNsdWRlL2V4ZWN1dG9yL2V4ZWNFeHByLmgKKysrIGIvc3JjL2luY2x1ZGUv
ZXhlY3V0b3IvZXhlY0V4cHIuaApAQCAtNjY2LDkgKzY2Niw3IEBAIHR5cGVkZWYgc3RydWN0IEV4
cHJFdmFsU3RlcAogCQl7CiAJCQlBZ2dTdGF0ZVBlclRyYW5zIHBlcnRyYW5zOwogCQkJRXhwckNv
bnRleHQgKmFnZ2NvbnRleHQ7Ci0JCQlpbnQJCQlzZXRubzsKIAkJCWludAkJCXRyYW5zbm87Ci0J
CQlpbnQJCQlzZXRvZmY7CiAJCQlpbnQJCQlqdW1wZGlzdGluY3Q7CiAJCX0JCQlhZ2dfcHJlc29y
dGVkX2Rpc3RpbmN0Y2hlY2s7CiAK
--000000000000c6af5f05e5472a3e--