Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lOSBV-0006Qh-0c
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 21:34:01 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lOSBT-0001sE-Nr
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 21:33:59 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <zyu@yugabyte.com>)
	id 1lOSBT-0001s4-FC
	for pgsql-hackers@lists.postgresql.org; Mon, 22 Mar 2021 21:33:59 +0000
Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <zyu@yugabyte.com>)
	id 1lOSBM-0005NC-69
	for pgsql-hackers@postgresql.org; Mon, 22 Mar 2021 21:33:57 +0000
Received: by mail-lf1-x129.google.com with SMTP id o126so14072066lfa.0
        for <pgsql-hackers@postgresql.org>;
 Mon, 22 Mar 2021 14:33:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=yugabyte.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Kmh+xlcwavaaTcfnU8ROVtx6PyQT/G5vFI4QYRdKFs0=;
        b=OYI/o3DfklpSt2PoFw9LFkQSTw1ZyaYr6PxzXFpWUxmObV3M0Tj9aRBn/jfCsuVphZ
         NW6h+puZLMkjzw/z+25xVwjGr4DrEeh0tVeI9KZ6dxXmNXl9Sd+DkXjFSXZQ1YIVWwAD
         v1b8AS7lMgwfGsc5R/EXTaM+BPEGb4IUmiHb8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Kmh+xlcwavaaTcfnU8ROVtx6PyQT/G5vFI4QYRdKFs0=;
        b=P+krnvhawzxnOdzIE2PZYV0NZu05r09ETEJCLexjCqgOuMTN2+WhsCXk8p2cMkw7j0
         s+n8zxYk26unYaPTbtvhwYg+Xo4QXIxvurFdVUz2DNqrMdRY+2St3lgSzXyzlq0kuzPd
         dD+R2rZUKhzc+WjB76pjR2ZiWnWGI5cn9Tr//A/7FkktZBjXq+z0W4BvV2StpDX7BEMH
         XTIHix2yY+negD/UIcbAx3DIZqVJtNLnnScxO3IubYLujOgXi+poV8NSm2Qq2KSjBx7J
         pXnArNTWWb8LgPJux6FYqFZFrpjzAqdIcipUJQT+/keDHfNzFv9mgD+TD1ZZ8G/IMrT1
         T5pA==
X-Gm-Message-State: AOAM532aOiWtDCmDT8J6IHnuOc8lH/hzbxkiV63Pa/JO68+nsR99iLq2
	S08cJzlo4jjtjzNC+aeT7oJooBLpDoRIhuOlCClFfA==
X-Google-Smtp-Source: 
 ABdhPJwTMSJXjRMtVH7OYmd3shFjhMj5SS4VPT3DCJskx4aXT4qbpzDOJtr6I3aIagjZZd5JD75th6lwX1Z9aSOxKgs=
X-Received: by 2002:ac2:569c:: with SMTP id 28mr685056lfr.414.1616448830273;
 Mon, 22 Mar 2021 14:33:50 -0700 (PDT)
MIME-Version: 1.0
References: <a9f9376f1c3343a6bb319dce294e20ac@EX13D05UWC001.ant.amazon.com>
 <CABUevEwyLb9VE0D+bAQtUnaA7bffXYzBpopYuh7kGTQxY9T5_g@mail.gmail.com>
 <CAEP4nAw2WA1wyb9LG7BOEuN3Xr-xWiZZ0w_hKtpyvdUPKmcAJA@mail.gmail.com>
 <1742698.1615221182@sss.pgh.pa.us>
 <CABUevEzvU07CqwGdaOmxNfDtrkY-xEcLjiN3GAmurowyCnbG7w@mail.gmail.com>
 <1743618.1615222719@sss.pgh.pa.us>
 <4fbf92f2-ec91-f4fa-a259-f0968e34f3d7@wi3ck.info>
 <181907.1616253799@sss.pgh.pa.us>
 <147fa478-510b-18ef-5323-9c1725b2493c@wi3ck.info>
 <c2a43a97-e551-ea6d-7a4f-a4709b4e0cbd@dunslane.net>
 <5bdcb010-ecdd-c69a-b441-68002fc38483@wi3ck.info>
 <ee7d96b8-7b0e-bb76-9724-900606efe69a@dunslane.net>
In-Reply-To: <ee7d96b8-7b0e-bb76-9724-900606efe69a@dunslane.net>
From: Zhihong Yu <zyu@yugabyte.com>
Date: Mon, 22 Mar 2021 14:36:38 -0700
Message-ID: 
 <CALNJ-vSPnudYcS8YowHeq7VAf7PBRyu0vpsbmb_VvTJgguVyHA@mail.gmail.com>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Jan Wieck <jan@wi3ck.info>, Tom Lane <tgl@sss.pgh.pa.us>,
	Magnus Hagander <magnus@hagander.net>, Robins Tharakan <tharakan@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000053906605be26d222"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CALNJ-vSPnudYcS8YowHeq7VAf7PBRyu0vpsbmb_VvTJgguVyHA%40mail.gmail.com>
Precedence: bulk

--00000000000053906605be26d222
Content-Type: text/plain; charset="UTF-8"

>
> Hi,
>
w.r.t. pg_upgrade_improvements.v2.diff.

+       blobBatchCount = 0;
+       blobInXact = false;

The count and bool flag are always reset in tandem. It seems
variable blobInXact is not needed.

Cheers

--00000000000053906605be26d222
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">Hi,<br></blockquote><div>w.r.t.=C2=A0pg_upgrade_improvem=
ents.v2.diff.</div><div><br></div>+ =C2=A0 =C2=A0 =C2=A0 blobBatchCount =3D=
 0;<br><div>+ =C2=A0 =C2=A0 =C2=A0 blobInXact =3D false;</div><div><br></di=
v><div>The count and bool flag are always reset in tandem. It seems variabl=
e=C2=A0blobInXact=C2=A0is not needed.</div><div><br></div><div>Cheers=C2=A0=
</div></div></div>

--00000000000053906605be26d222--