Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nugB9-0006fL-Sb for pgsql-hackers@arkaria.postgresql.org; Fri, 27 May 2022 20:03:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nugB7-00026Z-P2 for pgsql-hackers@arkaria.postgresql.org; Fri, 27 May 2022 20:03:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nugB7-00026P-CM for pgsql-hackers@lists.postgresql.org; Fri, 27 May 2022 20:03:21 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nugB2-0007DW-PV for pgsql-hackers@postgresql.org; Fri, 27 May 2022 20:03:20 +0000 Received: by mail-lj1-x231.google.com with SMTP id a23so5994881ljd.9 for ; Fri, 27 May 2022 13:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yugabyte.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LHLPQMysXbKuGGHqI8XMSif38qXx6pImUALGaAjdTHI=; b=NCRGmRJr1NIQHhITzBmy7sVyxRdBjQaTtrjwX0kXzJDS71mSn2kVzpCmduYuc0DztD AqfL+/Rk1NMt1Z4GqeBv5i9guTmgJw4AMhO6BI9IOf2ajvU7GIHHjb0oCxFT6IgonTBr RmwUyfvK5mMmBT5hl+PE4vcXimfohBTKryGgc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LHLPQMysXbKuGGHqI8XMSif38qXx6pImUALGaAjdTHI=; b=qdUawd8gtIwEEn0VWiD8Z8jSGCaEKqLwT3n0UqFsF3gaEtZStgU9+2OnJmSiKyBw10 6sqNcnLalg4XuiLmWsE6NBcgdD6whjewpdpgr3YhwmHLYPq8rZGvqux3y6etJ6tTIo6l 8qqoakfU4+LO6KA+KX0Oqg4c42TWphECl9lqWeAJIkUp9sqRyiR6YlsAVqYUBv0zvYST OOdHIo2KFkH9xeewrWuYHJx+bJbEWVMHQT2gHf/Xj13mMfk7S1AA5XBfvSWZnUAR6UP9 hDF48/+Q3U6tAA2GPmCrLUq43Kwz+Cc+ftmUzLTfW+0fvxxygqRZPWkfWkm9lV4OpLwi XhaA== X-Gm-Message-State: AOAM533UrO6w6hE6EMLh50cjI6ZMknYyVDDR75vuclK6d+p6zU1v6H+F gg91DfvhclVcdb+WP0zR1n219ypntJc4HMtSGUCcjQ== X-Google-Smtp-Source: ABdhPJyVOWRWkcI0Ewjyq1CVP63o3i1g0D6ulcQC+M9SnviuhAfSCaXR9vX+jCqJ+GmgWqRIdxlRYjJ+Mdw6F+iIOEY= X-Received: by 2002:a2e:5cc2:0:b0:250:8431:a76a with SMTP id q185-20020a2e5cc2000000b002508431a76amr25036071ljb.325.1653681795856; Fri, 27 May 2022 13:03:15 -0700 (PDT) MIME-Version: 1.0 References: <215356.1647286703@sss.pgh.pa.us> In-Reply-To: From: Zhihong Yu Date: Fri, 27 May 2022 13:08:39 -0700 Message-ID: Subject: Re: generic plans and "initial" pruning To: Amit Langote Cc: David Rowley , Robert Haas , Tom Lane , PostgreSQL-development Content-Type: multipart/alternative; boundary="00000000000003932f05e003cc4b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000003932f05e003cc4b Content-Type: text/plain; charset="UTF-8" On Fri, May 27, 2022 at 1:10 AM Amit Langote wrote: > On Mon, Apr 11, 2022 at 12:53 PM Zhihong Yu wrote: > > On Sun, Apr 10, 2022 at 8:05 PM Amit Langote > wrote: > >> Sending v15 that fixes that to keep the cfbot green for now. > > > > Hi, > > > > + /* RT index of the partitione table. */ > > > > partitione -> partitioned > > Thanks, fixed. > > Also, I broke this into patches: > > 0001 contains the mechanical changes of moving PartitionPruneInfo out > of Append/MergeAppend into a list in PlannedStmt. > > 0002 is the main patch to "Optimize AcquireExecutorLocks() by locking > only unpruned partitions". > > -- > Thanks, Amit Langote > EDB: http://www.enterprisedb.com Hi, In the description: is made available to the actual execution via PartitionPruneResult, made available along with the PlannedStmt by the I think the second `made available` is redundant (can be omitted). + * Initial pruning is performed here if needed (unless it has already been done + * by ExecDoInitialPruning()), and in that case only the surviving subplans' I wonder if there is a typo above - I don't find ExecDoInitialPruning either in PG codebase or in the patches (except for this in the comment). I think it should be ExecutorDoInitialPruning. + * bit from it just above to prevent empty tail bits resulting in I searched in the code base but didn't find mentioning of `empty tail bit`. Do you mind explaining a bit about it ? Cheers --00000000000003932f05e003cc4b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, May 27, 2022 at 1:10 AM Amit = Langote <amitlangote09@gmail.= com> wrote:
On Mon, Apr 11, 2022 at 12:53 PM Zhihong Yu <zyu@yugabyte.com> wrote:
> On Sun, Apr 10, 2022 at 8:05 PM Amit Langote <amitlangote09@gmail.com> wro= te:
>> Sending v15 that fixes that to keep the cfbot green for now.
>
> Hi,
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* RT index of= the partitione table. */
>
> partitione -> partitioned

Thanks, fixed.

Also, I broke this into patches:

0001 contains the mechanical changes of moving PartitionPruneInfo out
of Append/MergeAppend into a list in PlannedStmt.

0002 is the main patch to "Optimize AcquireExecutorLocks() by locking<= br> only unpruned partitions".

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
Hi,
In th= e description:

is made available to the actual executio= n via
PartitionPruneResult, made available along with the PlannedSt= mt by the=C2=A0

I think the second `made available= ` is redundant (can be omitted).

+ * Initial pruni= ng is performed here if needed (unless it has already been done
+ * by E= xecDoInitialPruning()), and in that case only the surviving subplans'

I wonder if there is a typo above - I don't= find=C2=A0ExecDoInitialPruning either in PG codebase or in the patches (ex= cept for this in the comment).
I think it should be=C2=A0Executor= DoInitialPruning.

+ =C2=A0 =C2=A0* bit from it jus= t above to prevent empty tail bits resulting in

I searched=C2=A0in the code base but didn't find mentioning of `empty= tail bit`. Do you mind explaining a bit about it ?

Cheers
--00000000000003932f05e003cc4b--