public inbox for [email protected]  

help / color / mirror / Atom feed

From: Zhihong Yu <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: vignesh C <[email protected]>
Subject: Re: dynamic result sets support in extended query protocol
Date: Mon, 30 Aug 2021 14:11:34 -0700
Message-ID: <CALNJ-vTHehDOEUTD6iBxaLhQAYvLDOrTRn0vVW+wVscy-VtUiQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CALDaNm3VjrBP5-zRyasDC35B+NZD39=c-AZo0=6iDiNu31d3Pg@mail.gmail.com>
	<[email protected]>

On Mon, Aug 30, 2021 at 1:23 PM Peter Eisentraut <
[email protected]> wrote:

> rebased patch set
>
> On 22.07.21 08:06, vignesh C wrote:
> > On Tue, Jun 29, 2021 at 7:10 PM Peter Eisentraut
> > <[email protected]> wrote:
> >>
> >> Here is an updated patch with some merge conflicts resolved, to keep it
> >> fresh.  It's still pending in the commit fest from last time.
> >>
> >> My focus right now is to work on the "psql - add SHOW_ALL_RESULTS
> >> option" patch (https://commitfest.postgresql.org/33/2096/) first, which
> >> is pretty much a prerequisite to this one.  The attached patch set
> >> contains a minimal variant of that patch in 0001 and 0002, just to get
> >> this working, but disregard those for the purposes of code review.
> >>
> >> The 0003 patch contains comprehensive documentation and test changes
> >> that can explain the feature in its current form.
> >
> > One of the patch v3-0003-Dynamic-result-sets-from-procedures.patch
> > does not apply on HEAD, please post an updated patch for it:
> > Hunk #1 FAILED at 57.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > src/include/commands/defrem.h.rej
> >
> > Regards,
> > Vignesh
> >
> >
>
> Hi,

+    <term><literal>WITH RETURN</literal></term>
+    <term><literal>WITHOUT RETURN</literal></term>
+    <listitem>
+     <para>
+      This option is only valid for cursors defined inside a procedure.

Since there are two options listed, I think using 'These options are' would
be better.

For CurrentProcedure(),

+       return InvalidOid;
+   else
+       return llast_oid(procedure_stack);

The word 'else' can be omitted.

Cheers

view thread (30+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: dynamic result sets support in extended query protocol
  In-Reply-To: <CALNJ-vTHehDOEUTD6iBxaLhQAYvLDOrTRn0vVW+wVscy-VtUiQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox