MIME-Version: 1.0
References: <7fec3abb-c663-c0d2-8452-a46141be6d4a@postgrespro.ru>
 <74a716a3-986d-c737-6217-6a3ffd488da3@postgrespro.ru>
 <20200924032738.GA28585@paquier.xyz>
 <37f1072a-16ec-8ce8-8044-1fcec85c8ed5@postgrespro.ru>
 <CAH2L28v_fmXvDF+UzMDCObgd7nuqSU=HAJPfw7w4TMx5HGv5ig@mail.gmail.com>
 <199124d5-e710-71a6-1836-4653cd668d96@postgrespro.ru>
 <CAH2L28vRKPw+uf3Voiy6zy5QUghTPueErNTz_xgpkxEKnmfL1A@mail.gmail.com>
 <d596fdf5-7985-2a79-f76f-4f7606798642@postgrespro.ru>
 <CALT9ZEFBv05OhLMKO1Lbo_Zg9a0v+U9q9twe=t-dixfR45RmVQ@mail.gmail.com>
 <CALT9ZEHL0zgOfvx9ZrH0H4FiuVOKCRU6LcjGxB+1KRPLpAq9+w@mail.gmail.com>
 <CALT9ZEHLvWsvfOpGLy8edEVGj-GYbkp03K676njhibatkqJmHA@mail.gmail.com>
 <8b1fce70861e2143cef9c7a69b740d61@postgrespro.ru>
 <alpine.DEB.2.22.394.2012221025000.533489@pseudo>
 <CALT9ZEFe4Fj4mEnbpVmHQEXRC_K-DoicYvV-xHi0JZ3JTkc3Wg@mail.gmail.com>
 <alpine.DEB.2.22.394.2012221131410.533489@pseudo>
 <CALT9ZEFtDHhsPwqYSm_Hu51pVmnQh0C0A_raitJzo_kRoPhdPg@mail.gmail.com>
 <alpine.DEB.2.22.394.2012221643050.533489@pseudo>
In-Reply-To: <alpine.DEB.2.22.394.2012221643050.533489@pseudo>
From: Pavel Borisov <pashkin.elfe@gmail.com>
Date: Wed, 23 Dec 2020 14:59:51 +0400
Message-ID: 
 <CALT9ZEF_aMgYoEg9JFYm9GUDwaa014wu7rtS_To8f82zt_rHaw@mail.gmail.com>
Subject: Re: [PATCH] Automatic HASH and LIST partition creation
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Maxim Orlov <m.orlov@postgrespro.ru>,
	Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
 Rahila Syed <rahilasyed90@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Justin Pryzby <pryzby@telsasoft.com>,
	Robert Haas <robertmhaas@gmail.com>, Amul Sul <sulamul@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000db592905b71f97db"
Precedence: bulk

--000000000000db592905b71f97db
Content-Type: text/plain; charset="UTF-8"

>
>
> > BTW could you tell me a couple of words about pros and cons of c-code
> > syntax parsing comparing to parsing using gram.y trees?
>
> I'd rather use an automatic tool (lexer/parser) if possible instead of
> doing it by hand if I can. If you want a really nice syntax with clever
> tricks, then you may need to switch to manual though, but pg/sql is not in
> that class.
>
> > I think both are possible but my predisposition was that we'd better use
> > the later if possible.
>
> I agree.
>
Thank you!

Fabien, do you consider it possible to change the syntax of declarative
partitioning too? It is problematic as it is already committed but also is
very tempting to have the same type of syntax both in automatic
partitioning and in manual (PARTITION OF...)

-- 
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

--000000000000db592905b71f97db
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><br>&gt; BTW could you tell me a couple of words about p=
ros and cons of c-code<br>
&gt; syntax parsing comparing to parsing using gram.y trees?<br>
<br>
I&#39;d rather use an automatic tool (lexer/parser) if possible instead of =
<br>
doing it by hand if I can. If you want a really nice syntax with clever <br=
>
tricks, then you may need to switch to manual though, but pg/sql is not in =
<br>
that class.<br>
<br>
&gt; I think both are possible but my predisposition was that we&#39;d bett=
er use <br>
&gt; the later if possible.<br>
<br>
I agree.<br></blockquote><div>Thank you!</div><div><br></div><div>Fabien, d=
o you consider it possible to change the syntax of declarative partitioning=
 too? It is problematic as it is already committed but also is very temptin=
g=C2=A0to have the same type of syntax both in automatic partitioning and i=
n manual (PARTITION OF...)</div><div><br></div></div>-- <br><div dir=3D"ltr=
" class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"=
ltr"><div>Best regards,<br>Pavel Borisov<br><br>Postgres Professional: <a h=
ref=3D"http://www.postgrespro.com" rel=3D"noopener noreferrer" target=3D"_b=
lank">http://postgrespro.com</a><br></div></div></div></div>

--000000000000db592905b71f97db--