MIME-Version: 1.0
References: <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023>
 <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023>
 <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
 <Zjvwqs-GV0MjWIhU@pryzbyj2023>
 <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
 <ZkN6EfjQGz8TOhbL@pryzbyj2023>
 <CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
 <ai_c4-v8iLA2kXFV@pryzbyj2023>
 <CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA@mail.gmail.com>
 <CALT9ZEFrDgha=RyOuWru45FTk9Dbj5FF-fTw0NnE8n1FwBb2yg@mail.gmail.com>
 <CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com>
From: Pavel Borisov <pashkin.elfe@gmail.com>
Date: Tue, 16 Jun 2026 01:56:50 +0400
Message-ID: 
 <CALT9ZEG0YmzH+3M6PixHUNq13pYt+yh8sAgonfaut=g_ij=oZw@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Dmitry Koval <d.koval@postgrespro.ru>,
	Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers@lists.postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALT9ZEG0YmzH%2B3M6PixHUNq13pYt%2Byh8sAgonfaut%3Dg_ij%3DoZw%40mail.gmail.com>
Precedence: bulk

Hi, Alexander!

I looked into the patch. It's simple enough and looks good to me.
I have one question: is it correct to pass 0 reloptions to
NewRelationCreateToastTable or we need to use transformRelOptions +
heap_reloptions pair to derive toast_reloptions as it is done in
ProcessUtilitySlow() and create_ctas_internal()?

Regards,
Pavel Borisov