Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wZTQO-0014Gu-0c
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 16 Jun 2026 13:01:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wZTQN-0001QX-0a
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 16 Jun 2026 13:01:51 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pashkin.elfe@gmail.com>)
	id 1wZTQM-0001QI-2u
	for pgsql-hackers@lists.postgresql.org;
	Tue, 16 Jun 2026 13:01:50 +0000
Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.98.2)
	(envelope-from <pashkin.elfe@gmail.com>)
	id 1wZTQL-00000000e0L-3LEu
	for pgsql-hackers@lists.postgresql.org;
	Tue, 16 Jun 2026 13:01:50 +0000
Received: by mail-ed1-x532.google.com with SMTP id
 4fb4d7f45d1cf-692491fec0bso7627940a12.2
        for <pgsql-hackers@lists.postgresql.org>;
 Tue, 16 Jun 2026 06:01:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1781614908; cv=none;
        d=google.com; s=arc-20240605;
        b=I56AOS9WjLSJgCbKGZYwRUgGAyLhE2zoXuGIbVfkqXr/juXl2hcVkYJsDbUJRGHxl+
         Wzu5qd84MeSRZttZ79UncYcUxFmaqvabF/9HZamVEthRN800Qmx67af0Ked1fEeABfKa
         MOrM2bwE+stvI8JR7jIDJ7U6eCo9h3hPdb19iPXo3OiNJKgfLlAx3qGkkDrneC5Fq/gW
         Sb17WeWsJ2sYD6IteOgtwOgwYLoASbgLxJG1xUcXYLsu3Ecit5smO881n+fxvkS6OnQZ
         /RsrF5t1nA8QQlur7jsejxOJuqYR3fgyWNZopS9GhfmFvAqJ+gEK4YL2RoIPEaMNXAUp
         PQRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
 s=arc-20240605;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:dkim-signature;
        bh=soDfb5nNDI8iG5M1iJVY3l3YDEkBKaz9I/QF+8GXzi4=;
        fh=xC0yVh9S5AUOymr1j+uRNpmPJS1PXS3OdI6u6s136WE=;
        b=gJ5O9MGws8wr8BXkHug2DbN1yA8eN/RZX6n6EUg+uFAVdjya1XqBOPxK6wUUbFw8Py
         OCxfPR4HS+VXZdAwR3XomlYXOCxnn7WA8zV7H/QSMVslqkLyV5lBvO+1Dk8/oXFOHTsV
         /EsPJhFeMKLdkO6BD9MfM0x7VXIK8IEK14JGJebxGV+htkY+xnw+4supPBmkDRd6Rm8y
         JfmFzWEeXkfcxj4CI19VP2SscIdphubrQtITpx4/bX+lG3EHJTLIiqiOI7ANq47WpsTY
         vtzvDazGGx0n3nibxPIHVRZ7x/Uy1mE+C7kPrGJeIZgSU5QZviOnM9bwDFdKAz1sVs5K
         DBjA==;
        darn=lists.postgresql.org
ARC-Authentication-Results: i=1; mx.google.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1781614908; x=1782219708;
 darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=soDfb5nNDI8iG5M1iJVY3l3YDEkBKaz9I/QF+8GXzi4=;
        b=fLPfbhQvNSOEhEziy9KuhhCFa6/JcsCLVLWmVXdUWDIPNQSzUx0+znWv/zQrLq1lKQ
         JrNhnbUDJKN8r3M7wugJvxA1AQvfBblGPYcTwRuLVFvKhs1nCzKVPjHfM49qNDRehoFh
         5ur5VqOTzpzZ9mSpsQ6/X6Hp7p0fOn+J4WsL5lWk1Nxij8axjtjbnw9dwWwkNJoPVWpz
         lociyb6QIe4lrW/+ET/zvTtuLpj0E8ipOzrapomopYzKgX0Zsf7JC8QGT4wt6HZ6dghO
         /WBsPDZHnuA31A1sZTWoPVvc6z5h36XvfcP5garUNdKxlICCwpRCzjL7sH7F9tY0zFNM
         NVmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1781614908; x=1782219708;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=soDfb5nNDI8iG5M1iJVY3l3YDEkBKaz9I/QF+8GXzi4=;
        b=OUWEujWmTg+u/rjfVlrJER+mfrJKOjglq8vr95bKMMvexPew11MV/kzjFotVH8I4Sa
         VVtN595GIVSOjzb//ueXePjh4upo867aLKivDI9o3e0uAYXSJnlcMzZjfQIZarRnPK9V
         DLOy1394wZRiCPMycS6HwLHk4R/oZzIOfHvX3e5tupR31hy3vsGdrF6URIh7bx1ytWS1
         lo1o9tQhssXW8GIslDsIbJ3J4teM2OloZHR3vGgdDYpD3jM/yRxunmoZBV1kci6GuqFN
         SbSghyr9ENtWPZmzBwi5fbuVURDml68WlH+i8c1/R5bSnSdcILXCqYkuuOfJUK6jbFfu
         ow1w==
X-Forwarded-Encrypted: i=1;
 AFNElJ+e3lhu4iuv5mVbOLn3tstG/bld96di3lZiMkJbxlTzXvGI0va0raFghsiV5yJXXaeiXwMrPlpFi3zTZCPF@lists.postgresql.org
X-Gm-Message-State: AOJu0Ywani8NoibY01YXjoogljVLCL3XbRhe4a1Bxlnicz8/W5JS7xIH
	JUpmgpZSeiEIOhBMFcOySswCs7gGHg/iyaZbPSTDulqI+HBYi2JwWo07F4teJVWLR6YL2afAub1
	0BTs5YsMJxjZT7++XM6eUo/wIi/1KFmXyp2Z6awQ=
X-Gm-Gg: Acq92OEk2EiUUoSkTFus+5Houcd0xSWTErEhCla+LdZq4aE3F+BYw9HS1YjyNSZ44iU
	uZAM8qzDE+YazIKoxmFVf0vJeeYNhI/k7WjQS9VX+CSdrcUKgeA33i6CN2inSW24k9sEYhT6Iw6
	RjT+1HBjxFnaSpxN06Xpdm1awhRBwseOAgY50auJG98Y+6E4YybRlTv71nLCR90r7PxoLpq7Wqc
	zg7JJ+Dd5wWEmEuJHfSXPioKvEGTx3gjkivP3qBt1Wds7S+1sbmdVA5BMxuSmFItxy0vrXrJgWX
	O2Nxa7FEJw==
X-Received: by 2002:a05:6402:4589:b0:68f:cca5:51e8 with SMTP id
 4fb4d7f45d1cf-69378a94346mr9121739a12.27.1781614907437; Tue, 16 Jun 2026
 06:01:47 -0700 (PDT)
MIME-Version: 1.0
References: <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023>
 <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023>
 <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
 <Zjvwqs-GV0MjWIhU@pryzbyj2023>
 <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
 <ZkN6EfjQGz8TOhbL@pryzbyj2023>
 <CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
 <ai_c4-v8iLA2kXFV@pryzbyj2023>
 <CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA@mail.gmail.com>
 <CALT9ZEFrDgha=RyOuWru45FTk9Dbj5FF-fTw0NnE8n1FwBb2yg@mail.gmail.com>
 <CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com>
 <CALT9ZEG0YmzH+3M6PixHUNq13pYt+yh8sAgonfaut=g_ij=oZw@mail.gmail.com>
 <CAPpHfdtVp5Xxz59Zse+Gg_oWvZPpwjr+gcVtWq-5pTp0Rsh8gQ@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdtVp5Xxz59Zse+Gg_oWvZPpwjr+gcVtWq-5pTp0Rsh8gQ@mail.gmail.com>
From: Pavel Borisov <pashkin.elfe@gmail.com>
Date: Tue, 16 Jun 2026 17:01:34 +0400
X-Gm-Features: AVVi8CcNJ07EJH2MvvHUHtFdau9-Gr5kVrYTfTismkI0-Z9r7ad0dks-m8TBJ80
Message-ID: 
 <CALT9ZEG39=w6zvDqpKc479WjmeNGFMwdJxi=Ut7z4JUN386URg@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Dmitry Koval <d.koval@postgrespro.ru>,
	Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers@lists.postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CALT9ZEG39%3Dw6zvDqpKc479WjmeNGFMwdJxi%3DUt7z4JUN386URg%40mail.gmail.com>
Precedence: bulk

Hi, Alexander!

> Extending the syntax to accept WITH (...) on new partitions would be a
> separate, larger feature.  Out of scope for this bug fix.

I agree, this is out of scope of a fix.
Updated test in v2 and overall patch looks good to me.

A couple of wording proposals:
never gave it -> never gives it
Merged partitions need their own TOAST table -> A merged partition
needs its own TOAST table.
re-stored -> stored
a short string suffices -> a string over that threshold suffices

Regards,
Pavel Borisov,
Supabase