public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 2/6] 0001 review
2+ messages / 2 participants
[nested] [flat]
* [PATCH 2/6] 0001 review
@ 2021-02-15 15:26 Tomas Vondra <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Tomas Vondra @ 2021-02-15 15:26 UTC (permalink / raw)
---
doc/src/sgml/monitoring.sgml | 2 +-
src/backend/commands/copyfrom.c | 1 +
src/backend/commands/copyto.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 3c39c82f1a..c5048fefd4 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6561,7 +6561,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
The io target that the data is read from or written to:
<literal>FILE</literal>, <literal>PROGRAM</literal>,
- <literal>STDIO</literal> (for COPY FROM STDIN and COPY TO STDOUT),
+ <literal>STDIO</literal> (for <command>COPY FROM STDIN</command> and <command>COPY TO STDOUT</command>),
or <literal>CALLBACK</literal> (used in the table synchronization
background worker).
</para></entry>
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
index c3610eb67e..d98f447cf5 100644
--- a/src/backend/commands/copyfrom.c
+++ b/src/backend/commands/copyfrom.c
@@ -1508,6 +1508,7 @@ BeginCopyFrom(ParseState *pstate,
ReceiveCopyBinaryHeader(cstate);
}
+ /* XXX this block seems weird */
{
int64 io_target;
switch (cstate->copy_src)
diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c
index 42c4a828df..4b76bf5ef6 100644
--- a/src/backend/commands/copyto.c
+++ b/src/backend/commands/copyto.c
@@ -772,6 +772,8 @@ BeginCopyTo(ParseState *pstate,
/* initialize progress */
pgstat_progress_start_command(PROGRESS_COMMAND_COPY,
cstate->rel ? RelationGetRelid(cstate->rel) : InvalidOid);
+
+ /* XXX this too */
{
const int progress_index[] = {
PROGRESS_COPY_COMMAND,
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0003-Add-backlinks-to-progress-reporting-documentation.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename*0="v7-0003-Add-backlinks-to-progress-reporting-documentation.pa";
filename*1="tch"
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Problem with moderation of messages with patched attached.
@ 2022-03-03 13:22 Pavel Borisov <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Borisov @ 2022-03-03 13:22 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Postgres hackers <[email protected]>
>
> Message to list pgsql-hackers held for moderation due to 'Size 1MB
> (1061796 bytes) is larger than threshold 1000KB (1024000 bytes)', notice
> queued for 2 moderators
>
Could you make this limit 2MB at least for authorized commitfest members?
Thanks!
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com;
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-03-03 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:26 [PATCH 2/6] 0001 review Tomas Vondra <[email protected]>
2022-03-03 13:22 Re: Problem with moderation of messages with patched attached. Pavel Borisov <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox