Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsHqu-00ElNK-0F for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 09:58:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vsHqr-009Zf1-1Q for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 09:58:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsHqq-009Zes-39 for pgsql-hackers@lists.postgresql.org; Tue, 17 Feb 2026 09:58:41 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vsHqo-000000012PQ-1biL for pgsql-hackers@postgresql.org; Tue, 17 Feb 2026 09:58:40 +0000 Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-89549b2f538so103964736d6.2 for ; Tue, 17 Feb 2026 01:58:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771322318; cv=none; d=google.com; s=arc-20240605; b=gLNJOJVLxhy5BnCqyAGu0XMOg3qFRrZg5X366mbQJG1gf7pohxIgyE8/v3uZWmwHTv h8BXKaaEnauKA6gEf2fb/TtsgJtnTHixWwh6rVropWNC9rvV8kT7uK1H7X2Cxw3I8XdU UckdEyYrNFxVu8Y9iqIundlMT15F4R66XsdSjWgW4UvzwkiojjCGE3pTIiPc3/v+/SY+ dnyANMliwhmZuZtLfoJVFAxkram/eNQ8O8gVhAg4m5JX10Xr3rV81PWrRNeC3HMdVv+I Vv8WzlJMWKXMHtOLX45tuO7rCo1Djc2QN4/Bqz9FmlpUfCCWivsULQ4n6UqdaQMMJ+dz +Apw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:from:mime-version:dkim-signature; bh=RjfeybTUitkwH7AF1AxnJxY9CRcxF5fVsBbEJKtto6Y=; fh=RfrkJab44jNT7RraF/sJO97r9/nkUL0AAgzmC7PBS2w=; b=QxUN0mmhD2wHlEER4r7cviFZjiylym9Fasijm5co6IQYpjFXQpTSAEfv95ObSC7gQJ 2WYTx20x63ZA3B3e+NVdDl5LymKcRCM3vAFuEYAWW75bBipR5ppmJjsZ71VJ4QQR4pXq pVr8AcQYiDa8kTtDK7qpiUONfY2B2vnYH8tCOtD7jV2fNGY3QNMMemj+ISRXntPmfKma CBSlk5mDBDY7oc+fcRW7AeJqBP85+vhcdnS3Lhmtw7CBXNrcKDVa7V1il7BDpMEBRWjp HgckY/d3FAP7A40jM48SwQgAQOwhSn1HxscwSBeZvu9ifyD2beqcXy7gbwK4ufqIGaeu oggA==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771322318; x=1771927118; darn=postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=RjfeybTUitkwH7AF1AxnJxY9CRcxF5fVsBbEJKtto6Y=; b=NLJJTxla4AHycR5bL/YkDDiSniNkY/2siid7OAom6+/mo373xd4sDBRGq/MaIjYu4B i5Oa16i2PbWGVOgv+X88Wfl0vi0rHjkNOpW9VJlfJ2dcy/1mxQ0PNstLWaPAN+C8Z1B8 zUp9/q0cwE9tOO2PaJHWy4ObTTzCFyDY5wPpgdyo8EviblIlgr2Kdumiukl4WCbn8AZH i7s/fdrSZHFUrWev4niCc0KG1Lb5szlq58BCKUqToqbaicsiXbLTjRp2QNUjiz3sj1Id TLr1pw6IPHzTSzqkohvakQ4UPjrAXVsODrg8WklaoDqOgGFpohBmpzenJVinChMm+it8 FqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771322318; x=1771927118; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RjfeybTUitkwH7AF1AxnJxY9CRcxF5fVsBbEJKtto6Y=; b=e2jy6Z8bIQna9+s2NECKUjZXZftE0QMBeX0M2YHItW5Qt1px5Thy3kcBwUxjbY7vx3 6wYqE7agGzlhzRLZM7HQfTkOGUy4qJMeeaG9L7k8MB7AET/P15Gwh6m7eCu4Fe4Qdggx G/7WnYwbFMHs96Uto46zbnQo8ayY76oGnoFiX3o8UdrHgTv+5QaQNaQUD+0saWbo1UIL T9Z2ebnuOI6VZ5v/Q0nqHebv0OjwPuYVNm1ZGEAWPUtYU+KG0M8ij19Tc07ErrWF0or9 9HJaidRE2TWPF+SinarnpQ7aVtbrcb0BwFX2NuJOeJAqQVjEKe4J3BMOikr/B1DjFNLU E05w== X-Gm-Message-State: AOJu0Yz5qQ7lT2PX7HqGu/jp/AvbzXmm8BIHZblgyYH2k1Qg4HSYxyv3 +4rVnMLVsRSib76zG/5iVQ9GTbHrtWcgoBb5w8lWGvCjW9gIK+NA+noUvrGxQvhx/BHswpU0FNG tPKWnBkc23g5fhmXJNLsE+quZcODUUnqDv6JX X-Gm-Gg: AZuq6aKnRwnPVi7xZvg1eUDOGsgPvU1rvN/6FtdKyxJ28RynkAGuk3pwxa/7tK6f5qa cjGsO0xfDT4Z+JAn0qQyKiqjXiQMFJh8bzzWRV28c35JGESPwV1EgR3/4r4AL+fLZuKkD9EjgfV c89mVVyF5V6nJFB8Hz4XHKI/yGmyABcXgtF+2l4bjDM0glZxY9Q3BDLmfn1IJ+VujaqLTbjtysj eVQY8c4IwuXIYrDDtyjdsjp/xbDzzKdTfyHVBdnaOoagxg7GYDNrmN0G5B/vwaO3ie2blUHCb7m WIrEyfmRqW3WVt9klIvK1DbTw7PGlisXwCN/aFBqZAFqKFD2fLA65T5a1CJ1WK8WZNX31S+x/A0 bo5Sjwp3QpaORDs1v X-Received: by 2002:a05:622a:24d:b0:506:9b5f:dcf6 with SMTP id d75a77b69052e-506b4044e6cmr123771361cf.80.1771322318030; Tue, 17 Feb 2026 01:58:38 -0800 (PST) MIME-Version: 1.0 From: Kirill Reshke Date: Tue, 17 Feb 2026 14:58:24 +0500 X-Gm-Features: AaiRm53Puk_dc-0DW9N3LbM0fT3SWUeHfXjEk2MS9rNtJovcqXUw419bES3DzH0 Message-ID: Subject: Release and unpin buffers after leaving CRIT section in GIN. To: pgsql-hackers Content-Type: multipart/mixed; boundary="0000000000008ca800064b021d34" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000008ca800064b021d34 Content-Type: text/plain; charset="UTF-8" Hi I have stopped $subj while doing unrelated hacking today. transam/README suggest following for WAL-logging changes: ... 6. END_CRIT_SECTION() 7. Unlock and unpin the buffer(s). Few places in GIN code does not follow that. v1 fixes it. -- Best regards, Kirill Reshke --0000000000008ca800064b021d34 Content-Type: application/octet-stream; name="v1-0001-Release-and-unpin-buffers-after-leaving-CRIT-sect.patch" Content-Disposition: attachment; filename="v1-0001-Release-and-unpin-buffers-after-leaving-CRIT-sect.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mlqfi24v0 RnJvbSBjNWVkZWY5MWI0NzlkZGNkOTliZTVmZTUwMGY3YTEwZWMxYjJhZThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFR1 ZSwgMTcgRmViIDIwMjYgMDk6NTM6MjcgKzAwMDAKU3ViamVjdDogW1BBVENIIHYxXSBSZWxlYXNl IGFuZCB1bnBpbiBidWZmZXJzIGFmdGVyIGxlYXZpbmcgQ1JJVCBzZWN0aW9uIGluCiBHSU4uCgpU aGlzIHBhdGNoZXMgY2xlYW51cCBhIGZldyBwbGFjZXMgaW4gR0lOIGNvZGUgdGhhdAp1c2VkIHRv IHJlbGVhc2UgYW5kL29yIHVucGluIGJ1ZmZlcnMgYmVmb3JlIGxlYXZpbmcgQ1JJVApzZWN0aW9u IGJ1dCBub3QgYWZ0ZXIuIFRoZSBsYXR0ZXIgaXMgc3VnZ2VzdGVkIGJ5IHRyYW5zYW0vUkVBRE1F LgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2luZGF0YXBhZ2UuYyB8ICA0ICsrLS0KIHNy Yy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2luZmFzdC5jICAgICB8IDEyICsrKysrKy0tLS0tLQogc3Jj L2JhY2tlbmQvYWNjZXNzL2dpbi9naW5pbnNlcnQuYyAgIHwgIDMgKystCiBzcmMvYmFja2VuZC9h Y2Nlc3MvZ2luL2dpbnV0aWwuYyAgICAgfCAgNCArKy0tCiBzcmMvYmFja2VuZC9hY2Nlc3MvZ2lu L2dpbnZhY3V1bS5jICAgfCAgNiArKystLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9u cygrKSwgMTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dp bi9naW5kYXRhcGFnZS5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW5kYXRhcGFnZS5jCmlu ZGV4IDQzNmU1NGYyMDY2Li5jNWQ3ZGIyODA3NyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNj ZXNzL2dpbi9naW5kYXRhcGFnZS5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2luZGF0 YXBhZ2UuYwpAQCAtMTg1NCwxMCArMTg1NCwxMCBAQCBjcmVhdGVQb3N0aW5nVHJlZShSZWxhdGlv biBpbmRleCwgSXRlbVBvaW50ZXJEYXRhICppdGVtcywgdWludDMyIG5pdGVtcywKIAkJUGFnZVNl dExTTihwYWdlLCByZWNwdHIpOwogCX0KIAotCVVubG9ja1JlbGVhc2VCdWZmZXIoYnVmZmVyKTsK LQogCUVORF9DUklUX1NFQ1RJT04oKTsKIAorCVVubG9ja1JlbGVhc2VCdWZmZXIoYnVmZmVyKTsK KwogCS8qIER1cmluZyBpbmRleCBidWlsZCwgY291bnQgdGhlIG5ld2x5LWFkZGVkIGRhdGEgcGFn ZSAqLwogCWlmIChidWlsZFN0YXRzKQogCQlidWlsZFN0YXRzLT5uRGF0YVBhZ2VzKys7CmRpZmYg LS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dpbmZhc3QuYyBiL3NyYy9iYWNrZW5kL2Fj Y2Vzcy9naW4vZ2luZmFzdC5jCmluZGV4IDdhNmIxNzc5NzdiLi5mNTA4NDhlYjY1YSAxMDA2NDQK LS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW5mYXN0LmMKKysrIGIvc3JjL2JhY2tlbmQv YWNjZXNzL2dpbi9naW5mYXN0LmMKQEAgLTEzNCwxMCArMTM0LDEwIEBAIHdyaXRlTGlzdFBhZ2Uo UmVsYXRpb24gaW5kZXgsIEJ1ZmZlciBidWZmZXIsCiAJLyogZ2V0IGZyZWUgc3BhY2UgYmVmb3Jl IHJlbGVhc2luZyBidWZmZXIgKi8KIAlmcmVlc2l6ZSA9IFBhZ2VHZXRFeGFjdEZyZWVTcGFjZShw YWdlKTsKIAotCVVubG9ja1JlbGVhc2VCdWZmZXIoYnVmZmVyKTsKLQogCUVORF9DUklUX1NFQ1RJ T04oKTsKIAorCVVubG9ja1JlbGVhc2VCdWZmZXIoYnVmZmVyKTsKKwogCXJldHVybiBmcmVlc2l6 ZTsKIH0KIApAQCAtNDU5LDEwICs0NTksMTAgQEAgZ2luSGVhcFR1cGxlRmFzdEluc2VydChHaW5T dGF0ZSAqZ2luc3RhdGUsIEdpblR1cGxlQ29sbGVjdG9yICpjb2xsZWN0b3IpCiAJaWYgKG1ldGFk YXRhLT5uUGVuZGluZ1BhZ2VzICogR0lOX1BBR0VfRlJFRVNJWkUgPiBjbGVhbnVwU2l6ZSAqIChT aXplKSAxMDI0KQogCQluZWVkQ2xlYW51cCA9IHRydWU7CiAKLQlVbmxvY2tSZWxlYXNlQnVmZmVy KG1ldGFidWZmZXIpOwotCiAJRU5EX0NSSVRfU0VDVElPTigpOwogCisJVW5sb2NrUmVsZWFzZUJ1 ZmZlcihtZXRhYnVmZmVyKTsKKwogCS8qCiAJICogU2luY2UgaXQgY291bGQgY29udGVuZCB3aXRo IGNvbmN1cnJlbnQgY2xlYW51cCBwcm9jZXNzIHdlIGNsZWFudXAKIAkgKiBwZW5kaW5nIGxpc3Qg bm90IGZvcmNpYmx5LgpAQCAtNjU5LDExICs2NTksMTEgQEAgc2hpZnRMaXN0KFJlbGF0aW9uIGlu ZGV4LCBCdWZmZXIgbWV0YWJ1ZmZlciwgQmxvY2tOdW1iZXIgbmV3SGVhZCwKIAkJCX0KIAkJfQog CisJCUVORF9DUklUX1NFQ1RJT04oKTsKKwogCQlmb3IgKGkgPSAwOyBpIDwgZGF0YS5uZGVsZXRl ZDsgaSsrKQogCQkJVW5sb2NrUmVsZWFzZUJ1ZmZlcihidWZmZXJzW2ldKTsKIAotCQlFTkRfQ1JJ VF9TRUNUSU9OKCk7Ci0KIAkJZm9yIChpID0gMDsgZmlsbF9mc20gJiYgaSA8IGRhdGEubmRlbGV0 ZWQ7IGkrKykKIAkJCVJlY29yZEZyZWVJbmRleFBhZ2UoaW5kZXgsIGZyZWVzcGFjZVtpXSk7CiAK ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2luaW5zZXJ0LmMgYi9zcmMvYmFj a2VuZC9hY2Nlc3MvZ2luL2dpbmluc2VydC5jCmluZGV4IDBkNjNmYjRiYTI3Li5jOTcyODQ4YjI5 ZSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW5pbnNlcnQuYworKysgYi9z cmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dpbmluc2VydC5jCkBAIC02NTIsOSArNjUyLDEwIEBAIGdp bmJ1aWxkKFJlbGF0aW9uIGhlYXAsIFJlbGF0aW9uIGluZGV4LCBJbmRleEluZm8gKmluZGV4SW5m bykKIAlNYXJrQnVmZmVyRGlydHkoUm9vdEJ1ZmZlcik7CiAKIAorCUVORF9DUklUX1NFQ1RJT04o KTsKKwogCVVubG9ja1JlbGVhc2VCdWZmZXIoTWV0YUJ1ZmZlcik7CiAJVW5sb2NrUmVsZWFzZUJ1 ZmZlcihSb290QnVmZmVyKTsKLQlFTkRfQ1JJVF9TRUNUSU9OKCk7CiAKIAkvKiBjb3VudCB0aGUg cm9vdCBhcyBmaXJzdCBlbnRyeSBwYWdlICovCiAJYnVpbGRzdGF0ZS5idWlsZFN0YXRzLm5FbnRy eVBhZ2VzKys7CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dpbnV0aWwuYyBi L3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2ludXRpbC5jCmluZGV4IGQyMDUwOTNlMjFkLi5mZjky NzI3OWNjMyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW51dGlsLmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW51dGlsLmMKQEAgLTY2Myw5ICs2NjMsOSBAQCBn aW5VcGRhdGVTdGF0cyhSZWxhdGlvbiBpbmRleCwgY29uc3QgR2luU3RhdHNEYXRhICpzdGF0cywg Ym9vbCBpc19idWlsZCkKIAkJUGFnZVNldExTTihtZXRhcGFnZSwgcmVjcHRyKTsKIAl9CiAKLQlV bmxvY2tSZWxlYXNlQnVmZmVyKG1ldGFidWZmZXIpOwotCiAJRU5EX0NSSVRfU0VDVElPTigpOwor CisJVW5sb2NrUmVsZWFzZUJ1ZmZlcihtZXRhYnVmZmVyKTsKIH0KIAogLyoKZGlmZiAtLWdpdCBh L3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2ludmFjdXVtLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3Mv Z2luL2dpbnZhY3V1bS5jCmluZGV4IDExYTY2NzRhMTBiLi5jOWYxNDNmNmMzMSAxMDA2NDQKLS0t IGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9naW52YWN1dW0uYworKysgYi9zcmMvYmFja2VuZC9h Y2Nlc3MvZ2luL2dpbnZhY3V1bS5jCkBAIC0yMjQsMTIgKzIyNCwxMiBAQCBnaW5EZWxldGVQYWdl KEdpblZhY3V1bVN0YXRlICpndnMsIEJsb2NrTnVtYmVyIGRlbGV0ZUJsa25vLCBCbG9ja051bWJl ciBsZWZ0QmxrbgogCQlQYWdlU2V0TFNOKEJ1ZmZlckdldFBhZ2UobEJ1ZmZlciksIHJlY3B0cik7 CiAJfQogCisJRU5EX0NSSVRfU0VDVElPTigpOworCiAJUmVsZWFzZUJ1ZmZlcihwQnVmZmVyKTsK IAlSZWxlYXNlQnVmZmVyKGxCdWZmZXIpOwogCVJlbGVhc2VCdWZmZXIoZEJ1ZmZlcik7CiAKLQlF TkRfQ1JJVF9TRUNUSU9OKCk7Ci0KIAlndnMtPnJlc3VsdC0+cGFnZXNfbmV3bHlfZGVsZXRlZCsr OwogCWd2cy0+cmVzdWx0LT5wYWdlc19kZWxldGVkKys7CiB9CkBAIC02NTQsOCArNjU0LDggQEAg Z2luYnVsa2RlbGV0ZShJbmRleFZhY3V1bUluZm8gKmluZm8sIEluZGV4QnVsa0RlbGV0ZVJlc3Vs dCAqc3RhdHMsCiAJCQlQYWdlUmVzdG9yZVRlbXBQYWdlKHJlc1BhZ2UsIHBhZ2UpOwogCQkJTWFy a0J1ZmZlckRpcnR5KGJ1ZmZlcik7CiAJCQl4bG9nVmFjdXVtUGFnZShndnMuaW5kZXgsIGJ1ZmZl cik7Ci0JCQlVbmxvY2tSZWxlYXNlQnVmZmVyKGJ1ZmZlcik7CiAJCQlFTkRfQ1JJVF9TRUNUSU9O KCk7CisJCQlVbmxvY2tSZWxlYXNlQnVmZmVyKGJ1ZmZlcik7CiAJCX0KIAkJZWxzZQogCQl7Ci0t IAoyLjQzLjAKCg== --0000000000008ca800064b021d34--