MIME-Version: 1.0
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <ff99283d-f9d4-4b37-b4fa-3a433fb408a4@tantorlabs.com> <e1f5b560691a4fe693625d529e19e13959210568.camel@moonset.ru>
 <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com> <c82e7776-7841-42a0-9247-878584174750@tantorlabs.com>
 <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru> <CACJufxHb_YGCp=pVH6DZcpk9yML+SueffPeaRbX2LzXZVahd_w@mail.gmail.com>
 <CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com>
 <78394e29-a900-4af4-b5ce-d6eb2d263fad@postgrespro.ru> <CACJufxGkvk7bVeidQoEtUt=PsReQTMKFD1NeeM9u3cJ0TStm6Q@mail.gmail.com>
In-Reply-To: <CACJufxGkvk7bVeidQoEtUt=PsReQTMKFD1NeeM9u3cJ0TStm6Q@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Thu, 22 Aug 2024 09:29:58 +0500
Message-ID: <CALdSSPgEqTy85VPTJ9k=9t4iajkjSZevcAYAYCpRTR6iZ34PhQ@mail.gmail.com>
Subject: Re: Vacuum statistics
To: jian he <jian.universality@gmail.com>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, 
	Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, Andrei Zubkov <zubkov@moonset.ru>, 
	Alena Rybakina <lena.ribackina@yandex.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, 
	a.lepikhov@postgrespro.ru
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALdSSPgEqTy85VPTJ9k%3D9t4iajkjSZevcAYAYCpRTR6iZ34PhQ%40mail.gmail.com>
Precedence: bulk

On Thu, 22 Aug 2024 at 07:48, jian he <jian.universality@gmail.com> wrote:
>
> On Wed, Aug 21, 2024 at 6:37=E2=80=AFAM Alena Rybakina
> <a.rybakina@postgrespro.ru> wrote:
> >
> > We check it there: "tabentry->vacuum_ext.type !=3D type". Or were you t=
alking about something else?
> >
> > On 19.08.2024 12:32, jian he wrote:
> >
> > in pg_stats_vacuum
> >     if (type =3D=3D PGSTAT_EXTVAC_INDEX || type =3D=3D PGSTAT_EXTVAC_HE=
AP)
> >     {
> >         Oid                    relid =3D PG_GETARG_OID(1);
> >
> >         /* Load table statistics for specified database. */
> >         if (OidIsValid(relid))
> >         {
> >             tabentry =3D fetch_dbstat_tabentry(dbid, relid);
> >             if (tabentry =3D=3D NULL || tabentry->vacuum_ext.type !=3D =
type)
> >                 /* Table don't exists or isn't an heap relation. */
> >                 PG_RETURN_NULL();
> >
> >             tuplestore_put_for_relation(relid, rsinfo, tabentry);
> >         }
> >         else
> >         {
> >        }
> >
> >
> > So for functions pg_stat_vacuum_indexes and pg_stat_vacuum_tables,
> > it seems you didn't check "relid" 's relkind,
> > you may need to use get_rel_relkind.
> >
> > --
>
> hi.
> I mentioned some points at [1],
> Please check the attached patchset to address these issues.
>
> there are four occurrences of "CurrentDatabaseId", i am still confused
> with usage of CurrentDatabaseId.
>
> also please don't  top-post, otherwise the archive, like [2] is not
> easier to read for future readers.
> generally you quote first, then reply.
>
> [1] https://postgr.es/m/CACJufxHb_YGCp=3DpVH6DZcpk9yML+SueffPeaRbX2LzXZVa=
hd_w@mail.gmail.com
> [2] https://postgr.es/m/78394e29-a900-4af4-b5ce-d6eb2d263fad@postgrespro.=
ru

Hi, your points are valid.
Regarding 0003, I also wanted to object database naming in a
regression test during my review but for some reason didn't.Now, as
soon as we already need to change it, I suggest we also change
regression_statistic_vacuum_db1 to something less generic. Maybe
regression_statistic_vacuum_db_unaffected.


--=20
Best regards,
Kirill Reshke