MIME-Version: 1.0
References: 
 <CAAKRu_ZP-3=SaZykpwDBMJOdUKyW3Wm5JZfPFRR3L5Ac8ouq4w@mail.gmail.com>
 <CAAKRu_bgkOQqu3K5n4YLRsNBZqJ9Rjg80ROqgKSr2UGz4b5hUg@mail.gmail.com>
 <2wk7jo4m4qwh5sn33pfgerdjfujebbccsmmlownybddbh6nawl@mdyyqpqzxjek>
 <CAAKRu_YR-COJ9aGnMUQqt5yoWmUBjikqrd4jGNZYouHaXpis9g@mail.gmail.com>
 <CALdSSPhiCwJwWwgJP1NmqRmnp9RS2tGOBY0gQrfLCbB+OS5_KQ@mail.gmail.com>
 <CAAKRu_YS+Ocm=OzMaZnG4egFiE9v4VYfZ25DXd6jbwegqmGYbQ@mail.gmail.com>
 <CAAKRu_ZGZSqhGt-RcmmfiSheC+1fjQdxy6_+oM-1jMn8hyVptQ@mail.gmail.com>
 <CALdSSPg+B8RTzTXhJvCcKJBqgzhPZkq0E2oqxQdv74ZNZOMVzg@mail.gmail.com>
 <CAAKRu_Zha7HcdQBv8tTtQrcry5332J6kHnOc1X=TT03LzUXDow@mail.gmail.com>
 <CAAKRu_amF00f2T_H8N6pbbe75C22EeX1OqA=svpj8LNO1sdUuw@mail.gmail.com>
 <mhf4vkmh3j57zx7vuxp4jagtdzwhu3573pgfpmnjwqa6i6yj5y@sy4ymcdtdklo>
 <CAAKRu_agCLAQ9OjmrTdJe-X=Xr7QnU4d=cfxdQGwc9jNx9w31w@mail.gmail.com>
 <CAAKRu_ayWLg=WDGZZfSPWf0KjPM8u=LBb0D6XaEWyx2_YFFwAQ@mail.gmail.com>
 <CALdSSPhtPK36_sr9yFo3cN9TXQmjvSX3BZXCF8fVBLX-GETD0Q@mail.gmail.com>
 <CAAKRu_Yt6EH5aFSJBm-k7PrNM4bTt56fTRbyU7gqYXe4cW+F9g@mail.gmail.com>
 <CALdSSPhH7hi+EzYqq0=eMCthi7iNpY_YyECAC1qxPb7rd0TLrw@mail.gmail.com>
 <CAAKRu_baqEkdJ0_1vokvgbaN52ycR65HM2-DR-VsRmYVVQLV8w@mail.gmail.com>
In-Reply-To: 
 <CAAKRu_baqEkdJ0_1vokvgbaN52ycR65HM2-DR-VsRmYVVQLV8w@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Thu, 18 Dec 2025 23:07:20 +0500
Message-ID: 
 <CALdSSPgKH7TdW0zcDPjBxx+MX18bjc65K12KgoGtX6ZP8Qq63w@mail.gmail.com>
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM
 on-access)
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
	Chao Li <li.evan.chao@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000cfdef206463dd532"
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPgKH7TdW0zcDPjBxx%2BMX18bjc65K12KgoGtX6ZP8Qq63w%40mail.gmail.com>
Precedence: bulk

--000000000000cfdef206463dd532
Content-Type: text/plain; charset="UTF-8"

On Thu, 18 Dec 2025 at 20:18, Melanie Plageman
<melanieplageman@gmail.com> wrote:

> But you are right, I don't see any non-error code path where a heap
> page would become empty (all line pointers set unused) and then not be
> set all-visible. Only vacuum sets line pointers unused and if all the
> line pointers are unused it will always set the page all-visible.
>
> I think, though, that if we error out in lazy_scan_prune() after
> returning from heap_page_prune_and_freeze() such that we don't set the
> empty page all-visible, we can end up with an empty page without
> PD_ALL_VISIBLE set. You can see how this might work by patching the VM
> set code in lazy_scan_prune() to skip empty pages.
>

Thank you for your explanation!  I completely forgot that PD_ALL_VIS
is a non-persistent change (hint bit). so its update can be trivially
lost.
The simplest real-life example is being killed just after returning
from heap_page_prune_and_freeze, yes.
PFA tap test covering lazy_scan_new_or_empty code path for
empty-but-not-all-visible page

-- 
Best regards,
Kirill Reshke

--000000000000cfdef206463dd532
Content-Type: application/octet-stream;
	name="v1-0001-Add-TAP-test-for-empty-page-vacuum.patch"
Content-Disposition: attachment;
	filename="v1-0001-Add-TAP-test-for-empty-page-vacuum.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mjbr3dok0>
X-Attachment-Id: f_mjbr3dok0

RnJvbSBhYzgzODk1M2RlOWM0YWIwY2I1ZjEzZDFlMWI4YWQwYTE4ZTczZTM5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFRo
dSwgMTggRGVjIDIwMjUgMTg6MDA6MjIgKzAwMDAKU3ViamVjdDogW1BBVENIIHYxXSBBZGQgVEFQ
IHRlc3QgZm9yIGVtcHR5IHBhZ2UgdmFjdXVtLgoKVkFDVVVNIGNhbiBiZSBydW4gZm9yIGVtcHR5
IHBhZ2VzIHdpdGggRElTQUJMRV9QQUdFX1NLSVBQSU5HIG9wdGlvbi4KSW4gdGhpcyBjYXNlLCBW
QUNVVU0gd2lsIHNldCB1cCBwYWdlLWxldmVsIHZpc2liaWxpdHkgYml0CihQRF9BTExfVklTSUJM
RSkgaWYgbm90IHByZXZpb3VzbHkgc2V0LgpUbyBlbmQgdXAgd2l0aCBlbXB0eSBwYWdlIHdoaWNo
IGlzIG1pc3NpbmcgdmlzaWJpbGl0eSBoaW50IGJpdCwgd2UgbmVlZAp0byBmb3JjZWZ1bHkgY2Fu
Y2VsIChraWxsIC05KSBiYWNrZW5kLCBleGVjdXRpbmcgcGFnZSBmcmVlemluZywganN1dAphZnRl
ciBpdCBkaWQgcGFnZSBwcnVuaW5nLiBVc2UgaW5qZWNpdG9uIHBvaW50IGZvciB0aGlzIHB1cnBv
c2UgYW5kCmFkZCBUQVAgdGVzdCB0byBjb3ZlciAicmVjb3ZlcnkiIGFmdGVyIGVycm9yIGNvZGUg
cGF0aC4KLS0tCiBzcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC92YWN1dW1sYXp5LmMgICAgICAgICAg
fCAgNiArKwogLi4uL3Rlc3RfbWlzYy90LzAxMF92YWN1dW1fZW1wdHlfcGFnZS5wbCAgICAgIHwg
NzUgKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCsp
CiBjcmVhdGUgbW9kZSAxMDA2NDQgc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTBfdmFj
dXVtX2VtcHR5X3BhZ2UucGwKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC92
YWN1dW1sYXp5LmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvaGVhcC92YWN1dW1sYXp5LmMKaW5kZXgg
MzA3NzhhMTU2MzkuLjliOGNiYjY3ZjExIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3Mv
aGVhcC92YWN1dW1sYXp5LmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2hlYXAvdmFjdXVtbGF6
eS5jCkBAIC0xNTMsNiArMTUzLDcgQEAKICNpbmNsdWRlICJzdG9yYWdlL2ZyZWVzcGFjZS5oIgog
I2luY2x1ZGUgInN0b3JhZ2UvbG1nci5oIgogI2luY2x1ZGUgInN0b3JhZ2UvcmVhZF9zdHJlYW0u
aCIKKyNpbmNsdWRlICJ1dGlscy9pbmplY3Rpb25fcG9pbnQuaCIKICNpbmNsdWRlICJ1dGlscy9s
c3lzY2FjaGUuaCIKICNpbmNsdWRlICJ1dGlscy9wZ19ydXNhZ2UuaCIKICNpbmNsdWRlICJ1dGls
cy90aW1lc3RhbXAuaCIKQEAgLTE4OTksNiArMTkwMCw4IEBAIGxhenlfc2Nhbl9uZXdfb3JfZW1w
dHkoTFZSZWxTdGF0ZSAqdmFjcmVsLCBCdWZmZXIgYnVmLCBCbG9ja051bWJlciBibGtubywKIAkJ
ICovCiAJCWlmICghUGFnZUlzQWxsVmlzaWJsZShwYWdlKSkKIAkJeworCQkJSU5KRUNUSU9OX1BP
SU5UKCJ2YWN1dW0tZW1wdHktcGFnZS1ub24tYWxsLXZpcyIsIE5VTEwpOworCiAJCQlTVEFSVF9D
UklUX1NFQ1RJT04oKTsKIAogCQkJLyogbWFyayBidWZmZXIgZGlydHkgYmVmb3JlIHdyaXRpbmcg
YSBXQUwgcmVjb3JkICovCkBAIC0yMDEyLDYgKzIwMTUsOSBAQCBsYXp5X3NjYW5fcHJ1bmUoTFZS
ZWxTdGF0ZSAqdmFjcmVsLAogCQkJCQkJCSAgICZ2YWNyZWwtPm9mZm51bSwKIAkJCQkJCQkgICAm
dmFjcmVsLT5OZXdSZWxmcm96ZW5YaWQsICZ2YWNyZWwtPk5ld1JlbG1pbk14aWQpOwogCisJCisJ
SU5KRUNUSU9OX1BPSU5UKCJ2YWN1dW0taGVhcC1wcnVuZS1hbmQtZnJlZXplLWFmdGVyIiwgTlVM
TCk7CisKIAlBc3NlcnQoTXVsdGlYYWN0SWRJc1ZhbGlkKHZhY3JlbC0+TmV3UmVsbWluTXhpZCkp
OwogCUFzc2VydChUcmFuc2FjdGlvbklkSXNWYWxpZCh2YWNyZWwtPk5ld1JlbGZyb3plblhpZCkp
OwogCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfbWlzYy90LzAxMF92YWN1dW1f
ZW1wdHlfcGFnZS5wbCBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDEwX3ZhY3V1bV9l
bXB0eV9wYWdlLnBsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5hZjVj
MzlkMjQzNQotLS0gL2Rldi9udWxsCisrKyBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3Qv
MDEwX3ZhY3V1bV9lbXB0eV9wYWdlLnBsCkBAIC0wLDAgKzEsNzUgQEAKKyMgQ29weXJpZ2h0IChj
KSAyMDI1LCBQb3N0Z3JlU1FMIEdsb2JhbCBEZXZlbG9wbWVudCBHcm91cAorCisjIENoZWNrIGhv
dyB0ZW1wb3JhcnkgZmlsZSByZW1vdmFscyBhbmQgc3RhdGVtZW50IHF1ZXJpZXMgYXJlIGFzc29j
aWF0ZWQKKyMgaW4gdGhlIHNlcnZlciBsb2dzIGZvciB2YXJpb3VzIHF1ZXJ5IHNlcXVlbmNlcyB3
aXRoIHRoZSBzaW1wbGUgYW5kCisjIGV4dGVuZGVkIHF1ZXJ5IHByb3RvY29scy4KKwordXNlIHN0
cmljdDsKK3VzZSB3YXJuaW5ncyBGQVRBTCA9PiAnYWxsJzsKK3VzZSBQb3N0Z3JlU1FMOjpUZXN0
OjpDbHVzdGVyOwordXNlIFBvc3RncmVTUUw6OlRlc3Q6OlV0aWxzOwordXNlIFRlc3Q6Ok1vcmU7
CisKK2lmICgkRU5We2VuYWJsZV9pbmplY3Rpb25fcG9pbnRzfSBuZSAneWVzJykKK3sKKwlwbGFu
IHNraXBfYWxsID0+ICdJbmplY3Rpb24gcG9pbnRzIG5vdCBzdXBwb3J0ZWQgYnkgdGhpcyBidWls
ZCc7Cit9CisKKyMgSW5pdGlhbGl6ZSBhIG5ldyBQb3N0Z3JlU1FMIHRlc3QgY2x1c3RlcgorbXkg
JG5vZGUgPSBQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyLT5uZXcoJ3ByaW1hcnknKTsKKyRub2Rl
LT5pbml0KCk7Ciskbm9kZS0+YXBwZW5kX2NvbmYoCisJJ3Bvc3RncmVzcWwuY29uZicsIHFxKAor
bG9nX21pbl9tZXNzYWdlcyA9ICdub3RpY2UnCispKTsKKyRub2RlLT5zdGFydDsKKworIyBDaGVj
ayBpZiB0aGUgZXh0ZW5zaW9uIGluamVjdGlvbl9wb2ludHMgaXMgYXZhaWxhYmxlLCBhcyBpdCBt
YXkgYmUKKyMgcG9zc2libGUgdGhhdCB0aGlzIHNjcmlwdCBpcyBydW4gd2l0aCBpbnN0YWxsY2hl
Y2ssIHdoZXJlIHRoZSBtb2R1bGUKKyMgd291bGQgbm90IGJlIGluc3RhbGxlZCBieSBkZWZhdWx0
LgoraWYgKCEkbm9kZS0+Y2hlY2tfZXh0ZW5zaW9uKCdpbmplY3Rpb25fcG9pbnRzJykpCit7CisJ
cGxhbiBza2lwX2FsbCA9PiAnRXh0ZW5zaW9uIGluamVjdGlvbl9wb2ludHMgbm90IGluc3RhbGxl
ZCc7Cit9CisKKyRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywgJ0NSRUFURSBFWFRFTlNJT04g
aW5qZWN0aW9uX3BvaW50czsnKTsKKworCisjIFNldHVwIHRhYmxlIGFuZCBwb3B1bGF0ZSB3aXRo
IGRhdGEKKyRub2RlLT5zYWZlX3BzcWwoCisJInBvc3RncmVzIiwgcXF7CitDUkVBVEUgVEFCTEUg
dmFjX2VtcHR5X3Rlc3QoYSBpbnQpOworQkVHSU47CitJTlNFUlQgSU5UTyB2YWNfZW1wdHlfdGVz
dCBERUZBVUxUIFZBTFVFUzsKK1JPTExCQUNLOworfSk7CisKKyMgRnJvbSB0aGlzIHBvaW50LCBh
dXRvdmFjdXVtIHdvcmtlciB3aWxsIHdhaXQgYXQgc3RhcnR1cC4KKyRub2RlLT5zYWZlX3BzcWwo
J3Bvc3RncmVzJywKKwkiU0VMRUNUIGluamVjdGlvbl9wb2ludHNfYXR0YWNoKCd2YWN1dW0taGVh
cC1wcnVuZS1hbmQtZnJlZXplLWFmdGVyJywgJ2Vycm9yJyk7Iik7Ciskbm9kZS0+c2FmZV9wc3Fs
KCdwb3N0Z3JlcycsCisJIlNFTEVDVCBpbmplY3Rpb25fcG9pbnRzX2F0dGFjaCgndmFjdXVtLWVt
cHR5LXBhZ2Utbm9uLWFsbC12aXMnLCAnbm90aWNlJyk7Iik7CisKKyRub2RlLT5wc3FsKCdwb3N0
Z3JlcycsICJWQUNVVU0gKEZSRUVaRSkgdmFjX2VtcHR5X3Rlc3Q7Iiwgb25fZXJyb3Jfc3RvcCA9
PiAxKTsKKworbXkgJG9mZnNldCA9IC1zICRub2RlLT5sb2dmaWxlOworCisjIFJ1biB2YWN1dW0s
IGZvcmNlIGl0IG9uIGVtcHR5IHBhZ2UuIAorJG5vZGUtPnNhZmVfcHNxbCgKKwkicG9zdGdyZXMi
LCBxcXsKK1ZBQ1VVTSAoRElTQUJMRV9QQUdFX1NLSVBQSU5HKSB2YWNfZW1wdHlfdGVzdDsKK30p
OworCitvayggJG5vZGUtPmxvZ19jb250YWlucygKKwkJcXIvTk9USUNFOiAgbm90aWNlIHRyaWdn
ZXJlZCBmb3IgaW5qZWN0aW9uIHBvaW50IHZhY3V1bS1lbXB0eS1wYWdlLW5vbi1hbGwtdmlzLywK
KwkJJG9mZnNldCksCisJInZhY3V1bSBzZXRzIGFsbC12aXNpYmxlIHBhZ2UgYml0IGZvciBlbXB0
eSBwYWdlIik7CisKKworJG5vZGUtPnNhZmVfcHNxbCgncG9zdGdyZXMnLAorCSJTRUxFQ1QgaW5q
ZWN0aW9uX3BvaW50c19kZXRhY2goJ3ZhY3V1bS1oZWFwLXBydW5lLWFuZC1mcmVlemUtYWZ0ZXIn
KTsiKTsKKyRub2RlLT5zYWZlX3BzcWwoJ3Bvc3RncmVzJywKKwkiU0VMRUNUIGluamVjdGlvbl9w
b2ludHNfZGV0YWNoKCd2YWN1dW0tZW1wdHktcGFnZS1ub24tYWxsLXZpcycpOyIpOworCiskbm9k
ZS0+c3RvcCgnZmFzdCcpOworZG9uZV90ZXN0aW5nKCk7Ci0tIAoyLjQzLjAKCg==
--000000000000cfdef206463dd532--