MIME-Version: 1.0
References: 
 <CACJufxEk34DnJFG72CRsPPT4tsJL9arobX0tNPsn7yH28J=zQg@mail.gmail.com>
 <1118236.1763485279@sss.pgh.pa.us>
 <CACJufxEDN24yBCkFw9sgv2Ocoq=TAtydcJ1ZLR3PEb_NJnTfqA@mail.gmail.com>
 <CACJufxF_9FXULmC8fqCNE9H734_RmJ_1jboBpAmL8r-2wO=HOg@mail.gmail.com>
 <5406c2b1-57c8-448b-97c7-8af295ba3869@dunslane.net>
In-Reply-To: <5406c2b1-57c8-448b-97c7-8af295ba3869@dunslane.net>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Fri, 13 Mar 2026 18:16:34 +0500
Message-ID: 
 <CALdSSPgSLA2sZ7xY7gc-RFR4wbAamO3ORe32SyRsadZTfX+OVg@mail.gmail.com>
Subject: Re: IS JSON predicate support for domain base type as
 JSON/JSONB/BYTEA/TEXT
To: Andrew Dunstan <andrew@dunslane.net>
Cc: jian he <jian.universality@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPgSLA2sZ7xY7gc-RFR4wbAamO3ORe32SyRsadZTfX%2BOVg%40mail.gmail.com>
Precedence: bulk

On Fri, 13 Mar 2026 at 17:30, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2026-03-12 Th 11:55 PM, jian he wrote:
> > Hi.
> >
> > The regression test was very verbose; I removed some of it.
> > Also polished function ExecEvalJsonIsPredicate a little bit.
>
>
>
> Here's a v4. I changed resultBaseType to exprBaseType - I think it's
> clearer. I also trimmed the tests a bit more, and dropped the new
> objects after testing them. The  error message now shows the domain name
> rather than the underlying base type. I think that's more useful.
>


Hi!
V4 looks good. The only thing that I cannot explain is removing the
`exprtype` variable inside ExecEvalJsonIsPredicate. We can just change
its declaration to

exprtype =  pred->exprBaseType if i'm not mistaken?

Anyway, LGTM


> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com


-- 
Best regards,
Kirill Reshke