MIME-Version: 1.0
References: <Zo6OvsBLUbYm6nQM@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zo9j69GhexDpeV4k@paquier.xyz> <Zo93T63yVkDcKw3P@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZrBi9vNj5Ntyu62U@ip-10-97-1-34.eu-west-3.compute.internal>
 <Ztk4JIgWKk/8/dmd@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zt/ZeIeWq0UVSAuy@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZyiTiqWPbRMseQjb@ip-10-97-1-34.eu-west-3.compute.internal>
 <CA+TgmoZtRxvAuMyO4bQjj5t47XWvQsowPAedkOkrCP61B7mQFg@mail.gmail.com>
 <Zym1xlMhuzPdekMt@ip-10-97-1-34.eu-west-3.compute.internal>
 <CALdSSPhQyvK_wsvV+HiQcC6f57Zg2WO60wxv=CXbcoZ1p5HHEQ@mail.gmail.com> <Z0nbomp2e/L30WDA@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <Z0nbomp2e/L30WDA@ip-10-97-1-34.eu-west-3.compute.internal>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Fri, 29 Nov 2024 20:52:13 +0500
Message-ID: <CALdSSPhFaLEWXG9Mn8-tZoS68rE52647a2oZ6jrUNSBtwadD0A@mail.gmail.com>
Subject: Re: relfilenode statistics
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael@paquier.xyz>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALdSSPhFaLEWXG9Mn8-tZoS68rE52647a2oZ6jrUNSBtwadD0A%40mail.gmail.com>
Precedence: bulk

On Fri, 29 Nov 2024 at 20:20, Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
> On Fri, Nov 29, 2024 at 11:23:12AM +0500, Kirill Reshke wrote:
> > If we don=E2=80=99t have the relation OID when writing buffers out, can=
 we
> > just store oid to buffertag mapping somewhere and use it?
>
> Do you mean add the relation OID into the BufferTag? While that could pro=
bably
> be done from a technical point of view (with probably non negligible amou=
nt
> of refactoring), I can see those cons:

Not exactly, what i had in mind was a separate hashmap into shared
memory, mapping buffertag<>oid.

> 2. Probably lot of refactoring
> 3. This new member would be there "only" for stats and reporting purpose =
as
> it is not needed at all for buffer related operations

To this design, your points 2&3 apply.


--=20
Best regards,
Kirill Reshke