MIME-Version: 1.0
References: 
 <CAAKRu_ZMw6Npd_qm2KM+FwQ3cMOMx1Dh3VMhp8-V7SOLxdK9-g@mail.gmail.com>
 <CAAKRu_YXP1Us41fkZJeBK5SSj5whNC0C9fZNT6Brdtm+F0agpg@mail.gmail.com>
 <CAAKRu_bAR5uCfjuc06vc_xrZjNCJLs493NgHjTOUDso9qGdE0w@mail.gmail.com>
 <CAAKRu_ac4vUdU-U3ax8j=N8y2OM9-pbFZhafLVfzDOM8MtzvvA@mail.gmail.com>
 <BD5C3345-42F2-4870-89B2-FD8875301714@yandex-team.ru>
 <CAAKRu_a-aVGxNEdkJt+96HGryQXuQNuXe+PhR0KcnUhXSOPBJw@mail.gmail.com>
 <87DD95AA-274F-4F4F-BAD9-7738E5B1F905@yandex-team.ru>
 <CAAKRu_ZH8kL0Zm0j7m7DC9fzk7ru7yf9rm2pEQRvx1iXX25aPQ@mail.gmail.com>
 <CAAKRu_bGCgUuhmy1Mzkw3yCmbGcjNQAjV=OmjuW6hz90PuXKWA@mail.gmail.com>
In-Reply-To: 
 <CAAKRu_bGCgUuhmy1Mzkw3yCmbGcjNQAjV=OmjuW6hz90PuXKWA@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Wed, 27 Aug 2025 17:55:27 +0500
Message-ID: 
 <CALdSSPhvV8mf36+8SVKviJA3SkzzP1iJ09T23Pk8EYNZHEt3xA@mail.gmail.com>
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM
 on-access)
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000387956063d584e37"
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPhvV8mf36%2B8SVKviJA3SkzzP1iJ09T23Pk8EYNZHEt3xA%40mail.gmail.com>
Precedence: bulk

--000000000000387956063d584e37
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2 Aug 2025 at 02:36, Melanie Plageman <melanieplageman@gmail.com> w=
rote:
>
> On Thu, Jul 31, 2025 at 6:58=E2=80=AFPM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
> >
> > The patch "Set-pd_prune_xid-on-insert.txt" can be applied as the last
> > patch in the set. It sets pd_prune_xid on insert (so pages filled by
> > COPY or insert can also be set all-visible in the VM before they are
> > vacuumed). I gave it a .txt extension because it currently fails
> > 035_standby_logical_decoding due to a recovery conflict. I need to
> > investigate more to see if this is a bug in my patch set or elsewhere
> > in Postgres.
>
> I figured out that if we set the VM on-access, we need to enable
> hot_standby_feedback in more places in 035_standby_logical_decoding.pl
> to avoid recovery conflicts. I've done that in the attached updated
> version 6. There are a few other issues in
> 035_standby_logical_decoding.pl that I reported here [1]. With these
> changes, setting pd_prune_xid on insert passes tests. Whether or not
> we want to do it (and what the heuristic should be for deciding when
> to do it) is another question.
>
> - Melanie
>
> [1] https://www.postgresql.org/message-id/flat/CAAKRu_YO2mEm%3DZWZKPjTMU%=
3DgW5Y83_KMi_1cr51JwavH0ctd7w%40mail.gmail.com

v6-0015:
I chose to verify whether this single modification would be beneficial
on the HEAD.

Benchmark I did:

```

\timing
CREATE TABLE zz(i int);
alter table zz set (autovacuum_enabled =3D false);
TRUNCATE zz;
copy zz from program 'yes 2 | head -n 180000000';
copy zz from program 'yes 2 | head -n 180000000';

delete from zz where (REPLACE(REPLACE(ctid::text, '(', '{'), ')',
'}')::int[])[2] =3D 7 ;

VACUUM FREEZE zz;
```

And I checked perf top footprint for last statement (vacuum).  My
detailed results are attached. It is a HEAD vs HEAD+v6-0015 benchmark.

TLDR: function inlining is indeed beneficial, TransactionIdPrecedes
function disappears from perf top footprint, though query runtime is
not changed much. So, while not resulting in query speedup, this can
save CPU.
Maybe we can derive an artificial benchmark, which will show query
speed up, but for now I dont have one.

--=20
Best regards,
Kirill Reshke

--000000000000387956063d584e37
Content-Type: text/plain; charset="US-ASCII"; name="attach.txt"
Content-Disposition: attachment; filename="attach.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_metz43sv0>
X-Attachment-Id: f_metz43sv0

d2l0aG91dDoKCk92ZXJoZWFkICBTaGFyZWQgT2IgIFN5bWJvbAogICA3LjEzJSAgcG9zdGdyZXMg
ICBbLl0gaGVhcF9wYWdlX3BydW5lX2FuZF9mcmVlemUKICAgNi40NiUgIHBvc3RncmVzICAgWy5d
IGhlYXBfcHJ1bmVfcmVjb3JkX3VuY2hhbmdlZF9scF9ub3JtYWwKICAgNS43OCUgIFtrZXJuZWxd
ICAgW2tdIF9yYXdfc3Bpbl91bmxvY2tfaXJxcmVzdG9yZQogICA0LjUxJSAgcG9zdGdyZXMgICBb
Ll0gaGVhcF9wcmVwYXJlX2ZyZWV6ZV90dXBsZQogICA0LjM4JSAgcG9zdGdyZXMgICBbLl0gSGVh
cFR1cGxlU2F0aXNmaWVzVmFjdXVtSG9yaXpvbgogICA0LjA0JSAgcG9zdGdyZXMgICBbLl0gaGVh
cF9wYWdlX2lzX2FsbF92aXNpYmxlCiAgIDMuNzklICBwb3N0Z3JlcyAgIFsuXSBoYXNoX3NlYXJj
aF93aXRoX2hhc2hfdmFsdWUKICAgMy41OCUgIFtrZXJuZWxdICAgW2tdIGNvcHlfcGFnZV9mcm9t
X2l0ZXJfYXRvbWljCiAgIDMuNTElICBba2VybmVsXSAgIFtrXSBtYXJrX2J1ZmZlcl9kaXJ0eQog
ICAzLjI4JSAgcG9zdGdyZXMgICBbLl0gcGdfY2hlY2tzdW1fcGFnZQogICAyLjA4JSAgcG9zdGdy
ZXMgICBbLl0gcGdfY29tcF9jcmMzMmNfYXZ4NTEyCiAgIDEuOTYlICBwb3N0Z3JlcyAgIFsuXSBo
ZWFwX3ByZV9mcmVlemVfY2hlY2tzCiAgIDEuOTAlICBwb3N0Z3JlcyAgIFsuXSBjb21wYWN0aWZ5
X3R1cGxlcwogICAxLjg3JSAgcG9zdGdyZXMgICBbLl0gUGFnZVJlcGFpckZyYWdtZW50YXRpb24K
ICAgMS44MiUgIHBvc3RncmVzICAgWy5dIFBhZ2VTZXRDaGVja3N1bUNvcHkKICAgMS43NSUgIGxp
YmMuc28uNiAgWy5dIF9fbWVtbW92ZV9ldmV4X3VuYWxpZ25lZF9lcm1zCiAgIDEuNzIlICBwb3N0
Z3JlcyAgIFsuXSBoZWFwX2xvZ19mcmVlemVfY21wCiAgIDEuNzIlICBwb3N0Z3JlcyAgIFsuXSBs
b2dfaGVhcF9wcnVuZV9hbmRfZnJlZXplCiAgIDEuNDMlICBwb3N0Z3JlcyAgIFsuXSBMV0xvY2tS
ZWxlYXNlSW50ZXJuYWwKICAgMS4zNiUgIHBvc3RncmVzICAgWy5dIGhlYXBfZnJlZXplX3ByZXBh
cmVkX3R1cGxlcwogICAxLjMwJSAgcG9zdGdyZXMgICBbLl0gQWR2YW5jZVhMSW5zZXJ0QnVmZmVy
CiAgIDEuMzAlICBwb3N0Z3JlcyAgIFsuXSBUcmFuc2FjdGlvbklkUHJlY2VkZXMKICAgMC45NiUg
IHBvc3RncmVzICAgWy5dIEhlYXBUdXBsZVNhdGlzZmllc1ZhY3V1bQogICAwLjkxJSAgW2tlcm5l
bF0gICBba10gZmlsZW1hcF9nZXRfZW50cnkKICAgMC44NyUgIFtrZXJuZWxdICAgW2tdIGV4dDRf
ZGFfd3JpdGVfZW5kCiAgIDAuODQlICBwb3N0Z3JlcyAgIFsuXSBHZXRQcml2YXRlUmVmQ291bnRF
bnRyeQogICAwLjgzJSAgW2tlcm5lbF0gICBba10gZmF1bHRfaW5fcmVhZGFibGUKICAgMC44MSUg
IHBvc3RncmVzICAgWy5dIGhlYXBfdHVwbGVfbmVlZHNfZXZlbnR1YWxfZnJlZXplCiAgIDAuODAl
ICBwb3N0Z3JlcyAgIFsuXSBUcmFuc2FjdGlvbklkRGlkQ29tbWl0CiAgIDAuNzElICBba2VybmVs
XSAgIFtrXSBfX2Jsb2NrX2NvbW1pdF93cml0ZQogICAwLjY5JSAgcG9zdGdyZXMgICBbLl0gTFdM
b2NrQXR0ZW1wdExvY2sKICAgMC42NCUgIHBvc3RncmVzICAgWy5dIFRyYW5zYWN0aW9uTG9nRmV0
Y2gKICAgMC42MiUgIHBvc3RncmVzICAgWy5dIGhlYXBfcGFnZV9wcnVuZV9leGVjdXRlCiAgIDAu
NjIlICBba2VybmVsXSAgIFtrXSByZWZpbGxfc3RvY2sKICAgMC41NyUgIHBvc3RncmVzICAgWy5d
IExvY2tCdWZIZHIKICAgMC41MyUgIFtrZXJuZWxdICAgW2tdIGxydXZlY19zdGF0X21vZF9mb2xp
bwogICAwLjUyJSAgW2tlcm5lbF0gICBba10gcmVmaWxsX29ial9zdG9jawogICAwLjUxJSAgcG9z
dGdyZXMgICBbLl0gVHJhbnNhY3Rpb25JZEZvbGxvd3MKCgoKcmVzaGtlPSMgXHRpbWluZwpUaW1p
bmcgaXMgb24uCnJlc2hrZT0jIGNvcHkgenogZnJvbSBwcm9ncmFtICd5ZXMgMiB8IGhlYWQgLW4g
MTgwMDAwMDAwJzsKQ09QWSAxODAwMDAwMDAKVGltZTogNTg3OTUuODMyIG1zICgwMDo1OC43OTYp
CnJlc2hrZT0jIGNvcHkgenogZnJvbSBwcm9ncmFtICd5ZXMgMiB8IGhlYWQgLW4gMTgwMDAwMDAw
JzsKCmRlbGV0ZSBmcm9tIHp6IHdoZXJlIChSRVBMQUNFKFJFUExBQ0UoY3RpZDo6dGV4dCwgJygn
LCAneycpLCAnKScsICd9Jyk6OmludFtdKVsyXSA9IDcgOwoKVkFDVVVNIEZSRUVaRSB6ejsKQ09Q
WSAxODAwMDAwMDAKVGltZTogNjIyOTcuMzU3IG1zICgwMTowMi4yOTcpCkRFTEVURSAxNTkyOTIx
ClRpbWU6IDM3MzQ5NS4xNTggbXMgKDA2OjEzLjQ5NSkKVkFDVVVNClRpbWU6IDE5OTE1MC41NTQg
bXMgKDAzOjE5LjE1MSkKCgoKd2l0aDoKCjcuMDclICBwb3N0Z3JlcyAgIFsuXSBoZWFwX3BydW5l
X3JlY29yZF91bmNoYW5nZWRfbHBfbm9ybWFsCiAgIDYuNjclICBwb3N0Z3JlcyAgIFsuXSBoZWFw
X3BhZ2VfcHJ1bmVfYW5kX2ZyZWV6ZQogICA1Ljg3JSAgW2tlcm5lbF0gICBba10gX3Jhd19zcGlu
X3VubG9ja19pcnFyZXN0b3JlCiAgIDQuNDglICBwb3N0Z3JlcyAgIFsuXSBIZWFwVHVwbGVTYXRp
c2ZpZXNWYWN1dW1Ib3Jpem9uCiAgIDQuMDUlICBwb3N0Z3JlcyAgIFsuXSBoZWFwX3ByZXBhcmVf
ZnJlZXplX3R1cGxlCiAgIDQuMDAlICBba2VybmVsXSAgIFtrXSBtYXJrX2J1ZmZlcl9kaXJ0eQog
ICAzLjkyJSAgW2tlcm5lbF0gICBba10gY29weV9wYWdlX2Zyb21faXRlcl9hdG9taWMKICAgMy41
OSUgIHBvc3RncmVzICAgWy5dIGhlYXBfcGFnZV9pc19hbGxfdmlzaWJsZQogICAzLjU4JSAgcG9z
dGdyZXMgICBbLl0gcGdfY2hlY2tzdW1fcGFnZQogICAzLjQyJSAgcG9zdGdyZXMgICBbLl0gaGFz
aF9zZWFyY2hfd2l0aF9oYXNoX3ZhbHVlCiAgIDIuMjYlICBwb3N0Z3JlcyAgIFsuXSBwZ19jb21w
X2NyYzMyY19hdng1MTIKICAgMi4xMiUgIHBvc3RncmVzICAgWy5dIFBhZ2VSZXBhaXJGcmFnbWVu
dGF0aW9uCiAgIDIuMDclICBwb3N0Z3JlcyAgIFsuXSBQYWdlU2V0Q2hlY2tzdW1Db3B5CiAgIDEu
ODklICBwb3N0Z3JlcyAgIFsuXSBoZWFwX3ByZV9mcmVlemVfY2hlY2tzCiAgIDEuODMlICBwb3N0
Z3JlcyAgIFsuXSBoZWFwX2xvZ19mcmVlemVfY21wCiAgIDEuNjUlICBba2VybmVsXSAgIFtrXSBm
aWxlbWFwX2dldF9lbnRyeQogICAxLjY0JSAgcG9zdGdyZXMgICBbLl0gY29tcGFjdGlmeV90dXBs
ZXMKICAgMS41MyUgIHBvc3RncmVzICAgWy5dIExXTG9ja1JlbGVhc2VJbnRlcm5hbAogICAxLjUw
JSAgcG9zdGdyZXMgICBbLl0gbG9nX2hlYXBfcHJ1bmVfYW5kX2ZyZWV6ZQogICAxLjQ5JSAgcG9z
dGdyZXMgICBbLl0gaGVhcF9mcmVlemVfcHJlcGFyZWRfdHVwbGVzCiAgIDEuNDAlICBsaWJjLnNv
LjYgIFsuXSBfX21lbW1vdmVfZXZleF91bmFsaWduZWRfZXJtcwogICAxLjM4JSAgcG9zdGdyZXMg
ICBbLl0gQWR2YW5jZVhMSW5zZXJ0QnVmZmVyCiAgIDEuMDQlICBwb3N0Z3JlcyAgIFsuXSBIZWFw
VHVwbGVTYXRpc2ZpZXNWYWN1dW0KICAgMS4wMyUgIFtrZXJuZWxdICAgW2tdIF9fYmxvY2tfY29t
bWl0X3dyaXRlCiAgIDAuOTYlICBwb3N0Z3JlcyAgIFsuXSBMV0xvY2tBdHRlbXB0TG9jawogICAw
LjkyJSAgW2tlcm5lbF0gICBba10gZXh0NF9kYV93cml0ZV9lbmQKICAgMC45MCUgIHBvc3RncmVz
ICAgWy5dIGhlYXBfdHVwbGVfbmVlZHNfZXZlbnR1YWxfZnJlZXplCiAgIDAuODAlICBwb3N0Z3Jl
cyAgIFsuXSBHZXRQcml2YXRlUmVmQ291bnRFbnRyeQogICAwLjc4JSAgW2tlcm5lbF0gICBba10g
ZmF1bHRfaW5fcmVhZGFibGUKICAgMC43NSUgIHBvc3RncmVzICAgWy5dIFRyYW5zYWN0aW9uSWRE
aWRDb21taXQKICAgMC43MiUgIFtrZXJuZWxdICAgW2tdIGxydXZlY19zdGF0X21vZF9mb2xpbwog
ICAwLjY5JSAgW2tlcm5lbF0gICBba10gcmVmaWxsX3N0b2NrCiAgIDAuNjklICBwb3N0Z3JlcyAg
IFsuXSBUcmFuc2FjdGlvbkxvZ0ZldGNoCiAgIDAuNjQlICBba2VybmVsXSAgIFtrXSByZWZpbGxf
b2JqX3N0b2NrCiAgIDAuNjElICBwb3N0Z3JlcyAgIFsuXSBYTG9nSW5zZXJ0CiAgIDAuNTYlICBw
b3N0Z3JlcyAgIFsuXSBoZWFwX3BhZ2VfcHJ1bmVfZXhlY3V0ZQogICAwLjU2JSAgW2tlcm5lbF0g
ICBba10gX3Jhd19zcGluX2xvY2sKICAgMC41MCUgIHBvc3RncmVzICAgWy5dIHVpbnQzMl9oYXNo
CgoKcmVzaGtlPSMgY29weSB6eiBmcm9tIHByb2dyYW0gJ3llcyAyIHwgaGVhZCAtbiAxODAwMDAw
MDAnOwpjb3B5IHp6IGZyb20gcHJvZ3JhbSAneWVzIDIgfCBoZWFkIC1uIDE4MDAwMDAwMCc7Cgpk
ZWxldGUgZnJvbSB6eiB3aGVyZSAoUkVQTEFDRShSRVBMQUNFKGN0aWQ6OnRleHQsICcoJywgJ3sn
KSwgJyknLCAnfScpOjppbnRbXSlbMl0gPSA3IDsKQ09QWSAxODAwMDAwMDAKVGltZTogNTc0ODku
NjY1IG1zICgwMDo1Ny40OTApCkNPUFkgMTgwMDAwMDAwClRpbWU6IDYwNzExLjAyNCBtcyAoMDE6
MDAuNzExKQpERUxFVEUgMTU5MjkyMQpUaW1lOiAzNzU0ODEuODU4IG1zICgwNjoxNS40ODIpCnJl
c2hrZT0jClZBQ1VVTSBGUkVFWkUgeno7ClZBQ1VVTQpUaW1lOiAxOTY0NDIuMzQwIG1zICgwMzox
Ni40NDIpCg==
--000000000000387956063d584e37--