public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kirill Reshke <[email protected]>
To: Shinya Kato <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Use IsA() macro instead of nodeTag comparison
Date: Thu, 8 Jan 2026 18:10:44 +0500
Message-ID: <CALdSSPi5fWXfby+B+rpT--zuazGhmBd3Bg1L3VGDCpabeRYGFw@mail.gmail.com> (raw)
In-Reply-To: <CAOzEurS=PzRzGba3mpNXgEhbnQFA0dxXaU0ujCJ0aa9yMSH6Pw@mail.gmail.com>
References: <CAOzEurS=PzRzGba3mpNXgEhbnQFA0dxXaU0ujCJ0aa9yMSH6Pw@mail.gmail.com>

On Thu, 8 Jan 2026 at 17:31, Shinya Kato <[email protected]> wrote:
>
> Hi hackers,

Hi

> In copy.c, nodeTag was being compared directly, so I replaced it with
> the IsA() predicate macro for consistency.

Oops. Looks like oversight in 6c8f670. This is indeed case where we
should use IsA()

> I verified that there are no other direct comparisons left by running
> the following command:
> $ git grep "nodeTag(.*) =="

Yep, look like this is the only case in copy.c

> --
> Best regards,
> Shinya Kato
> NTT OSS Center



-- 
Best regards,
Kirill Reshke

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Use IsA() macro instead of nodeTag comparison
  In-Reply-To: <CALdSSPi5fWXfby+B+rpT--zuazGhmBd3Bg1L3VGDCpabeRYGFw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox