MIME-Version: 1.0
References: 
 <CALdSSPjXtzGM7Uk4fWRwRMXcCczge5uNirPQcYCHKPAWPkp9iQ@mail.gmail.com>
 <31d04a1b-c0cb-4e6f-a344-0db048a3b673@gmail.com>
 <DHMZH5ILXV80.36CLMWXU18J3@gmail.com>
 <414c3430-77a9-438e-9dc0-c66033f6be63@postgrespro.ru>
 <DHURZGPYE4B4.2XG5GT4TQ72U4@gmail.com>
 <CAPpHfdvQSmRAHu1BRTVcvgons_Smt0QW+mLP4np=QxG==WyFAg@mail.gmail.com>
 <DHYV404JC894.P813UU2Y36L1@gmail.com>
 <CAPpHfds2NsGvpi4fK-xBDk9S=ZY8FEsG-a3z7m_cRSJhn5GKvQ@mail.gmail.com>
 <271ebb35-8d8f-41c3-9d95-5c1e5b416216@gmail.com>
 <CAPpHfdt66RjWZnUakTZKk6eQ=xVrscfp9HAg8xXnxjnsgHuF-g@mail.gmail.com>
 <CALdSSPi9GE8jnLCA4aUP2F5_ax6W9Ccfh_ja0iY6wkX2uUyzDw@mail.gmail.com>
 <CAPpHfdua=Epad8j4z+xH_85RYVZ+FPuK=nPKBgh7Ky+PM4umag@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdua=Epad8j4z+xH_85RYVZ+FPuK=nPKBgh7Ky+PM4umag@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Wed, 22 Apr 2026 16:26:43 +0500
Message-ID: 
 <CALdSSPiDAv4NrQfR79cX7G1OYxhnRftZK1Nn_2NdT4r0gZc=mw@mail.gmail.com>
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 Dmitry Koval <d.koval@postgrespro.ru>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPiDAv4NrQfR79cX7G1OYxhnRftZK1Nn_2NdT4r0gZc%3Dmw%40mail.gmail.com>
Precedence: bulk

On Wed, 22 Apr 2026 at 16:24, Alexander Korotkov <aekorotkov@gmail.com> wro=
te:
>
> On Wed, Apr 22, 2026 at 1:48=E2=80=AFPM Kirill Reshke <reshkekirill@gmail=
.com> wrote:
> > Some minor comments:
> >
> > > +-- Sanity check: the extension can't be dropped while dependencies e=
xist.
> > >+DROP EXTENSION test_ext3;
> >
> > This exercises something that already works on HEAD (note this is DROP
> > before first MERGE partition call ). Do we really need this?
>
> I've removed this.
>
> > > +-- An index created directly on a partition has no parent in the par=
titioned
> > > +-- index tree; merge must ignore such indexes (they disappear with t=
he old
> > > +-- partition).
> > > +CREATE INDEX part_extdep_3_extra_idx ON part_extdep_3(x);
> > > +ALTER TABLE part_extdep MERGE PARTITIONS (part_extdep_merged, part_e=
xtdep_3)
> > > +    INTO part_extdep_merged2;
> > > +SELECT relname FROM pg_class
> > > +WHERE relname LIKE 'part_extdep_merged2%idx' ORDER BY relname;
> >
> > Looks like this test is also redundant? This does not test new DEPENDS =
ON logic.
>
> I've added the dependency on this index to check index disappears with
> its dependency.  I think this would make this test more relevant.
>
> Kirill, Matheus, are you ok with these change?
>
> ------
> Regards,
> Alexander Korotkov
> Supabase

v7 WFM

--=20
Best regards,
Kirill Reshke