MIME-Version: 1.0
References: <CALdSSPgZWX_D8+Fx4YQqRN5eW5iSx_rJdqQhCfdWTvqKXVfJ4w@mail.gmail.com>
 <CALdSSPgPs=gKWkKN0=4yBd49FBY=ijxBz4YGV64vfVMK7YQhpw@mail.gmail.com>
 <CALdSSPiaQptrccvRoHhP3=YqN9-K8duXfLHHm3G=+7FVL8A-Xw@mail.gmail.com>
 <CALdSSPh-QtT8NrhtKsNWwFVF3D4KX6Wy3qs-FPc16c6VAECEyg@mail.gmail.com>
 <CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com> <449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru>
In-Reply-To: <449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Fri, 23 Jan 2026 16:03:50 +0500
Message-ID: <CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
Subject: Re: Fix gistkillitems & add regression test to microvacuum
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CALdSSPiGnqgvpfQDCydBf-%3D0hzyUs6Y0o0xNvd53BbcMWTVO%3Dw%40mail.gmail.com>
Precedence: bulk

On Tue, 20 Jan 2026 at 15:30, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>
>
>
> > On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill@gmail.com> wrote:
> >
> > PFA v2 which leaves the test in-place.
> >
> > Also commit message improvements.
>
> Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
> I don't think we should backpatch this, the bug is harmless, but for master the patch LGTM.

Thank you

> It would be good to assign so->curBlkno and so->curBlkno together. But gistScanPage() is the only place with access to the block number.

Sorry, didnt get this take.

> +# Test gist, but with fewer rows - that killitems used to be buggy.
>
> Probably, in this comment we can explicitly say that killitems was buggy, but now is fixed.
>

Hmm, what would be a good wording here?


-- 
Best regards,
Kirill Reshke