MIME-Version: 1.0
References: 
 <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
In-Reply-To: 
 <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Mon, 13 Apr 2026 10:00:03 +0500
Message-ID: 
 <CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Paul A Jungwirth <pj@illuminatedcomputing.com>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPiRHCyC0fYy_E%3DgO%2Bc7sbwU%3D7%3DFz2CF-4aEa3mAe7yYAg%40mail.gmail.com>
Precedence: bulk

On Mon, 13 Apr 2026 at 06:45, jian he <jian.universality@gmail.com> wrote:
>
> Hi.
>
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=8e72d914c52876525a90b28444453de8085c866f
> DELETE/UPDATE FOR PORTION OF with rule system is not working, and
> there are no RULE related regession tests.

Thanks! +cc Paul & Peter as authors of [0]

> in gram.y, RuleStmt, RuleActionList, RuleActionStmt
> RuleActionStmt:
>             SelectStmt
>             | InsertStmt
>             | UpdateStmt
>             | DeleteStmt
>             | NotifyStmt
>         ;
>
> So far, I found 2 errors, and one crash.
> There might be more bugs, I didn't try all the cases.
>
> drop table if exists fpo_rule;
> create table fpo_rule (f1 bigint, f2 int4range);
> INSERT INTO fpo_rule values (1, '[1, 10]');
> CREATE RULE rule3 AS ON INSERT TO fpo_rule DO INSTEAD UPDATE fpo_rule
> FOR PORTION OF f2 FROM 1 to 4 SET F1 = 2;
>
> INSERT INTO fpo_rule values (2, '[2, 12]');
> ERROR:  range types do not match
> \errverbose
> ERROR:  XX000: range types do not match
> LOCATION:  range_minus_multi, rangetypes.c:1260
>
> CREATE RULE rule4 AS ON DELETE TO fpo_rule DO INSTEAD UPDATE fpo_rule
> FOR PORTION OF f2 FROM 1 to 4 SET F1 = 2;
> DELETE FROM fpo_rule;
> ERROR:  no relation entry for relid 3
> \errverbose
> ERROR:  XX000: no relation entry for relid 3
> LOCATION:  find_base_rel, relnode.c:556
>
> DROP RULE rule4 ON fpo_rule;
> CREATE RULE rule5 AS ON UPDATE TO fpo_rule DO INSTEAD DELETE FROM
> fpo_rule FOR PORTION OF f2 FROM 1 to 4;
> UPDATE fpo_rule FOR PORTION OF f2 FROM 1 to 4 SET F1 = 2; -- server crash
>
> As of now, we should try to ban CREATE ROLE with UPDATE/DELETE FOR PORTION OF.

+1 for banning


[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=8e72d914c52876525a90b28444453de8085c866f

-- 
Best regards,
Kirill Reshke