Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u2RhD-000gWM-EF
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Apr 2025 09:26:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u2RhB-001cBi-Aw
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Apr 2025 09:26:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <reshkekirill@gmail.com>)
	id 1u2RhB-001cBY-1D
	for pgsql-hackers@lists.postgresql.org; Wed, 09 Apr 2025 09:26:09 +0000
Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <reshkekirill@gmail.com>)
	id 1u2Rh9-004IxI-0U
	for pgsql-hackers@postgresql.org;
	Wed, 09 Apr 2025 09:26:08 +0000
Received: by mail-lj1-x22e.google.com with SMTP id
 38308e7fff4ca-30eef9ce7feso65329381fa.0
        for <pgsql-hackers@postgresql.org>;
 Wed, 09 Apr 2025 02:26:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1744190766; x=1744795566;
 darn=postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=5VzM13MFagfpjUomTmodBbf3EN98BL82wl0I2GNQBRM=;
        b=fj3W+GHPBTg+wMI2P8oqmP9fyJE+yctlEvL2/hRf+UuMMynWLuq8W9Le+4flAARbw/
         G86EQhDRoTj0nrC+d791cVPpTcovE7FvW78sdfjVtvH5H+6eTZUEung5iw6WwfPK4ikK
         IKZcvazFpU3TO6SV+aVJRx2vnsAfLr/7wdzuauTc9fPO99uLGpER62S/S/dRmjWAjTET
         rdfkZOAn+OGrZh9f7RcX58urnm1PTvIIygaAKCRQrQQqkVUrbkoLTxFunKcnpfxRe5fV
         5YXf/CzDudBtvzOofkFP8KVjrKo+VRe1cQFkrt15RncnW837OmGFqwW8K5+GqVHvPmg0
         MkGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1744190766; x=1744795566;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=5VzM13MFagfpjUomTmodBbf3EN98BL82wl0I2GNQBRM=;
        b=GF/wrqXYV5tLpOiUmDItld1gsEy6/iirwBNhFb82LDp1+J5vRK0HkkJ0BeitkPpNCK
         8nZTVys1ZsHACa1uhY72NUc+H+ZFgJP91YjLgbI4zJQsaW/piyyfK5IqgPscBzSrpR81
         BLgycOvXoJUNRXFYzaI49QH5gjBtt+zQD1djVpN50RaOGsgAu1DySJHzJFqsECFduMSS
         M1rhWsJxWOuyITpCkfoDk8Lj1Pitfcg8XlJrHrRC9lXiWmPNREO9ZS12VCGCP7Df4s9+
         zdNS4iiv8dmF4k7aUAX2I6suXFQ3bInJdui3WBVMbLQfW8JFFqwYH6hWntdTwUIAneAj
         khTQ==
X-Gm-Message-State: AOJu0YwrV5HEzp/TVPXAbvD/gI65ca2A5AMYcmUZZH14LEIGGIUxPjq7
	Rf9ncFC0U1CGlIiJ4DRHQZQaBokqRzRjZfK4hlcoMr2olUv3g0ibvIqUq84Z3WI2KhSUsOx+mzF
	TozW4IlQEnYQk1pofCWz/sLprP1I=
X-Gm-Gg: ASbGncunouX9B7GsWWroRUhXbLCt1SOCaZJeCL29AmBF3ij/KIWM5RqC1rXpqKET4rY
	zCzAc2kkuz21rkqx4gtJPiVW0Z9FXGDjwDtrziAkrFk5hK6zcRpbhOH0O2x1qDK2p8ac5ulsPcy
	rRrQgshUg1IYb7lDGYAHn5vdEyssuE7/VLSdrTHU+1oqnTP3O6ZnsQag==
X-Google-Smtp-Source: 
 AGHT+IG2XVV/eG/sMKZ7YNChnkCtBrGCWKR4jMi+5gtPuJenkkUFdNe+5TaFuFYBOSI8f1kwtAzImsYOrc1HCf0dJ2w=
X-Received: by 2002:a05:651c:160d:b0:30d:626e:d004 with SMTP id
 38308e7fff4ca-30f44fc2766mr5277231fa.20.1744190765309; Wed, 09 Apr 2025
 02:26:05 -0700 (PDT)
MIME-Version: 1.0
References: 
 <CACJufxFxnSkikp+GormAGHcMTX1YH2HRXW1+3dJM9w7yY9hdsg@mail.gmail.com>
In-Reply-To: 
 <CACJufxFxnSkikp+GormAGHcMTX1YH2HRXW1+3dJM9w7yY9hdsg@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Wed, 9 Apr 2025 14:25:54 +0500
X-Gm-Features: ATxdqUEv7XNCaKGjpegrG6URNQBJ1KWoPUrRqpoTRcy12uhLrRTLxmIxpCFp7eo
Message-ID: 
 <CALdSSPi_Aw2EZwQiKDE7MjW9m6yDPH++xGTOrWu3o=RWyq5qHQ@mail.gmail.com>
Subject: Re: tab complete for COPY populated materialized view TO
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPi_Aw2EZwQiKDE7MjW9m6yDPH%2B%2BxGTOrWu3o%3DRWyq5qHQ%40mail.gmail.com>
Precedence: bulk

On Wed, 9 Apr 2025 at 13:23, jian he <jian.universality@gmail.com> wrote:
>
> hi.
>
> we allow the "COPY table TO" command to copy rows from materialized
> views in [1].
> The attached patch is to add a tab complete for it.
>
> [1] https://git.postgresql.org/cgit/postgresql.git/commit/?id=534874fac0b34535c9a5ab9257d6574f78423578

Hi!
Patch works good for me, but I noticed that psql COPY <tab> suggests
partitioned relation both with and without this patch. Maybe that's
not a big problem, if [0] will be pushed.


[0] https://www.postgresql.org/message-id/CACJufxHjBPrsbNZAp-DCmwvOE_Gkogb%2Brhfqqe1%3DS5cOHR-V7Q%40mail.gmail.com

-- 
Best regards,
Kirill Reshke