Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vetWD-001aWO-23 for pgsql-hackers@arkaria.postgresql.org; Sun, 11 Jan 2026 11:22:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vetWB-00Bp5W-2J for pgsql-hackers@arkaria.postgresql.org; Sun, 11 Jan 2026 11:22:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vetWB-00Bp5O-1I for pgsql-hackers@lists.postgresql.org; Sun, 11 Jan 2026 11:22:00 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vetW9-005zYP-11 for pgsql-hackers@postgresql.org; Sun, 11 Jan 2026 11:21:59 +0000 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4f1aecac2c9so55501631cf.1 for ; Sun, 11 Jan 2026 03:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768130515; x=1768735315; darn=postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FaDaepCMEHVhGBwtED8aUI3iWQObKj6J8pIJVlK7kcs=; b=YNrWLsdq+VgUIcWxTKQztQcgqLP1NmP7xQt2kN5fcE9hlhInntGBq854MXwywYHQCB aCU+2Eu1ejqbyq7pcarrS/E7z2KiulM5NIB5fHkxDYdACMq10tLLV87KEoSnDhpXN/Y0 2IIC/n2r47i5S/QIdtr51jwN5qxnZCZ0DJQTxa167ZJiwTZse83LI7oSHjHHssc3E/k6 NPpALJ3Lrgjb6/nU1YKTjuc4//KSAPRjoa1l05GnyyQjbS+rKB4R+oeCGwsywvDkaYZq 32ecn8RcCBefaZnj7yLlo3wjzvAFVme/lF/pp3CsTWjXpZmROKmVQi++ATmb6GF5HFSR EFgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768130515; x=1768735315; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FaDaepCMEHVhGBwtED8aUI3iWQObKj6J8pIJVlK7kcs=; b=iCFPR6NlC8HQbCfjgoO/hin03VR7rVS/NuLC3nPUgIF1Ob9Z/4XQAkG9FEagy3SqlQ ObV6IgwAeHfXacg1z6QX5hMpRn3BsJUMbll/xrCkVVFXkM/BdVtNMn+2JJXMFI1FNUIG 3yKl3uDJw3C1/oKx4LXhY3W2Iflgpk5Pcz9pOozDb24Hmzxd13cCESpucT9p7G3TC0sd xLaXkv1yM6JbkAy8eRyOQQU+8qlVSaQ41ueuBJo9su1dM2eJc7mzCLx5RNhzsDoFSZjt WZlKtFCOXFIbKBMyq0T6IS5O3jfuCGxyMWrRiZDeTa22sovouVIiB+EIYTtCr+semeXS gsaA== X-Gm-Message-State: AOJu0Yyz9eygbeZ8NYsQ1mZsSwtFtsvhMlleoyNHBf+oVYrp54JHNK60 aWtJbW8LSPJU7NnsSb5460MXdGarDLc1yJ3LW1FfygpFme4DiYf9y/OQTQKcLMgn4pFcKbRF7Pi cq1btvtWpB0pfkJlrMtzPAozwRVK7V8tp5h6Z X-Gm-Gg: AY/fxX4NibTCm0cNMSifDfM5uFTYIAXHWgu80hHydk7GdV53wr6FDpErGubUZ0YxWhQ 8PdRrpI8CC2NDK+JQGIBHrNZ+WLWr6uBR5K1Kh4uWArh39EeGtBxfUf9TWb3wLWWmXt+Hg31ua7 r60jafeFqYgLE3/OjdJAzpzntZ/Af7T6tdn5gEgu4c84epoXbVGUv2GGPo84hXC9+OijWX0a8bf y2J6D1eLWN0apSMTKm8+SO8mA5AwAxPAV/05sGjnJNvmuiTCanHw9CYiegtFcz/oKdLyTB447K5 YRQw/djJlAvrSf2v8pRSdgkUMDa0957uMEWFtp630iM6KyBm7mT8yY+epWsAJBkYmp3f3WFeI0O oS/T1 X-Google-Smtp-Source: AGHT+IEk3xx+bb/5jIkgHw7hnr7NWTMWPcUe80ievEFvhSxudRzByPyqQgD9SCkOoMn9j1o1BdF+Dt0aV8BPsLuGIUo= X-Received: by 2002:ac8:5f08:0:b0:4ff:a9cc:e0bc with SMTP id d75a77b69052e-4ffb402aa21mr199837231cf.39.1768130515404; Sun, 11 Jan 2026 03:21:55 -0800 (PST) MIME-Version: 1.0 From: Kirill Reshke Date: Sun, 11 Jan 2026 16:21:43 +0500 X-Gm-Features: AZwV_QhC20m4HzMGGljoI7AWLhvMPtEwb1D3P82EPcxPgduEihArc8ubqHPEFD4 Message-ID: Subject: Use correct macro for accessing offset numbers. To: pgsql-hackers Content-Type: multipart/mixed; boundary="0000000000004a4eb306481af740" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000004a4eb306481af740 Content-Type: text/plain; charset="UTF-8" Hi hackers! While working on pageinspect support for GIN and SpGiST (welcome to review them [0] & [1]), I spotted $subi. PFA trivial patch that uses UInt16GetDatum for OffsetNumber rather than Int16GetDatum [0]https://www.postgresql.org/message-id/CALdSSPiN13n7feQcY0WCmq8jzxjwqhNrt1E%3Dg%3Dg6aZANyE_OoQ%40mail.gmail.com [1] https://www.postgresql.org/message-id/CALdSSPhbAQbFtjK0nT8_G5GsXmsSEVx8J735Ga%2BZxLp9osHcRA%40mail.gmail.com -- Best regards, Kirill Reshke --0000000000004a4eb306481af740 Content-Type: application/octet-stream; name="v1-0001-Use-correct-macro-for-accessing-offset-numbers.patch" Content-Disposition: attachment; filename="v1-0001-Use-correct-macro-for-accessing-offset-numbers.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mk9n5j110 RnJvbSA4MDNhOGFhYzQ2NTZjMzIwMzYyY2FkNmM1NTUwODMyMDk4M2IzYzU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFN1 biwgMTEgSmFuIDIwMjYgMTE6MTc6MTMgKzAwMDAKU3ViamVjdDogW1BBVENIIHYxXSBVc2UgY29y cmVjdCBtYWNybyBmb3IgYWNjZXNzaW5nIG9mZnNldCBudW1iZXJzLgoKLS0tCiBjb250cmliL3Bh Z2VpbnNwZWN0L2J0cmVlZnVuY3MuYyB8IDIgKy0KIGNvbnRyaWIvcGFnZWluc3BlY3QvZ2lzdGZ1 bmNzLmMgIHwgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9jb250cmliL3BhZ2VpbnNwZWN0L2J0cmVlZnVuY3MuYyBi L2NvbnRyaWIvcGFnZWluc3BlY3QvYnRyZWVmdW5jcy5jCmluZGV4IDYyYzkwNWM2ZTdjLi4wNTg1 YjdjZWU0MCAxMDA2NDQKLS0tIGEvY29udHJpYi9wYWdlaW5zcGVjdC9idHJlZWZ1bmNzLmMKKysr IGIvY29udHJpYi9wYWdlaW5zcGVjdC9idHJlZWZ1bmNzLmMKQEAgLTUwNyw3ICs1MDcsNyBAQCBi dF9wYWdlX3ByaW50X3R1cGxlcyh1YV9wYWdlX2l0ZW1zICp1YXJncykKIAogCWogPSAwOwogCW1l bXNldChudWxscywgMCwgc2l6ZW9mKG51bGxzKSk7Ci0JdmFsdWVzW2orK10gPSBJbnQxNkdldERh dHVtKG9mZnNldCk7CisJdmFsdWVzW2orK10gPSBVSW50MTZHZXREYXR1bShvZmZzZXQpOwogCXZh bHVlc1tqKytdID0gSXRlbVBvaW50ZXJHZXREYXR1bSgmaXR1cC0+dF90aWQpOwogCXZhbHVlc1tq KytdID0gSW50MzJHZXREYXR1bSgoaW50KSBJbmRleFR1cGxlU2l6ZShpdHVwKSk7CiAJdmFsdWVz W2orK10gPSBCb29sR2V0RGF0dW0oSW5kZXhUdXBsZUhhc051bGxzKGl0dXApKTsKZGlmZiAtLWdp dCBhL2NvbnRyaWIvcGFnZWluc3BlY3QvZ2lzdGZ1bmNzLmMgYi9jb250cmliL3BhZ2VpbnNwZWN0 L2dpc3RmdW5jcy5jCmluZGV4IDYwYTRiMjQwMzAyLi45YjdlM2NlYzg4MiAxMDA2NDQKLS0tIGEv Y29udHJpYi9wYWdlaW5zcGVjdC9naXN0ZnVuY3MuYworKysgYi9jb250cmliL3BhZ2VpbnNwZWN0 L2dpc3RmdW5jcy5jCkBAIC0xNzUsNyArMTc1LDcgQEAgZ2lzdF9wYWdlX2l0ZW1zX2J5dGVhKFBH X0ZVTkNUSU9OX0FSR1MpCiAKIAkJbWVtc2V0KG51bGxzLCAwLCBzaXplb2YobnVsbHMpKTsKIAot CQl2YWx1ZXNbMF0gPSBJbnQxNkdldERhdHVtKG9mZnNldCk7CisJCXZhbHVlc1swXSA9IFVJbnQx NkdldERhdHVtKG9mZnNldCk7CiAJCXZhbHVlc1sxXSA9IEl0ZW1Qb2ludGVyR2V0RGF0dW0oJml0 dXAtPnRfdGlkKTsKIAkJdmFsdWVzWzJdID0gSW50MzJHZXREYXR1bSgoaW50KSBJbmRleFR1cGxl U2l6ZShpdHVwKSk7CiAKQEAgLTI4Miw3ICsyODIsNyBAQCBnaXN0X3BhZ2VfaXRlbXMoUEdfRlVO Q1RJT05fQVJHUykKIAogCQltZW1zZXQobnVsbHMsIDAsIHNpemVvZihudWxscykpOwogCi0JCXZh bHVlc1swXSA9IEludDE2R2V0RGF0dW0ob2Zmc2V0KTsKKwkJdmFsdWVzWzBdID0gVUludDE2R2V0 RGF0dW0ob2Zmc2V0KTsKIAkJdmFsdWVzWzFdID0gSXRlbVBvaW50ZXJHZXREYXR1bSgmaXR1cC0+ dF90aWQpOwogCQl2YWx1ZXNbMl0gPSBJbnQzMkdldERhdHVtKChpbnQpIEluZGV4VHVwbGVTaXpl KGl0dXApKTsKIAkJdmFsdWVzWzNdID0gQm9vbEdldERhdHVtKEl0ZW1JZElzRGVhZChpZCkpOwot LSAKMi40My4wCgo= --0000000000004a4eb306481af740--