public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kirill Reshke <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Cleanup explain_memoize function after test
Date: Wed, 22 Apr 2026 11:49:32 +0500
Message-ID: <CALdSSPij9tx019ZzR+VVj7cEEd7HL4-SPiu+YKx66n9-rVPkUg@mail.gmail.com> (raw)

Hi!

I was doing some hacking today, when I noticed that the memoize
regression test does not clean up the explain_memoize function after
its end. I checked other regression tests and they tend to do it. So,
I am not sure if there is a rule about `you should drop all objects
that you create in regression test`, but if there is such a rule, PFA.



-- 
Best regards,
Kirill Reshke


Attachments:

  [application/octet-stream] v1-0001-Cleanup-explain_memoize-after-resgression-test.patch (721B, 2-v1-0001-Cleanup-explain_memoize-after-resgression-test.patch)
  download | inline diff:
From eb777d061f23699e1f9837c928636989906481f8 Mon Sep 17 00:00:00 2001
From: reshke <[email protected]>
Date: Wed, 22 Apr 2026 06:46:25 +0000
Subject: [PATCH v1] Cleanup explain_memoize after resgression test

---
 src/test/regress/sql/memoize.sql | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/test/regress/sql/memoize.sql b/src/test/regress/sql/memoize.sql
index e39bbb65391..4774d20c624 100644
--- a/src/test/regress/sql/memoize.sql
+++ b/src/test/regress/sql/memoize.sql
@@ -272,4 +272,6 @@ SELECT * FROM tab_anti t1 WHERE t1.a IN
  (SELECT a FROM tab_anti t2 WHERE t2.b IN
   (SELECT t1.b FROM tab_anti t3 WHERE t2.a > 1 OFFSET 0));
 
+DROP FUNCTION explain_memoize;
+
 DROP TABLE tab_anti;
-- 
2.43.0

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Cleanup explain_memoize function after test
  In-Reply-To: <CALdSSPij9tx019ZzR+VVj7cEEd7HL4-SPiu+YKx66n9-rVPkUg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox