MIME-Version: 1.0
References: <CA+E0NR4S+NC6+QHyY_vUuQZMzLhKqczMx-jJVqtjAxF6+=JwAA@mail.gmail.com>
 <94d53a41-d1f5-4fd1-8d1e-ff36ac569848@app.fastmail.com> <4DA5A159-39FD-47DB-95E5-A4F65BC5782A@yandex-team.ru>
 <53e96b5a-cc77-4afa-8103-79c69afef1a6@uni-muenster.de> <CA+E0NR4=J-pgqEAV2weymygGmk1ePym45m2AcGyi2hpa9xRvBg@mail.gmail.com>
In-Reply-To: <CA+E0NR4=J-pgqEAV2weymygGmk1ePym45m2AcGyi2hpa9xRvBg@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Mon, 25 Nov 2024 21:52:17 +0500
Message-ID: <CALdSSPiq+x9pRVYvYtddTQsL8=ZMvob+vSv5mHEXbe0aoPWGig@mail.gmail.com>
Subject: Re: Truncate logs by max_log_size
To: Kirill Gavrilov <diphantxm@gmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, 
	Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALdSSPiq%2Bx9pRVYvYtddTQsL8%3DZMvob%2BvSv5mHEXbe0aoPWGig%40mail.gmail.com>
Precedence: bulk

On Tue, 1 Oct 2024 at 20:46, Kirill Gavrilov <diphantxm@gmail.com> wrote:
>
> On Tue, Oct 1, 2024 at 2:46=E2=80=AFPM Jim Jones <jim.jones@uni-muenster.=
de> wrote:
>>
>>
>> On 27.09.24 12:36, Andrey M. Borodin wrote:
>> > Consider max_log_size =3D 10Mb. The perspective might look very differ=
ent.
>> >  It=E2=80=99s not about WHERE anymore. It's a guard against heavy abus=
e.
>> >
>> > The feature looks very important for me.
>> I have the same opinion. As a fail safe it sounds very useful to me.
>>
>> Unfortunately, the patch does not apply:
>>
>> $ git apply
>> ~/patches/max_log_query/0001-parameter-max_log_size-to-truncate-logs.pat=
ch
>> -v
>> Checking patch src/backend/utils/error/elog.c...
>> error: while searching for:
>> char       *Log_destination_string =3D NULL;
>> bool            syslog_sequence_numbers =3D true;
>> bool            syslog_split_messages =3D true;
>>
>> /* Processed form of backtrace_symbols GUC */
>> static char *backtrace_symbol_list;
>>
>> error: patch failed: src/backend/utils/error/elog.c:114
>> error: src/backend/utils/error/elog.c: patch does not apply
>> Checking patch src/backend/utils/misc/guc_tables.c...
>> Hunk #1 succeeded at 3714 (offset 247 lines).
>> Checking patch src/backend/utils/misc/postgresql.conf.sample...
>> Hunk #1 succeeded at 615 (offset 23 lines).
>> Checking patch src/bin/pg_ctl/t/004_logrotate.pl...
>> error: while searching for:
>> check_log_pattern('csvlog',  $new_current_logfiles, 'syntax error', $nod=
e);
>> check_log_pattern('jsonlog', $new_current_logfiles, 'syntax error', $nod=
e);
>>
>> $node->stop();
>>
>> done_testing();
>>
>> error: patch failed: src/bin/pg_ctl/t/004_logrotate.pl:135
>> error: src/bin/pg_ctl/t/004_logrotate.pl: patch does not apply
>> Checking patch src/include/utils/elog.h...
>> Hunk #1 succeeded at 502 (offset 1 line).
>>
>> Does it truncate only single queries or also a transaction with many
>> statements?
>>
>> Thanks!
>>
>> Best, Jim
>
>
>  My apologies, attached patch should work on master branch.
> It truncates single queries and a statement in transaction that occurred =
an error.
>

Hello! Please deliver the most recent patch version and fix the issues
Jim identified [0] as the current commitfest draws to a close.
Do not forget to include both parts of this patch (This was actually
developed off-list, and we are now using this on our cloud PostgreSQL
distribution on versions 12=E2=80=9317).

[0] https://www.postgresql.org/message-id/35096a36-04d4-480b-a7cd-a2d8151fb=
737%40uni-muenster.de

--=20
Best regards,
Kirill Reshke