MIME-Version: 1.0
References: 
 <CALdSSPgZWX_D8+Fx4YQqRN5eW5iSx_rJdqQhCfdWTvqKXVfJ4w@mail.gmail.com>
 <CALdSSPgPs=gKWkKN0=4yBd49FBY=ijxBz4YGV64vfVMK7YQhpw@mail.gmail.com>
 <CALdSSPiaQptrccvRoHhP3=YqN9-K8duXfLHHm3G=+7FVL8A-Xw@mail.gmail.com>
 <CALdSSPh-QtT8NrhtKsNWwFVF3D4KX6Wy3qs-FPc16c6VAECEyg@mail.gmail.com>
 <CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com>
 <449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru>
 <CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
 <14B4E29D-7B08-4972-BE9E-491A8A6A77CF@yandex-team.ru>
 <CAMtXxw_=fD6hAoLPagLT8fEPa6qe=oD-6ecXq2h1UmtBLv_GFA@mail.gmail.com>
In-Reply-To: 
 <CAMtXxw_=fD6hAoLPagLT8fEPa6qe=oD-6ecXq2h1UmtBLv_GFA@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Wed, 18 Mar 2026 10:42:08 +0500
Message-ID: 
 <CALdSSPirzFew+O0ZVDh81f8m_cwd7SMdRMZwGa-uy7zg078dGQ@mail.gmail.com>
Subject: Re: Fix gistkillitems & add regression test to microvacuum
To: Soumya S Murali <soumyamurali.work@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
	Andres Freund <andres@anarazel.de>
Content-Type: multipart/mixed; boundary="000000000000516ae8064d45ea5a"
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPirzFew%2BO0ZVDh81f8m_cwd7SMdRMZwGa-uy7zg078dGQ%40mail.gmail.com>
Precedence: bulk

--000000000000516ae8064d45ea5a
Content-Type: text/plain; charset="UTF-8"

On Wed, 11 Feb 2026 at 17:18, Soumya S Murali
<soumyamurali.work@gmail.com> wrote:
>
> Hi all,
>
> Thank you for the updated patch.
> I reproduced the issue locally by filling a GiST root page, deleting
> all tuples, and triggering a microvacuum by an index-only scan.
> With the patch, The root page is now handled consistently with other
> leaf pages. so->curBlkno and so->curPageLSN are properly set during
> scan, and gistkillitems() operates safely and correctly on the root
> page.
> Based on runtime validation and code inspection, the fix LGTM.
>


Rebased due to  f5eb854ab6d[0]

I have added a [0]committer to CC.

Andres, can you please take a look at this thread, if by chance you
have spare time for it? You have changed kill tuples-related logic
frequently, so you might be interested...

[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=f5eb854ab6d6281ec2d3143657944bdda6676341

-- 
Best regards,
Kirill Reshke

--000000000000516ae8064d45ea5a
Content-Type: application/octet-stream;
	name="v3-0001-Fix-gistkillitems-for-GiST-ROOT-page.patch"
Content-Disposition: attachment;
	filename="v3-0001-Fix-gistkillitems-for-GiST-ROOT-page.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmvm1m740>
X-Attachment-Id: f_mmvm1m740

RnJvbSBlNzk2YjI1YmJkMDc2NTIzMTMwN2VjNGM3NTdmNjdiZmRlZjllMzYzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFRo
dSwgMTUgSmFuIDIwMjYgMDY6MzQ6NDIgKzAwMDAKU3ViamVjdDogW1BBVENIIHYzXSBGaXggZ2lz
dGtpbGxpdGVtcyBmb3IgR2lTVCBST09UIHBhZ2UuCgpHaVNUIGluZGV4IGtpbGxpdGVtcyBmZWF0
dXJlIG1pc2JlaGF2ZXMgZm9yIHNpbmdsZS1wYWdlCihST09ULW9ubHkpIEdpU1QgaW5kZXguIFRo
aXMgaXMgY2F1c2VkIGJ5IEdpU1Qgc2NhbgoiY3VycmVudCBibG9jayIgdmFyaWFibGUgbm90IGJl
aWduIGluaXRpYWxpemVkIGZvcgp2ZXJ5IGZpcnN0LXRvLXNjYW4gcGFnZSAod2hpY2ggaXMgUk9P
VCBwYWdlKS4KRml4IHRoaXMgYnkgbW92aW5nIHZhcmlhYmxlIGluaXRpYWxpemF0aW9uIGluCnJl
YWQgcGdhZSB1dGlsaXR5IGZ1bmN0aW9uLiBBbHNvIGFkanVzdCB0ZXN0IG91dHB1dAp0aGF0IHVz
ZWQgdG8gdGVzdCBleGFjdGx5IHRoaXMgYnVnIChzdGFydGluZyAzNzdiN2FiKS4KClJldmlld2Vk
LWJ5OiBBbmRyZXkgQm9yb2RpbiA8eDRtbW1AeWFuZGV4LXRlYW0ucnU+ClJldmlld2VkLWJ5OiBT
b3VteWEgUyBNdXJhbGkgPHNvdW15YW11cmFsaS53b3JrQGdtYWlsLmNvbT4KCkRpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0FMZFNTUGdaV1hfRDglMkJGeDRZUXFSTjVlVzVpU3hfckpk
cVFoQ2ZkV1R2cUtYVmZKNHclNDBtYWlsLmdtYWlsLmNvbQpEaXNjdXNzaW9uOiBodHRwczovL3Bv
c3Rnci5lcy9tL2x4emoyNmdhNmlwcGRldW56Nmt1bmNlY3RyNWdmdXVnbW0ycnkyMnF1NmhjeDZv
aWQ2QGx6eDNzanNxaG10NgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy9naXN0L2dpc3RnZXQuYyAg
ICAgICAgICAgICAgfCA2ICsrKy0tLQogc3JjL3Rlc3QvbW9kdWxlcy9pbmRleC9leHBlY3RlZC9r
aWxsdHVwbGVzLm91dCB8IDIgKy0KIHNyYy90ZXN0L21vZHVsZXMvaW5kZXgvc3BlY3Mva2lsbHR1
cGxlcy5zcGVjICAgfCAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBk
ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2lzdC9naXN0Z2V0
LmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvZ2lzdC9naXN0Z2V0LmMKaW5kZXggNGQ3YzEwMGQ3Mzcu
Ljg1MWQzNjc5Y2U0IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvZ2lzdC9naXN0Z2V0
LmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL2dpc3QvZ2lzdGdldC5jCkBAIC00MTUsNiArNDE1
LDkgQEAgZ2lzdFNjYW5QYWdlKEluZGV4U2NhbkRlc2Mgc2NhbiwgR0lTVFNlYXJjaEl0ZW0gKnBh
Z2VJdGVtLAogCSAqLwogCXNvLT5jdXJQYWdlTFNOID0gQnVmZmVyR2V0TFNOQXRvbWljKGJ1ZmZl
cik7CiAKKwkvKiBzYXZlIGN1cnJlbnQgaXRlbSBCbG9ja051bWJlciBmb3IgZ2lzdGtpbGxpdGVt
cygpIGNhbGwgKi8KKwlzby0+Y3VyQmxrbm8gPSBwYWdlSXRlbS0+Ymxrbm87CisKIAkvKgogCSAq
IGNoZWNrIGFsbCB0dXBsZXMgb24gcGFnZQogCSAqLwpAQCAtNzMwLDkgKzczMyw2IEBAIGdpc3Rn
ZXR0dXBsZShJbmRleFNjYW5EZXNjIHNjYW4sIFNjYW5EaXJlY3Rpb24gZGlyKQogCiAJCQkJQ0hF
Q0tfRk9SX0lOVEVSUlVQVFMoKTsKIAotCQkJCS8qIHNhdmUgY3VycmVudCBpdGVtIEJsb2NrTnVt
YmVyIGZvciBuZXh0IGdpc3RraWxsaXRlbXMoKSBjYWxsICovCi0JCQkJc28tPmN1ckJsa25vID0g
aXRlbS0+Ymxrbm87Ci0KIAkJCQkvKgogCQkJCSAqIFdoaWxlIHNjYW5uaW5nIGEgbGVhZiBwYWdl
LCBJdGVtUG9pbnRlcnMgb2YgbWF0Y2hpbmcgaGVhcAogCQkJCSAqIHR1cGxlcyBhcmUgc3RvcmVk
IGluIHNvLT5wYWdlRGF0YS4gIElmIHRoZXJlIGFyZSBhbnkgb24KZGlmZiAtLWdpdCBhL3NyYy90
ZXN0L21vZHVsZXMvaW5kZXgvZXhwZWN0ZWQva2lsbHR1cGxlcy5vdXQgYi9zcmMvdGVzdC9tb2R1
bGVzL2luZGV4L2V4cGVjdGVkL2tpbGx0dXBsZXMub3V0CmluZGV4IGEzZGIyYzQwOTM2Li4xZDk0
NGI0OTNjMiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy9pbmRleC9leHBlY3RlZC9raWxs
dHVwbGVzLm91dAorKysgYi9zcmMvdGVzdC9tb2R1bGVzL2luZGV4L2V4cGVjdGVkL2tpbGx0dXBs
ZXMub3V0CkBAIC0yMjMsNyArMjIzLDcgQEAgc3RlcCBmbHVzaDogU0VMRUNUIEZST00gcGdfc3Rh
dF9mb3JjZV9uZXh0X2ZsdXNoKCk7CiBzdGVwIHJlc3VsdDogU0VMRUNUICgoaGVhcF9ibGtzX3Jl
YWQgKyBoZWFwX2Jsa3NfaGl0IC0gY291bnRlci5oZWFwX2FjY2Vzc2VzKSA+IDApIEFTIGhhc19u
ZXdfaGVhcF9hY2Nlc3NlcyBGUk9NIGNvdW50ZXIsIHBnX3N0YXRpb19hbGxfdGFibGVzIFdIRVJF
IHJlbG5hbWUgPSAna2lsbF9wcmlvcl90dXBsZSc7CiBoYXNfbmV3X2hlYXBfYWNjZXNzZXMKIC0t
LS0tLS0tLS0tLS0tLS0tLS0tLQotdCAgICAgICAgICAgICAgICAgICAgCitmICAgICAgICAgICAg
ICAgICAgICAKICgxIHJvdykKIAogc3RlcCBkcm9wX3RhYmxlOiBEUk9QIFRBQkxFIElGIEVYSVNU
UyBraWxsX3ByaW9yX3R1cGxlOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvbW9kdWxlcy9pbmRleC9z
cGVjcy9raWxsdHVwbGVzLnNwZWMgYi9zcmMvdGVzdC9tb2R1bGVzL2luZGV4L3NwZWNzL2tpbGx0
dXBsZXMuc3BlYwppbmRleCAzYjk4ZmY5Zjc2ZC4uYmQ5MjNjOGJiMDAgMTAwNjQ0Ci0tLSBhL3Ny
Yy90ZXN0L21vZHVsZXMvaW5kZXgvc3BlY3Mva2lsbHR1cGxlcy5zcGVjCisrKyBiL3NyYy90ZXN0
L21vZHVsZXMvaW5kZXgvc3BlY3Mva2lsbHR1cGxlcy5zcGVjCkBAIC05Niw3ICs5Niw3IEBAIHBl
cm11dGF0aW9uCiAgIG1lYXN1cmUgYWNjZXNzIGZsdXNoIHJlc3VsdAogICBkcm9wX3RhYmxlIGRy
b3BfZXh0X2J0cmVlX2dpc3QKIAotIyBUZXN0IGdpc3QsIGJ1dCB3aXRoIGZld2VyIHJvd3MgLSBz
aG93cyB0aGF0IGtpbGxpdGVtcyBkb2Vzbid0IHdvcmsgYW55bW9yZSEKKyMgVGVzdCBnaXN0LCBi
dXQgd2l0aCBmZXdlciByb3dzIC0gdGhhdCBraWxsaXRlbXMgdXNlZCB0byBiZSBidWdneS4KIHBl
cm11dGF0aW9uCiAgIGNyZWF0ZV90YWJsZSBmaWxsXzEwIGNyZWF0ZV9leHRfYnRyZWVfZ2lzdCBj
cmVhdGVfZ2lzdCBmbHVzaAogICBkaXNhYmxlX3NlcSBkaXNhYmxlX2JpdG1hcAotLSAKMi4yNS4x
Cgo=
--000000000000516ae8064d45ea5a--