MIME-Version: 1.0
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com>
 <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru>
 <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com>
 <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru>
 <E0B6D242-C16D-4848-930E-B693D4E5C678@upgrade.com>
 <e2003f94-2075-4183-8298-9d25d8431fb1@postgrespro.ru>
 <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com>
 <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru>
 <CAPpHfds=woPcB9nPtMmu=g=U9q6-FHFh7fF_x=uhU3k2Oi03sA@mail.gmail.com>
 <30d54302-9e9c-4e04-819e-a13b679cdcc8@postgrespro.ru>
 <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru>
 <1e81a0a1-a63b-48fb-905a-d6495f89ab73@postgrespro.ru>
 <0b4eefc7-4c38-4caa-b2ca-a4c75dd7dd12@postgrespro.ru>
 <CAPpHfduoJEuoixPTTg2tjhnXqrdobuMaQGxriqxJ9TjN1uxOuA@mail.gmail.com>
 <fb8f05ad-096a-4865-9beb-08d4460222bb@postgrespro.ru>
 <333c2306-c401-4959-9f0c-a44c670a11a9@postgrespro.ru>
 <513f0188-b093-4cc8-98cf-4c324570d525@postgrespro.ru>
In-Reply-To: <513f0188-b093-4cc8-98cf-4c324570d525@postgrespro.ru>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Mon, 10 Mar 2025 18:33:15 +0500
Message-ID: 
 <CALdSSPiw_-0_L3YV=Qn7oopPqY2XVrXwDSGLdSXS69QvMdXisQ@mail.gmail.com>
Subject: Re: Vacuum statistics
To: Alena Rybakina <a.rybakina@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alexander Korotkov <aekorotkov@gmail.com>,
	Jim Nasby <jnasby@upgrade.com>,
 Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
	Andrei Zubkov <zubkov@moonset.ru>, Masahiko Sawada <sawada.mshk@gmail.com>,
	Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>,
	a.lepikhov@postgrespro.ru, Sami Imseih <samimseih@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALdSSPiw_-0_L3YV%3DQn7oopPqY2XVrXwDSGLdSXS69QvMdXisQ%40mail.gmail.com>
Precedence: bulk

On Thu, 27 Feb 2025 at 23:00, Alena Rybakina <a.rybakina@postgrespro.ru> wr=
ote:
>
> Hi!
> On 17.02.2025 17:46, Alena Rybakina wrote:
> > On 04.02.2025 18:22, Alena Rybakina wrote:
> >> Hi! Thank you for your review!
> >>
> >> On 02.02.2025 23:43, Alexander Korotkov wrote:
> >>> On Mon, Jan 13, 2025 at 3:26=E2=80=AFPM Alena Rybakina
> >>> <a.rybakina@postgrespro.ru> wrote:
> >>>> I noticed that the cfbot is bad, the reason seems to be related to
> >>>> the lack of a parameter in
> >>>> src/backend/utils/misc/postgresql.conf.sample. I added it, it
> >>>> should help.
> >>> The patch doesn't apply cleanly.  Please rebase.
> >> I rebased them.
> > The patch needed a rebase again. There is nothing new since version
> > 18, only a rebase.
>
> The patch needed a new rebase.
>
> Sorry, but due to feeling unwell I picked up a patch from another thread
> and squashed the patch for vacuum statistics for indexes and heaps in
> the previous version. Now I fixed everything together with the rebase.
>
> --
> Regards,
> Alena Rybakina
> Postgres Professional

Hi!
CI fails on this one[0]

Is it a flap or a real problem caused by v20?

```

 SELECT relpages AS irp
diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_d=
b_statistics.out
/tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/resu=
lts/vacuum_tables_and_db_statistics.out
--- /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_sta=
tistics.out
2025-03-10 09:36:10.274799176 +0000
+++ /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/=
results/vacuum_tables_and_db_statistics.out
2025-03-10 09:49:35.796596462 +0000
@@ -65,7 +65,7 @@
 WHERE vt.relname =3D 'vestat' AND vt.relid =3D c.oid;
  relname | vm_new_frozen_pages | tuples_deleted | relpages |
pages_scanned | pages_removed
 ---------+---------------------+----------------+----------+--------------=
-+---------------
- vestat  |                   0 |              0 |      455 |
   0 |             0
+ vestat  |                   0 |              0 |      417 |
   0 |             0
 (1 row)

 SELECT relpages AS rp
=3D=3D=3D EOF =3D=3D=3D


```

[0] https://api.cirrus-ci.com/v1/artifact/task/5336493629112320/testrun/bui=
ld-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regres=
s

--=20
Best regards,
Kirill Reshke