Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vXYlv-00F22g-1y for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Dec 2025 05:47:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vXYlt-00DOi3-0u for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Dec 2025 05:47:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vXYls-00DOhv-39 for pgsql-hackers@lists.postgresql.org; Mon, 22 Dec 2025 05:47:53 +0000 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vXYlr-0021L6-1b for pgsql-hackers@lists.postgresql.org; Mon, 22 Dec 2025 05:47:53 +0000 Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4f1b147eaa9so29858621cf.3 for ; Sun, 21 Dec 2025 21:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766382469; x=1766987269; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=THF+hdGp0IXozBu1WW/2/GCaYW7rzbvjpAbaNxAoXdM=; b=PIqftH+8ddRi5kEtSRd9zCE6YRrTRLRtjCOFG5pEAjx0NFIiqKqMa5PqL96cJ9aCcf Ws4ZkKYlXSnrhmLMCGSFsYQEcMaByzf71qnW1qPeiEd2Ivh5ym6S2taIsTBI9S8FlLqx p2lk1CFyodOFQ4ru4BNPwuXzmEl1pprH9tUQs8LF+xzCFcE3SRaKlDT39b9ADdimO7oS GgpzMvkbwPmy1UbNLKlB14VEuvZzhfsuTBzxISGa0kqhZW2LNJoDaLhvTlF5EcgAVv59 GH1YYodLXW7ZrH60BL9KBTiGnenAoxgVScRVZff56+DI2rZyjb9LNmU1zjN1CJWkqwFp +3zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766382469; x=1766987269; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=THF+hdGp0IXozBu1WW/2/GCaYW7rzbvjpAbaNxAoXdM=; b=l2oadiGJqAxsWFKN6aa7Pbkshy6DGBwW/hOMzKtOR+obf2UhwZ8LJAIavGe+NB0MeP Ac+nFtqH8z0SUZLCFIxVQ9QwWBUsEtodJ6uZEC0MIxBGWtou3q1wzHkEMkefZNHIwtCW ql7ldOm6My9Lfd5N9enQbyGMnLN8Sz5qxszRphGtEDEGSR2PfH77/LK1tHtdlr5lYGyb KnJJyySilhwLRO3NuUx8cYenPyvF4X1ajxdOgq0Y3DJ5UOYpLrc4Ax5BPfdm+GeVgClu a0OnYv0mgJ7F+mgmwy1U6APwTdOQHuzIbXbwTP5mbnnUOm/NvFAp5GYMzjO9RrwugoSW ykBw== X-Forwarded-Encrypted: i=1; AJvYcCUToNseEXh2KaSwx6GhsEtDbxTJ9IYIN+XvZyigF1J5Jiw1jAFnrQAvkY7dTypIqSFDl6kzN8GmaMRdB6k8@lists.postgresql.org X-Gm-Message-State: AOJu0YxRY2V48zUvv5FdF1acoH2Iuqwa+f5Nx69tVl3X1ieq8aBB+SlT cnS8/pYkV+LRKNQbPwXiTU9z07+xrs3u2MDQQFJsGZ2dhXBLD1Lf9Va7k5WFY8avij+tg8ukBFo HJ/4pEW0/VOuG9vdF7fAhkx6QKy4e8oI= X-Gm-Gg: AY/fxX4djXNLr3GAcmNC6rAsNmmOZK+tY4/S4oXczaITu3SzQ1mEbWFlRqhn9gQVp7x uHiHUF7gpyiimDcEXNeDOl44344iI82ZJhKAiMRXPE2+MkgQVNN494IU/T3vCBhINKAB3oaAGsB Zk/JaJvWelrybR7FMcasrKxcWp34KHs6fvcK7rczU2k1/QXfKFsUiW2pJb5HUto5PXy6lHY5cRr Uki3OaLOAvIEQhZS6VQ5v/9w8nDCE+3XKQjr/Xvwm1vscp6UHkrhjkBcA/o9Audu7vRjnYc2SBV 7h5M9d/B X-Google-Smtp-Source: AGHT+IEinFpCwyOB0KHfINsT6zH1nAhkcGrh4uxpoTgBRjt3rOf9S1jymVqFTIaPUPgAVCCisf9EJiZ646eEQ32pzRE= X-Received: by 2002:ac8:5981:0:b0:4ed:bb39:9a60 with SMTP id d75a77b69052e-4f4abd99eecmr150822811cf.40.1766382468806; Sun, 21 Dec 2025 21:47:48 -0800 (PST) MIME-Version: 1.0 References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org> <2643645f-2a02-43de-9321-c995ab1b7ef8@postgrespro.ru> <57a94d8a-d7b6-4c5e-9001-be1cd403b172@postgrespro.ru> <54414932-9E82-47AA-902B-2DED18F07F64@gmail.com> <3280c458-a886-4c58-8e2b-4d220b73161d@postgrespro.ru> <09414bf8-9326-431c-9422-b13bddf5f554@postgrespro.ru> <29ff27f5-d359-4479-b11c-ce28e525d806@postgrespro.ru> In-Reply-To: From: Kirill Reshke Date: Mon, 22 Dec 2025 10:47:37 +0500 X-Gm-Features: AQt7F2p8XkCIcMQtyorm6pLhiTd9ZNES3s-V6_L6Sn3o2vTL_8n3koxAGVsR888 Message-ID: Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands To: Alexander Korotkov Cc: Tender Wang , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, 22 Dec 2025 at 03:02, Alexander Korotkov wro= te: > > On Sun, Dec 21, 2025 at 9:42=E2=80=AFAM Kirill Reshke wrote: > > Hi! Your v2 looks fine > > The only question for me is, should we add any regression test to exerc= ise this code, or it is not worth the troubles? > > I've checked contents of out regression tests. I see we very rarely > include SQLSTATE there, mostly in psql and plpgsql tests. Thus, I > think we should just fix the SQLSTATE without dedicating a test for > that. So, I'm going to push the patch from Tender Wang if no > objections. Ok, no objections. --=20 Best regards, Kirill Reshke