MIME-Version: 1.0
References: <CAOzEurQ9kYGd50j4O2RVT2FrLhESDCz8f+P+0y3eS1uYCJmSSg@mail.gmail.com>
 <202510120822.opybjj5dv345@alvherre.pgsql> <CAOzEurRgM_JyYqOxEfBU6t6y7YNT6fzGvM9BvN8=jtiZOJ+iYA@mail.gmail.com>
 <CACJufxGTJrH6ZSpMMBOpAPhPy_Uirz7wpqgO8_Yki_rGqWviHw@mail.gmail.com>
 <CAOzEurR27z9-4-5J0Tv27+c+Y37uY8ZS2g-ttcs0fYaa2CVAUw@mail.gmail.com>
 <CAOzEurQFPH+UNk17MbDhupLCm-i5Gf9dJ4Kx2-er=-YYV4r+sQ@mail.gmail.com> <MEAPR01MB3031B77A2590351DC563605DB6B0A@MEAPR01MB3031.ausprd01.prod.outlook.com>
In-Reply-To: <MEAPR01MB3031B77A2590351DC563605DB6B0A@MEAPR01MB3031.ausprd01.prod.outlook.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Sun, 4 Jan 2026 00:47:23 +0500
Message-ID: <CALdSSPj7U-eqAQb2XOBEQfoJFsnMQHa=MwcMEpiEkNUrhDoCUg@mail.gmail.com>
Subject: Re: remove unnecessary include in src/backend/commands/policy.c
To: Japin Li <japinli@hotmail.com>
Cc: Shinya Kato <shinya11.kato@gmail.com>, jian he <jian.universality@gmail.com>, 
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALdSSPj7U-eqAQb2XOBEQfoJFsnMQHa%3DMwcMEpiEkNUrhDoCUg%40mail.gmail.com>
Precedence: bulk

On Fri, 26 Dec 2025 at 14:29, Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, Shinya
>
> On Fri, 26 Dec 2025 at 16:30, Shinya Kato <shinya11.kato@gmail.com> wrote=
:
> > On Wed, Oct 22, 2025 at 3:30=E2=80=AFPM Shinya Kato <shinya11.kato@gmai=
l.com> wrote:
> >> Thank you for updating the patch.
> >> But I said "except for access/relation.h". I think access/relation.h
> >> is not necessary if you replace relation_open to table_open.
> >
> > I've fixed it, and marked the patch as Ready for Committer.
> >
>
> Found a typo in the commit message.
>
> > RangeVarCallbackForPolicy already ensures policies apply only to tables
> > or partitioned tables, so table_* isthe appropriate API for
> > opening/closing the target relation.
>
> s/isthe/is the/
>
>
> --
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>
>

Hi hackers!

We also can reflect that our new coding practice is to use table/index
open over relation_open in the commit message (I guess so after[0]).

Overall LGTM.

[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=3D9d0f7996e58=
c2a92efe06c901c6dfe1f6ced0a1d

--=20
Best regards,
Kirill Reshke