public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kirill Reshke <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Pgsql Hackers <[email protected]>
Subject: Re: Enhance file_fdw to report processed and skipped tuples in COPY progress
Date: Sat, 30 Nov 2024 11:23:08 +0500
Message-ID: <CALdSSPjMpL1sYgSLFFhmJx4e186U3_Fq7=32od=HRTFMnnnJDQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAD21AoDDJiJRZapB+mbyvetPp_jmYh3bbhu-ntn+911cmWdiyA@mail.gmail.com>
	<[email protected]>

On Fri, 11 Oct 2024 at 06:53, Fujii Masao <[email protected]> wrote:
> However, this issue already exists without the proposed patch.
> Since file_fdw already reports progress partially, querying multiple
> file_fdw tables can lead to inaccurate or confusing progress reports.
> You can even observe this when analyzing a file_fdw table and also
> when copying to the table with a trigger that executes progress-reporting
> commands.
>
> So, I don’t think this issue should block the proposed patch.
> In fact, progress reporting is already flawed in these scenarios,
> regardless of whether the patch is applied.

Im +1 on this. To include or not to include these new fields, and to
fix multiple-run-bug is two separate topics IMO.
Also please notice review comments in[0].

[0] https://www.postgresql.org/message-id/20241011153645.a348de1576a3f57092c68355%40sraoss.co.jp


Moved to the next CF.

-- 
Best regards,
Kirill Reshke

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Enhance file_fdw to report processed and skipped tuples in COPY progress
  In-Reply-To: <CALdSSPjMpL1sYgSLFFhmJx4e186U3_Fq7=32od=HRTFMnnnJDQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox