public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kirill Reshke <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: Define DatumGetInt8 function.
Date: Tue, 6 Jan 2026 19:27:47 +0500
Message-ID: <CALdSSPjSaTvQL28csVo-8hNg8xJ5=YFr6qwtF=JAMLb1eJO2gQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ7c6TPsaLW7O67vqv8YyV_qUUjF0pncDB7dCQJFDw0so7wrdw@mail.gmail.com>
References: <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
	<[email protected]>
	<CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
	<CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com>
	<CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com>
	<CAJ7c6TPsaLW7O67vqv8YyV_qUUjF0pncDB7dCQJFDw0so7wrdw@mail.gmail.com>

On Tue, 6 Jan 2026 at 19:22, Aleksander Alekseev
<[email protected]> wrote:
>
> Hi,
>
> > > Kirill, are you working on this patch?
> >
> > Yes, PFA.
> >
> >  > I've not studied in detail,
> > > but looks like it would require making
> > > char_decrement()/char_increment() and btcharskipsupport() all use
> > > CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
> > > rather than 0/UCHAR_MAX.
> >
> > This is also a possible change, and can be a separate patch. I will
> > try to also work on this this week.
>
> v1 looks incomplete to me. As I understand, Tom proposed to get rid of
> UInt8 conversions as well. Are you going to implement this idea as
> well?
>


Hmm, v1 looks good and self-contained to me. Like, anyway, making two
commits (one for signed Int8 and one for unsigned) here is better for
sake of atomicy?
Anyway, I can see there are users of UInt8GetDatum, which are [0] and
forks of Greenplum. So, I am not super-sure removing UInt8* is
desirable.


[0] https://github.com/duckdb/pg_duckdb/blob/main/src/pgduckdb_types.cpp#L230


-- 
Best regards,
Kirill Reshke

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Define DatumGetInt8 function.
  In-Reply-To: <CALdSSPjSaTvQL28csVo-8hNg8xJ5=YFr6qwtF=JAMLb1eJO2gQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox