MIME-Version: 1.0
References: <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
 <2869012.1767023578@sss.pgh.pa.us> <CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
 <CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com>
In-Reply-To: <CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Tue, 6 Jan 2026 19:12:33 +0500
Message-ID: <CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com>
Subject: Re: Define DatumGetInt8 function.
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fbfff40647b8c4c6"
Archived-At: <https://www.postgresql.org/message-id/CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ%40mail.gmail.com>
Precedence: bulk

--000000000000fbfff40647b8c4c6
Content-Type: text/plain; charset="UTF-8"

On Tue, 6 Jan 2026 at 16:50, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Tue, 30 Dec 2025 at 05:01, Kirill Reshke <reshkekirill@gmail.com> wrote:
> > Well, OK. Removal is also fine for me, because it is at least consistent.
>

> Kirill, are you working on this patch?


Hi!
Yes, PFA.

 > I've not studied in detail,
> but looks like it would require making
> char_decrement()/char_increment() and btcharskipsupport() all use
> CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
> rather than 0/UCHAR_MAX.

This is also a possible change, and can be a separate patch. I will
try to also work on this this week.


-- 
Best regards,
Kirill Reshke

--000000000000fbfff40647b8c4c6
Content-Type: application/octet-stream; 
	name="v1-0001-Remove-Int8GetDatum-function.patch"
Content-Disposition: attachment; 
	filename="v1-0001-Remove-Int8GetDatum-function.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mk2o151b0>
X-Attachment-Id: f_mk2o151b0

RnJvbSAzYzE0NDc3NTJkMDg2OTMyZTkzNzlkNTg2NmE5OTU5MTFlODg3NjBiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFR1
ZSwgNiBKYW4gMjAyNiAxNDowMzo0OSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIFJlbW92ZSBJ
bnQ4R2V0RGF0dW0gZnVuY3Rpb24uCgpXZSBoYXZlIG5vIHVzZXMgb2YgSW50OEdldERhdHVtIGlu
IG91ciB0cmVlIGFuZApkaWQgbm90IGhhdmUgZm9yIGEgbG9uZyB0aW1lIChvciBuZXZlcikuCgpT
dWdnZXN0ZWQtYnk6IAlUb20gTGFuZSA8dGdsQHNzcy5wZ2gucGEudXM+Ci0tLQogc3JjL2luY2x1
ZGUvcG9zdGdyZXMuaCB8IDEwIC0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBkZWxldGlv
bnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9wb3N0Z3Jlcy5oIGIvc3JjL2luY2x1ZGUv
cG9zdGdyZXMuaAppbmRleCA5MjY4ZTY4MzJjYy4uNjQyM2M4N2M2NGUgMTAwNjQ0Ci0tLSBhL3Ny
Yy9pbmNsdWRlL3Bvc3RncmVzLmgKKysrIGIvc3JjL2luY2x1ZGUvcG9zdGdyZXMuaApAQCAtMTM0
LDE2ICsxMzQsNiBAQCBDaGFyR2V0RGF0dW0oY2hhciBYKQogCXJldHVybiAoRGF0dW0pIFg7CiB9
CiAKLS8qCi0gKiBJbnQ4R2V0RGF0dW0KLSAqCQlSZXR1cm5zIGRhdHVtIHJlcHJlc2VudGF0aW9u
IGZvciBhbiA4LWJpdCBpbnRlZ2VyLgotICovCi1zdGF0aWMgaW5saW5lIERhdHVtCi1JbnQ4R2V0
RGF0dW0oaW50OCBYKQotewotCXJldHVybiAoRGF0dW0pIFg7Ci19Ci0KIC8qCiAgKiBEYXR1bUdl
dFVJbnQ4CiAgKgkJUmV0dXJucyA4LWJpdCB1bnNpZ25lZCBpbnRlZ2VyIHZhbHVlIG9mIGEgZGF0
dW0uCi0tIAoyLjQzLjAKCg==
--000000000000fbfff40647b8c4c6--