public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kirill Reshke <[email protected]>
To: David Christensen <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: [email protected]
Subject: Re: Constant Splitting/Refactoring
Date: Sat, 10 Aug 2024 17:26:01 +0500
Message-ID: <CALdSSPjo_bXyhB7ghP-Ms0ghjNY2OznjDN8a=aEZC3=E32NFDA@mail.gmail.com> (raw)
In-Reply-To: <CAOxo6XLh2eew1SkAkCShcPhXF3BCCWriPmy-atbZpb11h_0FjQ@mail.gmail.com>
References: <CAOxo6XJUTj4QT87MJeqPj79+YLiLKeuVoysXe6SLWNU=2zrbrQ@mail.gmail.com>
	<CAOxo6XLh2eew1SkAkCShcPhXF3BCCWriPmy-atbZpb11h_0FjQ@mail.gmail.com>

On Wed, 13 Mar 2024 at 20:42, David Christensen
<[email protected]> wrote:
>
> Here is a version 2 of this patch, rebased atop 97d85be365.
>
> As before, this is a cleanup/prerequisite patch series for the page
> features/reserved page size patches[1].  (Said patch series is going
> to be updated shortly.)
>
> This splits each of the 4 constants that care about page size into
> Cluster-specific and -Limit variants, the first intended to become a
> variable in time, and the second being the maximum value such a
> variable may take (largely used for static
> allocations).
>
> Since these patches define these symbols to have the same values they
> previously had, there are no changes in functionality.  These were
> largely mechanical changes, and as such we should perhaps consider
> making the same changes to back-branches to make it so context lines
> and the like
> would be the same, simplifying maintainer's efforts when applying code
> in back branches that touch similar areas.
>
> The script I have to make these changes is simple, and could be run
> against the back branches with only the comments surrounding Calc()
> pieces needing
> to be adjusted once.
>
> Thanks,
>
> David
>
> [1] https://commitfest.postgresql.org/47/3986/

Hi! Your patchset needs a rebase. Are you going to push it forward?

Also, It is better to have more informative commit messages in patches.
-- 
Best regards,
Kirill Reshke

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Constant Splitting/Refactoring
  In-Reply-To: <CALdSSPjo_bXyhB7ghP-Ms0ghjNY2OznjDN8a=aEZC3=E32NFDA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox