Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tZsNl-00DvCt-QL
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2025 14:04:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tZsNk-002El1-Df
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2025 14:04:00 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <reshkekirill@gmail.com>)
	id 1tZsNk-002Ekt-45
	for pgsql-hackers@lists.postgresql.org; Mon, 20 Jan 2025 14:04:00 +0000
Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <reshkekirill@gmail.com>)
	id 1tZsNh-000Xjv-2q
	for pgsql-hackers@lists.postgresql.org;
	Mon, 20 Jan 2025 14:04:00 +0000
Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-30615661f98so49401771fa.2
        for <pgsql-hackers@lists.postgresql.org>; Mon, 20 Jan 2025 06:03:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1737381837; x=1737986637; darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=XA3XFsN03BpfhNyg5UwGpf7Lsw8u5OA17ji039WGlUs=;
        b=MayXSFKm4n6A1NowBoyn1bzPeA4RkJ+A+X8DvN7KqTqZURhdqxDOG1hmwfpDAI9JOx
         7fnR/XhgikC8GRrTBwfDXe9uzpMtpBRtBGHCfspqH/PDLp9PVHHBBsGwaOl7Q3eE8HIc
         io9r58sHWVgwsikgqy9LWpZAMMiSo0RbbmlG3kICXrTmJFlZnbHEMYZbVHyLJ08JaKc8
         C6NCWuF0UkvweICxNSjnRMtxFHKkVBNgWaaW2AiWdd3Z56h57Y0CRklL4CLjvtSEfNKg
         6cWB5ruSOKmXgl9z18HtKUdyPq3TJSVd2WziLOqUETqYYybeAvBd7NDzh3HaZxyT0uD5
         yJtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1737381837; x=1737986637;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=XA3XFsN03BpfhNyg5UwGpf7Lsw8u5OA17ji039WGlUs=;
        b=bwzkJdZqMZimIBeW+k1HhAyPmK8DqpQEr/Eg3K92eLpYU6xVOiVcW0xosZMPYA0bt+
         BgHu3WkMa/doLWXYAU0z+zEi7mjLOuOxnp70GvLw35Z2kpCf7nk4n1RBvOWu2aO07ZDR
         0PeiLIk702MY8EQNpGhWRmdP2f+TMcXE38s1Nm6S9gnBzmdep5jiiiOU1792RFwX6Ydz
         suA0jGf7UZ9sGOF64YBB49LoHLscYAj6VJOF96sXCe9V1WSCHo6NDAwbpskhOZgXfCHY
         ahPxN4qjxz8xulU3fcePb9KJmuVkCzzB4MJ8FifHry1xej/n7wp2Jz41SD3avg54XBDP
         m0Fw==
X-Forwarded-Encrypted: i=1; AJvYcCXAX/1GsJj0imPgppeTPCqGygZ0qwoi95b6KRgJuNdI9iTg1D74Ph73qhT7pM0DjcI7MgQkg9JY37zybI/H@lists.postgresql.org
X-Gm-Message-State: AOJu0YxrOee4NSbHaSNY2BXToCkp44UpmPWGhI8eSdsT7f+vw+lLi0J5
	fj/Ptgy2S59A/VwpeRs+N5J2GazLhWRqmRGfYDW51xnPe0H9S9ZXeSecG4C6MMH2C5Q+kmv71PW
	DtuS+GL726pjM7XolfjxBtsKssp0=
X-Gm-Gg: ASbGncsZ7GnhshvQsY9vh1oYXAA4Lo0WhQ8wFBVvRMTymnwCkZEruixHQl2xSk6gm2S
	ulZvt0NZalxurD9BWWY9/6Hy7f+VeyVMv+26l88XELD3HhhkPS7Rk9IYQ2hZv37+tdVVoWA+226
	JSAl+9UQVG03JSOw==
X-Google-Smtp-Source: AGHT+IGTGXt0W5jtgJyM6g4o/QG9ucVhErGQMgwfdSArECLNVvV6OT4pH7IDXXuURPNS8v8vWdl5PFAM7XgdUreR5hg=
X-Received: by 2002:a2e:bc15:0:b0:302:3534:1fba with SMTP id
 38308e7fff4ca-3072caf0febmr41029371fa.17.1737381836729; Mon, 20 Jan 2025
 06:03:56 -0800 (PST)
MIME-Version: 1.0
References: <CAKFQuwawy1e6YR4S=j+y7pXqg_Dw1WBVrgvf=BP3d1_aSfe_+Q@mail.gmail.com>
 <CACJufxFFU92-H7G8tmpxt9oTSfL062OA7n5rPx-YbOAtDUUzGw@mail.gmail.com>
 <04bf425ad1b15a4daefe96c478a5253b@oss.nttdata.com> <CACJufxGnc+=No=Ua6NFT2ADt0vRL=m1QsuCOM=9aKPKWh9_L6Q@mail.gmail.com>
 <20240206191937.72eaf0ccc20cfea37944b422@sraoss.co.jp> <CACJufxFT9j8o5kEC8dPCQqLomWjeJm9V9m8eZjj2Gvc_F5ha=g@mail.gmail.com>
 <76da9fcc-93c5-4053-872e-12932a95356d@uni-muenster.de> <CAKFQuwaYNw8U-9JkFdyOX4i4Y3J1sp6+dk-sh8YmZGCq8gMeVQ@mail.gmail.com>
 <6eac5b45-7f45-4c7a-aae1-e90db8be2e08@uni-muenster.de> <CACJufxFFdtPKk4B5rSVNEk6yCH2Amvi_8w3Gaz5wg9M_t9c5Rw@mail.gmail.com>
 <3d6b5885-16a1-475d-b56f-41701c48d9d4@uni-muenster.de> <CACJufxEgiysa2SMJPGp0aN476Ojm636MfJK88DZC7TVYsXYBBQ@mail.gmail.com>
 <CALdSSPhgjCbyb=ZRgr4LaCFJV2-F9_CxMeX6poHuGCt_f9GYAw@mail.gmail.com>
 <63595e8f-a245-4335-aa22-7e449a70e210@oss.nttdata.com> <CALdSSPi1JE9xc31W6DPAdk-bQHeo3HNAYB-10Biruu-w4GJN0Q@mail.gmail.com>
 <07587c36-18b3-4ccb-b5fb-579bcb04ed37@oss.nttdata.com> <CALdSSPjYw5g7_sc++bRcxOnC7jW6O2qiSkgdKRUYFXZZv3-Ktw@mail.gmail.com>
 <CACJufxGsGqU0BnHw9+Vk3KhBSA3951fZs+JQnM387CiJD3Qn+g@mail.gmail.com>
 <CALdSSPh13qiKmhqwj=bR_3seZJVkP9E6BDbLfHXQ_DbaxQL4FA@mail.gmail.com>
 <CACJufxEq9aQX6ddkHeEX-RqjTZfDF02BLWGVS28ixRQQxoz0LA@mail.gmail.com>
 <CALdSSPjiR8cqPrJOjoGPvTnDufuWYj94-1whCGtGox=_QeZQEA@mail.gmail.com>
 <CACJufxEKq25CvQj4rYxcvHC_0MZQxzfwEKVWo9i-bKKxbVw3BA@mail.gmail.com>
 <CALdSSPgcuW1omVFUpnL6H63H+2qvtvEkD+4H3jUh1iEaNn_nEg@mail.gmail.com>
 <CACJufxFTvtMy_aYFQPtcBwVwJ-2=rJRVE0SBWv6efv86J5DyAQ@mail.gmail.com>
 <CALdSSPhxprTyzzr4tk-QU-GUroBKYNuJJ2GxWnExbB=bjQjJ7w@mail.gmail.com> <CACJufxHpTC-kqmW0LKNd_ZgnPJkhiAebPQkX2YE-CVxBP4LDfg@mail.gmail.com>
In-Reply-To: <CACJufxHpTC-kqmW0LKNd_ZgnPJkhiAebPQkX2YE-CVxBP4LDfg@mail.gmail.com>
From: Kirill Reshke <reshkekirill@gmail.com>
Date: Mon, 20 Jan 2025 19:03:45 +0500
X-Gm-Features: AbW1kvaYZWjqGEFMmBYzwk0inaur5cAVdoejFo5BOTi0-P4Pr1jktCCKmznpt0E
Message-ID: <CALdSSPjpi0w6US75_st_-zOdUfr5q2vXmh08x0pL4FGJGYZvsQ@mail.gmail.com>
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
To: jian he <jian.universality@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Jim Jones <jim.jones@uni-muenster.de>, 
	"David G. Johnston" <david.g.johnston@gmail.com>, Yugo NAGATA <nagata@sraoss.co.jp>, 
	torikoshia <torikoshia@oss.nttdata.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CALdSSPjpi0w6US75_st_-zOdUfr5q2vXmh08x0pL4FGJGYZvsQ%40mail.gmail.com>
Precedence: bulk

On Tue, 14 Jan 2025 at 10:51, jian he <jian.universality@gmail.com> wrote:
>
> the attached patch also did some doc enhancement, error message enhancement.

LGTM


-- 
Best regards,
Kirill Reshke