MIME-Version: 1.0
References: <CAHut+PuCznOyTqBQwjRUu-ibG-=KHyCv-0FTcWQtZUdR88umfg@mail.gmail.com>
 <CALDaNm1J-V06vNM1JBwP1OJgAQKWntJvfG8gf=3Kfnpm=bE-Yw@mail.gmail.com>
 <CAHut+PuRgxhk4GBK8Fm8hgDH=KLGvCjjOvcNXMapHgyN1bQfDA@mail.gmail.com>
 <CAA4eK1LGFhOsqLhZfiHOvgmzzO5MHJ7OgQMnOCbYp6A9Ks92WQ@mail.gmail.com>
 <CAHut+PtrD4xU4OPUB64ZK+DPDhfKn3zph=nDpEWUFFzUvMKo2w@mail.gmail.com>
 <CAD21AoBT+brpQxN4MvYzWmq=25ac=3QEwwJXfCfqaV9-_YZNYQ@mail.gmail.com> <CAHut+PsDvFvwBiSzB0bCZgMwDUfOD4dackL0ZcTHXtLuewdobA@mail.gmail.com>
In-Reply-To: <CAHut+PsDvFvwBiSzB0bCZgMwDUfOD4dackL0ZcTHXtLuewdobA@mail.gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Thu, 16 Mar 2023 10:40:05 +0530
Message-ID: <CALj2ACUUEXUaF8PeVMNWei=C9W3p7etiGxCFV_mmOtm0KmcF_w@mail.gmail.com>
Subject: Re: Add macros for ReorderBufferTXN toptxn
To: Peter Smith <smithpb2250@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, 
	vignesh C <vignesh21@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALj2ACUUEXUaF8PeVMNWei%3DC9W3p7etiGxCFV_mmOtm0KmcF_w%40mail.gmail.com>
Precedence: bulk

On Thu, Mar 16, 2023 at 7:20=E2=80=AFAM Peter Smith <smithpb2250@gmail.com>=
 wrote:
>
> PSA v4 which addresses both of your review comments.

Looks like a reasonable change to me.

A nitpick: how about using rbtxn_get_toptxn instead of an explicit
variable toptxn for single use?

1.
Change
    ReorderBufferTXN *toptxn =3D rbtxn_get_toptxn(txn);
    TestDecodingTxnData *txndata =3D toptxn->output_plugin_private;

To
    TestDecodingTxnData *txndata =3D rbtxn_get_toptxn(txn)->output_plugin_p=
rivate;

2.
Change
        ReorderBufferTXN *toptxn =3D rbtxn_get_toptxn(txn);
        toptxn->txn_flags |=3D RBTXN_HAS_STREAMABLE_CHANGE;

To
        rbtxn_get_toptxn(txn)->txn_flags |=3D RBTXN_HAS_STREAMABLE_CHANGE;

3.
Change
    /*
     * Update the total size in top level as well. This is later used to
     * compute the decoding stats.
     */
    toptxn =3D rbtxn_get_toptxn(txn);

    if (addition)
    {
        txn->size +=3D sz;
        rb->size +=3D sz;

        /* Update the total size in the top transaction. */
        toptxn->total_size +=3D sz;
    }
    else
    {
        Assert((rb->size >=3D sz) && (txn->size >=3D sz));
        txn->size -=3D sz;
        rb->size -=3D sz;

        /* Update the total size in the top transaction. */
        toptxn->total_size -=3D sz;
    }

To

    /*
     * Update the total size in top level as well. This is later used to
     * compute the decoding stats.
     */
    if (addition)
    {
        txn->size +=3D sz;
        rb->size +=3D sz;
        rbtxn_get_toptxn(txn)->total_size +=3D sz;
    }
    else
    {
        Assert((rb->size >=3D sz) && (txn->size >=3D sz));
        txn->size -=3D sz;
        rb->size -=3D sz;
        rbtxn_get_toptxn(txn)->total_size -=3D sz;
    }

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com