MIME-Version: 1.0
References: <CALj2ACUmL5TraYBUBqDZBi1C+Re8_=SekqGYqYprj_W8wygQ8w@mail.gmail.com>
 <772E8FE1-B1F7-4472-A132-06498B9D6907@yesql.se> <20240212204613.GA1815134@nathanxps13>
 <A8288D74-01B8-4EC9-BC9F-48916F2BE7A2@yesql.se>
In-Reply-To: <A8288D74-01B8-4EC9-BC9F-48916F2BE7A2@yesql.se>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Tue, 13 Feb 2024 03:01:39 +0530
Message-ID: <CALj2ACU_duFZ2eOyWSxXo3rXjwhvGuKD0HFDo4EbXh3_gtkqhQ@mail.gmail.com>
Subject: Re: Fix a typo in pg_rotate_logfile
To: Daniel Gustafsson <daniel@yesql.se>, dpage@pgadmin.org
Cc: Nathan Bossart <nathandbossart@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALj2ACU_duFZ2eOyWSxXo3rXjwhvGuKD0HFDo4EbXh3_gtkqhQ%40mail.gmail.com>
Precedence: bulk

On Tue, Feb 13, 2024 at 2:29=E2=80=AFAM Daniel Gustafsson <daniel@yesql.se>=
 wrote:
>
> On that note though, we might want to consider just dropping it altogethe=
r in
> v17 (while fixing the incorrect hint in backbranches)?  I can't imagine
> adminpack 1.0 being in heavy use today, and skimming pgAdmin code it seem=
s it's
> only used in pgAdmin3 and not 4. Maybe it's time to simply drop old code?

https://codesearch.debian.net/search?q=3Dpg_logfile_rotate&literal=3D1
shows no users for it though. There's pgadmin3 using it
https://github.com/search?q=3Drepo%3Apgadmin-org%2Fpgadmin3%20pg_logfile_ro=
tate&type=3Dcode,
however the repo is archived. Surprisingly, core has to maintain the
old code needed for adminpack 1.0 - pg_rotate_logfile_old SQL function
and pg_rotate_logfile function in signalfuncs.c. These things could
have been moved to adminpack.c back then and pointed CREATE FUNCTION
pg_catalog.pg_logfile_rotate() to use it from adminpack.c. If we
decide to remove adminpack 1.0 version completely, the 1.0 functions
pg_file_read, pg_file_length and pg_logfile_rotate will also go away
making adminpack code simpler.

Having said that, it's good to hear from others, preferably from
pgadmin developers - added Dave Page (dpage@pgadmin.org) in here for
inputs.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com