MIME-Version: 1.0
References: <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru>
 <1e81a0a1-a63b-48fb-905a-d6495f89ab73@postgrespro.ru>
 <0b4eefc7-4c38-4caa-b2ca-a4c75dd7dd12@postgrespro.ru>
 <CAPpHfduoJEuoixPTTg2tjhnXqrdobuMaQGxriqxJ9TjN1uxOuA@mail.gmail.com>
 <fb8f05ad-096a-4865-9beb-08d4460222bb@postgrespro.ru>
 <333c2306-c401-4959-9f0c-a44c670a11a9@postgrespro.ru>
 <513f0188-b093-4cc8-98cf-4c324570d525@postgrespro.ru>
 <47a7b784-5218-43f2-96e3-65f9a729c5a5@tantorlabs.com>
 <d78a21c5-68ae-45b8-82a8-60f391b89d43@postgrespro.ru>
 <CAMFBP2oXkhX_k9FTqtW-LdTBepVq0PDuBEGO8-LpNGbyHTBrNw@mail.gmail.com>
 <Z9J+cRHwpBt4cQv3@ip-10-97-1-34.eu-west-3.compute.internal>
 <e66086a1-641a-4758-b3fc-5e92c74c9239@postgrespro.ru>
 <5583261b-eede-4341-b3b1-91650fefc1cf@postgrespro.ru>
 <2a04ad18-5572-4633-848b-eb57209e7ac0@postgrespro.ru>
 <CAA4eK1JOUn+EqWSfRgKfgBZOXT7Q2dw2enmSZZgOhoMOFwopPA@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1JOUn+EqWSfRgKfgBZOXT7Q2dw2enmSZZgOhoMOFwopPA@mail.gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Wed, 24 Sep 2025 17:03:08 -0700
Message-ID: 
 <CALj2ACUmJiH1PszZvXHsqTvGcGW_=4W=3gOT5_q=sXsxxB=k=A@mail.gmail.com>
Subject: Re: Vacuum statistics
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>,
 Alexander Korotkov <aekorotkov@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>, Jim Nasby <jnasby@upgrade.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>,
 Kirill Reshke <reshkekirill@gmail.com>,
	Andrei Zubkov <zubkov@moonset.ru>, Masahiko Sawada <sawada.mshk@gmail.com>,
	Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>,
	a.lepikhov@postgrespro.ru, Sami Imseih <samimseih@gmail.com>,
	vignesh C <vignesh21@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACUmJiH1PszZvXHsqTvGcGW_%3D4W%3D3gOT5_q%3DsXsxxB%3Dk%3DA%40mail.gmail.com>
Precedence: bulk

Hi,

On Mon, May 12, 2025 at 5:30=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
>
> On Fri, May 9, 2025 at 5:34=E2=80=AFPM Alena Rybakina <a.rybakina@postgre=
spro.ru> wrote:
> >
> > I did a rebase and finished the part with storing statistics separately=
 from the relation statistics - now it is possible to disable the collectio=
n of statistics for relationsh using gucs and
> > this allows us to solve the problem with the memory consumed.
> >
>
> I think this patch is trying to collect data similar to what we do for
> pg_stat_statements for SQL statements. So, can't we follow a similar
> idea such that these additional statistics will be collected once some
> external module like pg_stat_statements is enabled? That module should
> be responsible for accumulating and resetting the data, so we won't
> have this memory consumption issue.
>
> BTW, how will these new statistics be used to autotune a vacuum? And
> do we need all the statistics proposed by this patch?

Thanks for working on this. I agree with the general idea of having
minimal changes to the core. I think a simple approach would be to
have a hook in heap_vacuum_rel at the end, where vacuum stats are
prepared in a buffer for emitting LOG messages. External modules can
then handle storing, rotating, interpreting, aggregating (per
relation/per database), and exposing the stats to end-users via SQL.
The core can define a common data structure, fill it, and send it to
external modules. I haven't had a chance to read the whole thread or
review the patches; I'm sure this has been discussed.

--=20
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com