Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZcyl-005Yep-4z for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:32:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rZcyk-00CysS-71 for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:32:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZcyj-00CysK-U2 for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:32:37 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rZcyh-006rmF-7U for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:32:37 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2d0aabed735so48514821fa.0 for ; Mon, 12 Feb 2024 12:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707769954; x=1708374754; darn=lists.postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=X6pshzWbYOJmxk1yvzRZGndVYqBKI/Cwr4fsD/X/zww=; b=hKmzEcNagO3dB6ASbCrabtJjTUkHCTf4Qi6t8eGABsP6BCn5W+BHeX7VQglROHVmfE Nr4BOtU7Bf82WAsT8WGjTXHA11OntDxTobfSoYYS4Vk6kcARHB6rfUXuyvT66obWZLYr GXpgBejjwplhhDnjKax/Pgwxy2wq2MuFnapi7Q0gUui7AiQNjqmbOkwGab7ZsCol5jCv 5Zhfdf5tvBVQo3DR4JFz3w1LX0eM2acyIFy2JUDEhJMwGLcP47CStSuEYDrIQCaTIPRK 4rVQyt80QxqxRWU8/EzVPK9WmOZKwJCOdt0efgWyoiFmshm4mDckD3mkqIouqPxxS6Mm HEsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707769954; x=1708374754; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=X6pshzWbYOJmxk1yvzRZGndVYqBKI/Cwr4fsD/X/zww=; b=Jqx91BQA+NnwfWS9VrAsRVQWRaBlJ1kdOl0AxvX+Kxj+ZEibhE2lCg0kDLX+feoaxv 38StoMhWrCx2cwfhEVBtY4ymZAPR2HAjWeGvo7hTFYoVStGH2jwSkBx5dJE9l21We/YB XQ0fo7JO1iycrp+sH9Mxdwb/dXA7jvPylGzXcDAneMWygT+cxN+UbhMEZnfrbLXxzBI5 31kfeTWBc8lY57Hcg/6W8zevncRiM5HOm2sFbCnMbmtDaPcMZFeSlqAF3Tv2I1XVNrsz 5QdMpRdsETuDY4XPaUSxLpxZ0Jcrhvj3MPkY+o21c+b2fvdApCQePV64LpOwMj2pXxQy wgoQ== X-Gm-Message-State: AOJu0YyFmy8y4ryUL7ZWkTDpxgkc8Hp9Ku96L/3pqwmYf6dKeyjnAiNA /+8S0BBnMVWAin2PJQqmTwn2xkH8qys4t9G9K33SRllu7W9HmzbQidzWPfFSj+sv4QIdbr/dZ3/ ew+AssuPddgTePrGnXIVa4FZiriGo8p8u X-Google-Smtp-Source: AGHT+IG3cvwJlvAuVZi39zJO6ViUBRGfedPtThkdnQ7cOJxQWzocgRUTXHKFnCIRZEn//O9mtR4Hdw8jGljOzTvUbQ0= X-Received: by 2002:a2e:b5a7:0:b0:2d0:a249:c04 with SMTP id f7-20020a2eb5a7000000b002d0a2490c04mr4708816ljn.51.1707769954080; Mon, 12 Feb 2024 12:32:34 -0800 (PST) MIME-Version: 1.0 From: Bharath Rupireddy Date: Tue, 13 Feb 2024 02:02:21 +0530 Message-ID: Subject: Fix a typo in pg_rotate_logfile To: PostgreSQL Hackers Content-Type: multipart/mixed; boundary="00000000000078b3cb0611352d2b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000078b3cb0611352d2b Content-Type: text/plain; charset="UTF-8" Hi, I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c - the hint message wrongly mentions that pg_logfile_rotate is part of the core; which is actually not. pg_logfile_rotate is an adminpack's 1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile SQL function instead, so use that. Here's a patch to fix the typo. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --00000000000078b3cb0611352d2b Content-Type: application/x-patch; name="v1-0001-Fix-a-typo-in-pg_rotate_logfile.patch" Content-Disposition: attachment; filename="v1-0001-Fix-a-typo-in-pg_rotate_logfile.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsiz2w0x0 RnJvbSAxODg1NGJhMzQxZDg5Mjc1MGZjNzViOTk4OGJhMTA3ZmU0NGU3YzYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGFyYXRoIFJ1cGlyZWRkeSA8YmhhcmF0aC5ydXBpcmVkZHlm b3Jwb3N0Z3Jlc0BnbWFpbC5jb20+CkRhdGU6IE1vbiwgMTIgRmViIDIwMjQgMTM6MzA6MzEgKzAw MDAKU3ViamVjdDogW1BBVENIIHYxXSBGaXggYSB0eXBvIGluIHBnX3JvdGF0ZV9sb2dmaWxlCgot LS0KIHNyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3NpZ25hbGZ1bmNzLmMgfCAyICstCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMv YmFja2VuZC9zdG9yYWdlL2lwYy9zaWduYWxmdW5jcy5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9p cGMvc2lnbmFsZnVuY3MuYwppbmRleCA4MWQxYTU5NjU5Li5jMDVhMmFmNDhiIDEwMDY0NAotLS0g YS9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9zaWduYWxmdW5jcy5jCisrKyBiL3NyYy9iYWNrZW5k L3N0b3JhZ2UvaXBjL3NpZ25hbGZ1bmNzLmMKQEAgLTI4NCw3ICsyODQsNyBAQCBwZ19yb3RhdGVf bG9nZmlsZShQR19GVU5DVElPTl9BUkdTKQogCQkJCSBlcnJtc2coIm11c3QgYmUgc3VwZXJ1c2Vy IHRvIHJvdGF0ZSBsb2cgZmlsZXMgd2l0aCBhZG1pbnBhY2sgMS4wIiksCiAJCS8qIHRyYW5zbGF0 b3I6ICVzIGlzIGEgU1FMIGZ1bmN0aW9uIG5hbWUgKi8KIAkJCQkgZXJyaGludCgiQ29uc2lkZXIg dXNpbmcgJXMsIHdoaWNoIGlzIHBhcnQgb2YgY29yZSwgaW5zdGVhZC4iLAotCQkJCQkJICJwZ19s b2dmaWxlX3JvdGF0ZSgpIikpKTsKKwkJCQkJCSAicGdfcm90YXRlX2xvZ2ZpbGUoKSIpKSk7CiAK IAlpZiAoIUxvZ2dpbmdfY29sbGVjdG9yKQogCXsKLS0gCjIuMzQuMQoK --00000000000078b3cb0611352d2b--