MIME-Version: 1.0
References: 
 <CALj2ACWd5apddj6Cd885WwJ6LquYu_G81C4GoR4xSoDV1x-FEA@mail.gmail.com>
 <b5eab65a-e11b-6435-b6aa-dac206e17d38@gmail.com>
 <CAHGQGwFBnBQZbt4e9qjZoiM0GW2eXCvS=Ny5wt+s1-+iJpK15A@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwFBnBQZbt4e9qjZoiM0GW2eXCvS=Ny5wt+s1-+iJpK15A@mail.gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Sun, 29 Mar 2026 18:30:00 -0700
Message-ID: 
 <CALj2ACV6a64cqQksb-0nga886dZyu-G8zhPwpqn23JEV=uUgCw@mail.gmail.com>
Subject: Re: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler()
To: Fujii Masao <masao.fujii@gmail.com>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACV6a64cqQksb-0nga886dZyu-G8zhPwpqn23JEV%3DuUgCw%40mail.gmail.com>
Precedence: bulk

Hi,

On Sun, Mar 29, 2026 at 5:30=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
>
> While reviewing the patch in [1], I noticed this issue and ended up here.
> I agree with the approach and have attached a revised version of the patc=
h.

Thank you for reviving this patch.

> I understand the concern. There's no guarantee that PostgreSQL functions
> behave identically across major versions, so removing redundant SetLatch(=
)
> calls is generally fine. However, as you are concerned, extensions might =
call
> these functions and implicitly rely on the extra SetLatch(). Since the pa=
tch
> doesn't change the API, such behavioral changes may be hard for extension
> authors to notice. Also they will be not in release notes. In practice,
> they would probably catch this during testing against a new major version=
,
> though.

I'm still +1 for removing these redundant SetLatch calls from the
multiplexed SIGUSR1 handlers. It not only keeps the signal handlers
consistent but also avoids an additional function call and memory
barrier from within the signal handler (a micro optimization).

I reviewed the v2 patch and it looks good to me.

--=20
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com