Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9a4e-001YhZ-1e for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 02:52:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w9a4d-0069pr-07 for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 02:52:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9a4c-0069pj-2R for pgsql-hackers@lists.postgresql.org; Mon, 06 Apr 2026 02:52:23 +0000 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w9a4a-00000000peT-2Alo for pgsql-hackers@postgresql.org; Mon, 06 Apr 2026 02:52:22 +0000 Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-7d9b1c57a4cso2986696a34.3 for ; Sun, 05 Apr 2026 19:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775443939; cv=none; d=google.com; s=arc-20240605; b=iBsIez64iW3y2NXOLySU8PbGfkw3hAnYOr8XAZ42WeAjEGZB+kMSxfl2dZIr2BNCDO 0v8XjiVF3UN9OlGo5C42WJHUORVFf74ExTS77+4KYBUy/LYvf/ZIJsN7WLFwMEeCNrob oPNNw4zfW5cgZwYuhcXyVTLghnYexZmkLGSvt2Q3fkSfh9Wacw1b+liTMJ1/5osTgEbX LeM07jOrDpupz6nWdZvFocL0SGP29am6EGoCd684DVWwOpq98NsuhBHg7jIoo8UCTiJn 8cC9BnSN97HtXFwhAauHHL/ziqnfBfOF5BiylS4JS5EsSw5/GLNdKBxxHhU3LpcAVfjj 9nPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=OrE8HiOEVqWmcODGq1ctZiKndus8J/JP2KfPAThqoEU=; fh=pXlKH8oQfkt4Q9OOIbN2Pa+gWf3jL6UQaVfRveP+SWc=; b=ZaJ08Pbrlaj3TBpoEASYIEBkzlwipwjdfbjcXW2xDmVF+geoFfdnFkmXy1USGID/OC 4ASRBNNtCD9LYBICqHzs912aoWvxS9xPG2KZrulc7cbWxqGo4W4cGnkaFUtS7gCYDgt7 qVatmv44EzyOGNQWyMmIOWMsA2sDwdyUljOmrwxh+u2pbNj7TZpPjbM4eootXg6U1lyY /7zrqOIPXmZ8f/4fXwaWRxM4Z0YJYIOe/U6Vb3i7feenu+Fq3sXQYrWsnjJeQ8lLiWwl vGLcxIioVEztM/+ZPa7Jk2fGS8xoy/8bqeEehQBWA7d5YAaexebZYNpL3B5b+aPKDs3I QWfA==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775443939; x=1776048739; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OrE8HiOEVqWmcODGq1ctZiKndus8J/JP2KfPAThqoEU=; b=pz0EYpzPWTCKGCXarIyOdVFMkw8OynE6ZewHvNd1xqD5QaLOY1GKAUAOFZFj38raEG mMC8axjeeLDCjqeXdZHfGWTLBs76ZxP+SDb5GUQU3TrOALvjPwa8ne6l/wLV+qDhtXvE DVpjkeiZXibw/AWJLSlHbkY5D9LsF/ZoxgXavonNogMP8XJphAK5Jk9KYZWclBr8Vewa Khy/lJiaJgfPDc145pLj0ONnGKpDbbhAB/Tk9j/+SA4YOt8s3EqhxL63g6TfSvVJvHuQ MpLgqwSlP2qXUSZHPiMr2sYhgdOKUZSDTGh8ZaXncGz9x8EVSnuHcQDUfuSqvtVaPgBt lagw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775443939; x=1776048739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OrE8HiOEVqWmcODGq1ctZiKndus8J/JP2KfPAThqoEU=; b=BKly9PPWY+A3kfwXE9XPDQaO9BGphqq0vC82EFFZC3kb6ON8bm/UkYTQW4SLD7K65Q CamvJaxhyL8g62ZmsyVNkr1X6+p2JrlUrGTVyW2aucmCZ0QDEOzaydIN5O4s0HSWCcZU ynUbTi/a8gMndJOuAWYpES9BuWRMW5P9j5ov/0gU1ap0vnIfu1uNa1NSNBr8WoPvPECi iuWWMg0ZFdjXG9PJBpRpiK7xBBw2l1nI+BqgxkPgHyXTjzu0qeFqpGhCKlQgcIz6VR1a 8oDi+v/O9MrI4NuN4kb+lbP6bUAoDfrlsRyUWVuQMFxLqmEAdeR55EJZnRNPfjkjntaN cHxw== X-Forwarded-Encrypted: i=1; AJvYcCUEPoBvPwR6Km2eWx77R0HYR9H5CTqmYYbu6VjDVKnBNIZDd18Gsip6V4CM9YwcGJyG1knW8OLpXDQAxWj7@postgresql.org X-Gm-Message-State: AOJu0YxYcDsYwTE8eYFHUbfJqL9qHyupQ8xvDh+XhsC+PRl9khPrW3Uq 3QZSeYJsV45aP92gS7gvRcrP4HzA0gxUgVsFRBN92NxVx8DfNN1Zg6g5VayTofVwof0aKfjwv6j 3wQJW0cIjtwI4jngKS4i6SVi7S+xrwBk= X-Gm-Gg: AeBDieuTrsm35V5YYzesnn2RlvWgodCgiw6942vbpi68xKzFsB2X4my7fYHRhy86fQv ZrE2DTcNf4eQQApz8WIdT1IEYV/XnY7aZc7I+BixCkXcjqS6qcwXalt+tLbtOf72cF1dIW5Jns8 oY0QQRBhymJTFT6JpEV92/z2NYZ0En/4Sk8Z1hAiFDaJlbbMGuwMac9IGJxdEUR+gxxOemHqRkZ jyQiDnGXWpM0G2tWcNU0HeG8r5JmUhezbg9j/h7eUsJtRUc4TKziifstkfrqqqtaf9pyvOkkW76 XuhXLa032zEvj6CvMS667yC7cbAYJscCTT2CXMQN X-Received: by 2002:a05:6820:184c:b0:67e:294b:7246 with SMTP id 006d021491bc7-6821cd3c0abmr5349217eaf.14.1775443938757; Sun, 05 Apr 2026 19:52:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bharath Rupireddy Date: Sun, 5 Apr 2026 19:52:07 -0700 X-Gm-Features: AQROBzD4YGeJ3nr8rJR-8BtK1wTn3ws0AlT-SKztdOG50V0XyNQ8WsJtxbZk9Xg Message-ID: Subject: Re: Introduce XID age based replication slot invalidation To: Masahiko Sawada Cc: Srinath Reddy Sadipiralla , SATYANARAYANA NARLAPURAM , "Hayato Kuroda (Fujitsu)" , John H , PostgreSQL-development Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Sun, Apr 5, 2026 at 1:03=E2=80=AFAM Masahiko Sawada wrote: > > Thank you for updating the patch! > > I've made some changes including moving MaybeInvalidateXidAgedSlot() > to vacuum.c since the function seems more inherently tied to vacuum > context. Also, updated the commit message and fixed typos. > > Please review the attached patch. Thank you Sawada-san! I took a look at the v10 patch and it LGTM. I tested it - make check-world passes, pgindent doesn't complain. -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com