Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ8ix-0005TH-Dq for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Oct 2020 12:39:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kQ8iw-0005GN-CF for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Oct 2020 12:39:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ8iw-0005GG-5o for pgsql-hackers@lists.postgresql.org; Wed, 07 Oct 2020 12:39:14 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kQ8it-0002Yy-I8 for pgsql-hackers@postgresql.org; Wed, 07 Oct 2020 12:39:13 +0000 Received: by mail-ed1-x542.google.com with SMTP id dn5so1976808edb.10 for ; Wed, 07 Oct 2020 05:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=akHcHL9J5EfFUoFYHX0XWJwsFygiuIIXL9VK3/046jY=; b=PNNjhcHWvnydkdGhHlJKKrzG4AtoMxbrocjbv4xuBcw6NPyHsYhvoVj5Ve7fuh+KaK H5Y3ivIFhoaGqiQucFgDOjWrHvSBsY8HqB9H4kL/Q+xbRmQZSge4bAz+NdE60xQx/DSo 19z8jdYwD+DH0gPs4lvtai9wN920i/fWg1gQUML1cLMRXGsyS2aLn9FnjwwHpK1cyMAe ILNJCOnXf03VaBHKyfU40mENpWlVeg1c41pbWL8iWLJw4eOjTLkjnl4LUPe6OedGFPqV +P2UfM1a0Gbl+LnnGZ166mvUSAIe07TpGFYZ/ohzNLcI2UDI3Xk+fZtLAHOyVf41h40g P3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=akHcHL9J5EfFUoFYHX0XWJwsFygiuIIXL9VK3/046jY=; b=SgH0Eq4QnkqXpADK5OI4JN949quxeA4Qx7f20MwFa5buWNyYoFKiYRIqo+TOtMSSW/ hNDJA0wT5Ew3hYklpGxvahBW+vO3vCsox74AgrIDykB7F+k9i4WILyM1QuWCRXdJkA1D zzuEIHRmIbmY/iV+r+FWc+rR07CnU1cjdh95XTOA/mz9xPDY//vDp9cQHQ10Xad4auEa XZ8kPrLnYFGtm8ikjENrqfcPo5+HbKfwa4oDS2Yyd8djF0nBWHhk7909aqWGRjAcvxvr aJckfwf27GRJGQWbjtOqScea6RiBp9/TYhWKR0kfrIWWp0ChQmsRzTROtObX2sIiq1Gu UMEg== X-Gm-Message-State: AOAM533IQxN5suoR4P05/7xB/EepynoZDqBI58z0TC+/BZaQu+kKhGhv /BPdDijRzXJX5LeawUoNZK91v8A2cCwIxsXzzoeqp4+9 X-Google-Smtp-Source: ABdhPJwsffc0HdfVCl/N2zC0CdbLX4ak/977/8mNK0AkG5UorOU8pltDI+/XE+HE/oDJT8g8unI4kNVjArvQwIKmYJk= X-Received: by 2002:a50:8b62:: with SMTP id l89mr3465387edl.132.1602074350235; Wed, 07 Oct 2020 05:39:10 -0700 (PDT) MIME-Version: 1.0 References: <13156732-5189-af54-3d28-e2ee2a8568e0@oss.nttdata.com> <069fb3bc-3907-4d85-19fd-e4b2d2f004b4@oss.nttdata.com> In-Reply-To: From: Bharath Rupireddy Date: Wed, 7 Oct 2020 18:08:58 +0530 Message-ID: Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module To: Fujii Masao Cc: PostgreSQL-development Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Oct 7, 2020 at 8:00 AM Bharath Rupireddy wrote: > > On Tue, Oct 6, 2020 at 11:41 AM Bharath Rupireddy > wrote: > > > > On Tue, Oct 6, 2020 at 11:20 AM Fujii Masao wrote: > > > > > > +1 Or it's also ok to make each patch separately. > > > Anyway, thanks! > > > > > > > Thanks. +1 to have separate patches. I will post two separate patches > > for autoprewarm and WalRcvShutdownHandler for further review. The > > other two patches can be for startup.c and syslogger.c. > > > > I'm attaching all the 4 patches here together. > > 1. v1-use-standard-SIGHUP-and-SIGTERM-handlers-in-autoprewarm-process.patch > -- This is the patch initially sent in this mail by me, I just > renamed it. > 2. v1-use-MyLatch-and-standard-SIGHUP-handler-in-startup-process.patch > -- This is the patch proposed by Fuji Masao, I just renamed it. > 3. v1-use-standard-SIGHUP-hanlder-in-syslogger-process.patch > 4. v1-use-standard-SIGTERM-handler-in-walreceiver-process.patch > > Please consider these patches for further review. > Added this to the commitfest for further review. https://commitfest.postgresql.org/30/2756/ With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com