Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snjLv-005ftq-2Z for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Sep 2024 18:43:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1snjLu-00Gwe2-LM for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Sep 2024 18:43:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snjLu-00Gwdt-BU for pgsql-hackers@lists.postgresql.org; Mon, 09 Sep 2024 18:43:06 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1snjLq-000LcL-Js for pgsql-hackers@lists.postgresql.org; Mon, 09 Sep 2024 18:43:05 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2f74b6e1810so41188691fa.2 for ; Mon, 09 Sep 2024 11:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725907383; x=1726512183; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WHn6yiUzx9RlJLDQ88TDEjADcZS0OnhKkIxcEHLAFh0=; b=ADTImvpe5eTpx0XEOef3BaaYmqyulz93GpTYagYrP9f7+7hCPwwsz/4NpKQh9OO/yT qCST0cni8TiMvU5SzboO8+eySSqhaYTZu//dMbyrX7lqSp5zhwbAxK5BBbqdzqnDzXyc aKA9dp0MBU63naIptn6TsFkglB4WzCRjOt+Cgk2aDYY796DE8s+dyrVK+j7R0k/dgboP S9eq7eosUXSNv7V9VnMt9mVW+ZJGiry7RMe7aRZOXAQeujOyI/AiK3GJQpTbaEx8KjZL Y+peqIeXQqUaJ+WuVRS53y8nNSj76JBdfHFCh41X1a4LwCxMesnhBI/QQHkT2yioCyYY EyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725907383; x=1726512183; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WHn6yiUzx9RlJLDQ88TDEjADcZS0OnhKkIxcEHLAFh0=; b=EBVe5jhz7gx8BZNBvRfqjQDhJVyj/jQZtuNdn8Yc28wnKervw8+klMJH1GkDDAfCui zue6Dq+YCZx/DDLROPEDhc/3vvT5hDkjQS9Sn59P4ddWiWnnuKljuBAYfWl/L16TJGaa 5u+VmreAXlCyjOD4IqHOq/wKdg2Hq1gh7blvYXuXV/sHeELpIsawWJ5cXf1f+W2hiDD9 Vd5js+8WyrrtUNMtWAMHzE6BekAeiMC54k5BQ7xzi4gqPOIDalao3RSt1CjnRVpD6TlM J5RI+JK7dEmp7R6G1CjWlRHhvyJc2YghVGgzRvDjZGGMl5RxZiKN4niyLpupt33M4bVH UvHw== X-Forwarded-Encrypted: i=1; AJvYcCXB1PoIhPUWJp3vyuW54WxPZwTvEjF5cWo4sktkE78FzYMe7SoQjHZ1SUzo2zzGg7DmN333a+MNZWG6hots@lists.postgresql.org X-Gm-Message-State: AOJu0YzslY6dAJOW+mJ+rMXbJqnqXEwAfR2JHbbb5aw9Ga8/12SoSybU 1ZTYl89QyZCIGOt4QcySweLByHdI9Lm5A0WR15o4RgxZ0buTKqH75gN3HQATNMA2z7nDQmRSi02 qwrmEFCsko4Yo+uqm75J8UUjORU1c8GtO X-Google-Smtp-Source: AGHT+IH8MdBI1eZF5TwktXgbR1nki05smq90CQGh3iaPKewvMj/bkzhHHe7xuAsOaknIwxq4nJ2Zgqx5vm/zugxD01E= X-Received: by 2002:a2e:b8c7:0:b0:2f3:ed84:9e66 with SMTP id 38308e7fff4ca-2f751ec990emr87598711fa.13.1725907382980; Mon, 09 Sep 2024 11:43:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bharath Rupireddy Date: Tue, 10 Sep 2024 00:12:50 +0530 Message-ID: Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation To: Amit Kapila Cc: shveta malik , Peter Smith , Ajin Cherian , Bertrand Drouvot , Masahiko Sawada , Nathan Bossart , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Mon, Sep 9, 2024 at 3:04=E2=80=AFPM Amit Kapila wrote: > > > > > > We should not allow the invalid replication slot to be altered > > > > > irrespective of the reason unless there is any benefit. > > > > > > > > Okay, then I think we need to change the existing behaviour of the > > > > other invalidation causes which still allow alter-slot. > > > > > > +1. Perhaps, track it in a separate thread? > > > > I think so. It does not come under the scope of this thread. > > It makes sense to me as well. But let's go ahead and get that sorted out = first. Moved the discussion to new thread - https://www.postgresql.org/message-id/CALj2ACW4fSOMiKjQ3%3D2NVBMTZRTG8Ujg6j= sK9z3EvOtvA4vzKQ%40mail.gmail.com. Please have a look. --=20 Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com