Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6OKo-0003Je-H7 for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 04:30:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q6OKn-0007R8-AC for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Jun 2023 04:30:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6OKm-0007Qz-UU for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 04:30:17 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q6OKk-000VaR-3b for pgsql-hackers@lists.postgresql.org; Tue, 06 Jun 2023 04:30:16 +0000 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b1c910ee19so25459521fa.3 for ; Mon, 05 Jun 2023 21:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686025812; x=1688617812; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hqtvRr6vD3G9sXXgIwNqFw2x7ENebmB6CK+VsktiD4U=; b=gGVavb4IeVDRjGj1weg+F8LgfUOAUF0HbgqdsHX9x33HmvS4/fBX92wQZNNvVelm49 jr6hgS4OrKfheam0bACeu1i3ysf0eDjsgI2TZNYc6XLZ8OhprG21yAmh+3/4GBOVKu4Y TuVhyWcuF8TOaSmzRuoj8oiKsqlUJug//pkYsYBvSMCn34FJ8OFzgCQRZbZyv44nDS8k Qy4HJOC9ztv6XcRJy7l5y4tNqCLxYDKwFVn+sWaMdiopqT5adBpbNQHM8gBCFD0XaNTW q4Bn8TfaueonuKPY2137M/UfI1UCgOhnde2x7wKCearcGob0YO++7sHQ+tNpNRKJWJ49 Dx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686025812; x=1688617812; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hqtvRr6vD3G9sXXgIwNqFw2x7ENebmB6CK+VsktiD4U=; b=a5Y/rIlZ0x4G8imlzC4SRi9aWrX+bXbUCZoMQ4ALlgp4grGMNC/ydffl7RrVFeJL4j bVCmrBLN0FY0EKgGthE+aRmiYIZpquRpeDdRxl9PBIbAMnej60LBDH383Imhwv4lc8pG IGObGarsG6cBgzfbSfzpVOY2y0zniXnva/i1WZgQOOHgt0RMWI3Yg8dk5k3Fe28DNLSo FNZBaGbdTV3ui6XerCiuvtuAZyc4ru9LLkTuzKxbbCEeDAPhMKr8CgqCIxEEEQh+wDqK AwMBAOFDUnbAsC8gl0+AlsQJ1frZxINeoGz6hO8gXCOR/XK3pFlTcU4y5enECtfATYNc kEsA== X-Gm-Message-State: AC+VfDw5niIlXW2g+AoqDPXvjYmMrwvI+frWOitsahcqwnYO7bNcgvcW 00Ioe0zhuCMbACbhJzfVWBFev9VpJoas7epO9vY= X-Google-Smtp-Source: ACHHUZ5ISyrla2oSqC6XdUXJjXC4VnL4D9AdVo2xtx3qhLIIrS4kydL2oBZrCzpFYQVrYTqJ5H+Xx34sd4W2+Tt7FXE= X-Received: by 2002:a2e:6a17:0:b0:2ae:df5a:9651 with SMTP id f23-20020a2e6a17000000b002aedf5a9651mr567440ljc.37.1686025812334; Mon, 05 Jun 2023 21:30:12 -0700 (PDT) MIME-Version: 1.0 References: <87cz2otiw3.fsf@wibble.ilmari.org> In-Reply-To: From: Bharath Rupireddy Date: Tue, 6 Jun 2023 10:00:00 +0530 Message-ID: Subject: Re: Implement generalized sub routine find_in_log for tap test To: vignesh C Cc: Michael Paquier , Andrew Dunstan , =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jun 5, 2023 at 9:39=E2=80=AFPM vignesh C wrot= e: > > On Sun, 4 Jun 2023 at 03:51, Michael Paquier wrote: > > > > This looks like a typo to me, the log offset is eaten. > > > > Except of that, I am on board with log_contains(). > > Thanks for fixing this. +1 for deduplicating find_in_log. How about deduplicating advance_wal too so that 019_replslot_limit.pl, 033_replay_tsp_drops.pl, 035_standby_logical_decoding.pl and 001_stream_rep.pl can benefit immediately? FWIW, a previous discussion related to this is here https://www.postgresql.org/message-id/flat/CALj2ACVUcXtLgHRPbx28ZQQyRM6j%2B= eSH3jNUALr2pJ4%2Bf%3DHRGA%40mail.gmail.com. --=20 Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com