MIME-Version: 1.0
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Tue, 10 Sep 2024 00:11:01 +0530
Message-ID: <CALj2ACW4fSOMiKjQ3=2NVBMTZRTG8Ujg6jsK9z3EvOtvA4vzKQ@mail.gmail.com>
Subject: Disallow altering invalidated replication slots
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000009b7940621b41a5d"
Archived-At: <https://www.postgresql.org/message-id/CALj2ACW4fSOMiKjQ3%3D2NVBMTZRTG8Ujg6jsK9z3EvOtvA4vzKQ%40mail.gmail.com>
Precedence: bulk

--00000000000009b7940621b41a5d
Content-Type: text/plain; charset="UTF-8"

Hi,

ALTER_REPLICATION_SLOT on invalidated replication slots is unnecessary
as there is no way to get the invalidated (logical) slot to work.
Please find the patch to add an error in such cases. Relevant
discussion is at [1].

Thoughts?

[1] https://www.postgresql.org/message-id/CAA4eK1%2Bszcosq0nS109mMSxPWyNT1Q%3DUNYCJgXKYuCceaPS%2BhA%40mail.gmail.com

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

--00000000000009b7940621b41a5d
Content-Type: application/octet-stream; 
	name="v1-0001-Disallow-altering-invalidated-replication-slots.patch"
Content-Disposition: attachment; 
	filename="v1-0001-Disallow-altering-invalidated-replication-slots.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m0vcb69g0>
X-Attachment-Id: f_m0vcb69g0

RnJvbSA4YjJhN2U3YzYyOWM1ZDIxZmRiODAxNzM5ZDk2NjE3MjI5MDRkZDdlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGFyYXRoIFJ1cGlyZWRkeSA8YmhhcmF0aC5ydXBpcmVkZHlm
b3Jwb3N0Z3Jlc0BnbWFpbC5jb20+CkRhdGU6IE1vbiwgOSBTZXAgMjAyNCAxODoyNToxNiArMDAw
MApTdWJqZWN0OiBbUEFUQ0ggdjFdIERpc2FsbG93IGFsdGVyaW5nIGludmFsaWRhdGVkIHJlcGxp
Y2F0aW9uIHNsb3RzCgpBTFRFUl9SRVBMSUNBVElPTl9TTE9UIG9uIGludmFsaWRhdGVkIHJlcGxp
Y2F0aW9uIHNsb3RzIGlzCnVubmVjZXNzYXJ5IGFzIHRoZXJlIGlzIG5vIHdheSB0byBnZXQgdGhl
IGludmFsaWRhdGVkCihsb2dpY2FsKSBzbG90IHRvIHdvcmsuIFRoaXMgY29tbWl0IGFkZHMgYW4g
ZXJyb3IuCgpEaXNjdXNzaW9uOiBodHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlk
L0NBQTRlSzElMkJzemNvc3EwblMxMDltTVN4UFd5TlQxUSUzRFVOWUNKZ1hLWXVDY2VhUFMlMkJo
QSU0MG1haWwuZ21haWwuY29tCi0tLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vc2xvdC5jICAg
ICAgICAgICAgICAgICAgICAgIHwgNyArKysrKysrCiBzcmMvdGVzdC9yZWNvdmVyeS90LzAzNV9z
dGFuZGJ5X2xvZ2ljYWxfZGVjb2RpbmcucGwgfCA5ICsrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk
LCAxNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24v
c2xvdC5jIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vc2xvdC5jCmluZGV4IDBhMDM3NzYxNTYu
LjM1NjUyZDlhZDggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3Nsb3QuYwor
KysgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9zbG90LmMKQEAgLTgyMCw2ICs4MjAsMTMgQEAg
UmVwbGljYXRpb25TbG90QWx0ZXIoY29uc3QgY2hhciAqbmFtZSwgY29uc3QgYm9vbCAqZmFpbG92
ZXIsCiAJCQkJZXJybXNnKCJjYW5ub3QgdXNlICVzIHdpdGggYSBwaHlzaWNhbCByZXBsaWNhdGlv
biBzbG90IiwKIAkJCQkJICAgIkFMVEVSX1JFUExJQ0FUSU9OX1NMT1QiKSk7CiAKKwlpZiAoTXlS
ZXBsaWNhdGlvblNsb3QtPmRhdGEuaW52YWxpZGF0ZWQgIT0gUlNfSU5WQUxfTk9ORSkKKwkJZXJl
cG9ydChFUlJPUiwKKwkJCQllcnJjb2RlKEVSUkNPREVfT0JKRUNUX05PVF9JTl9QUkVSRVFVSVNJ
VEVfU1RBVEUpLAorCQkJCWVycm1zZygiY2Fubm90IGFsdGVyIHJlcGxpY2F0aW9uIHNsb3QgXCIl
c1wiIiwgbmFtZSksCisJCQkJZXJyZGV0YWlsKCJUaGlzIHJlcGxpY2F0aW9uIHNsb3Qgd2FzIGlu
dmFsaWRhdGVkIGR1ZSB0byBcIiVzXCIuIiwKKwkJCQkJCSAgU2xvdEludmFsaWRhdGlvbkNhdXNl
c1tNeVJlcGxpY2F0aW9uU2xvdC0+ZGF0YS5pbnZhbGlkYXRlZF0pKTsKKwogCWlmIChSZWNvdmVy
eUluUHJvZ3Jlc3MoKSkKIAl7CiAJCS8qCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWNvdmVyeS90
LzAzNV9zdGFuZGJ5X2xvZ2ljYWxfZGVjb2RpbmcucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAz
NV9zdGFuZGJ5X2xvZ2ljYWxfZGVjb2RpbmcucGwKaW5kZXggNDE4NWI4MDNiMi4uNzVjY2ZjYTQw
OSAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMzVfc3RhbmRieV9sb2dpY2FsX2Rl
Y29kaW5nLnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDM1X3N0YW5kYnlfbG9naWNhbF9k
ZWNvZGluZy5wbApAQCAtNTI2LDYgKzUyNiwxNSBAQCBjaGVja19mb3JfaW52YWxpZGF0aW9uKCd2
YWN1dW1fZnVsbF8nLCAxLCAnd2l0aCB2YWN1dW0gRlVMTCBvbiBwZ19jbGFzcycpOwogIyBWZXJp
ZnkgcmVhc29uIGZvciBjb25mbGljdCBpcyAncm93c19yZW1vdmVkJyBpbiBwZ19yZXBsaWNhdGlv
bl9zbG90cwogY2hlY2tfc2xvdHNfY29uZmxpY3RfcmVhc29uKCd2YWN1dW1fZnVsbF8nLCAncm93
c19yZW1vdmVkJyk7CiAKKyMgQXR0ZW1wdGluZyB0byBhbHRlciBhbiBpbnZhbGlkYXRlZCBzbG90
IHNob3VsZCByZXN1bHQgaW4gYW4gZXJyb3IKKygkcmVzdWx0LCAkc3Rkb3V0LCAkc3RkZXJyKSA9
ICRub2RlX3N0YW5kYnktPnBzcWwoCisgICAgJ3Bvc3RncmVzJywKKyAgICBxcVtBTFRFUl9SRVBM
SUNBVElPTl9TTE9UIHZhY3V1bV9mdWxsX2luYWN0aXZlc2xvdCAoZmFpbG92ZXIpO10sCisgICAg
cmVwbGljYXRpb24gPT4gJ2RhdGFiYXNlJyk7Citvaygkc3RkZXJyID1+IC9FUlJPUjogIGNhbm5v
dCBhbHRlciByZXBsaWNhdGlvbiBzbG90ICJ2YWN1dW1fZnVsbF9pbmFjdGl2ZXNsb3QiLyAmJgor
ICAgJHN0ZGVyciA9fiAvREVUQUlMOiAgVGhpcyByZXBsaWNhdGlvbiBzbG90IHdhcyBpbnZhbGlk
YXRlZCBkdWUgdG8gInJvd3NfcmVtb3ZlZCIuLywKKyAgICAiaW52YWxpZGF0ZWQgc2xvdCBjYW5u
b3QgYmUgYWx0ZXJlZCIpOworCiAjIEVuc3VyZSB0aGF0IHJlcGxpY2F0aW9uIHNsb3Qgc3RhdHMg
YXJlIG5vdCByZW1vdmVkIGFmdGVyIGludmFsaWRhdGlvbi4KIGlzKCAkbm9kZV9zdGFuZGJ5LT5z
YWZlX3BzcWwoCiAJCSd0ZXN0ZGInLAotLSAKMi40My4wCgo=
--00000000000009b7940621b41a5d--