MIME-Version: 1.0
References: <87cz2otiw3.fsf@wibble.ilmari.org> <ZG/jlbT0eIME+MFW@paquier.xyz>
 <CALDaNm1sDD-MCW6zrxHCC7Ka5AzO-L4ejxeeTMtXPPN+F4vz2Q@mail.gmail.com>
 <c44dfd51-96fe-d3aa-8f8a-07946d052fdc@dunslane.net> <CALDaNm3SWpFDTs1oRRbOAfYJNuSPMCLu4O3mLnU-tKoSFgGckQ@mail.gmail.com>
 <ZHu852YlGAk7AVk0@paquier.xyz> <CALDaNm2Q_uE0Ash_1LTbqDQGSEM-8e9wjtuJ0QKTVdKNG34JWg@mail.gmail.com>
 <CALj2ACVQovWdxd1C9K86JAtG4mTbh86qqXfKHjWw0BeLXAHE3g@mail.gmail.com>
 <ZH8NTh546nHLMGpr@paquier.xyz> <CALj2ACVE+vQK9gDKoNqSm+-aJxY=6OY7QJYFoc4oNFqy-BU_bA@mail.gmail.com>
 <ZIKVd+a43UfsIWJE@paquier.xyz>
In-Reply-To: <ZIKVd+a43UfsIWJE@paquier.xyz>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Sun, 11 Jun 2023 07:17:55 +0530
Message-ID: <CALj2ACWJ8OOQ97=EDjy-i9Jdno5ioHs=oebfRd4-T-ry+4Ge7A@mail.gmail.com>
Subject: Re: Implement generalized sub routine find_in_log for tap test
To: Michael Paquier <michael@paquier.xyz>
Cc: vignesh C <vignesh21@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, 
	=?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALj2ACWJ8OOQ97%3DEDjy-i9Jdno5ioHs%3DoebfRd4-T-ry%2B4Ge7A%40mail.gmail.com>
Precedence: bulk

On Fri, Jun 9, 2023 at 8:29=E2=80=AFAM Michael Paquier <michael@paquier.xyz=
> wrote:
>
> On Tue, Jun 06, 2023 at 05:53:40PM +0530, Bharath Rupireddy wrote:
> > Yes. A simpler way of doing it would be to move advance_wal() in
> > 019_replslot_limit.pl to Cluster.pm, something like the attached. CI
> > members don't complain with it
> > https://github.com/BRupireddy/postgres/tree/add_a_function_in_Cluster.p=
m_to_generate_WAL.
> > Perhaps, we can name it better instead of advance_wal, say
> > generate_wal or some other?
>
> Why not discussing that on a separate thread?  What you are proposing
> is independent of what Vignesh has proposed.

Sure. Here it is  -
https://www.postgresql.org/message-id/CALj2ACU3R8QFCvDewHCMKjgb2w_-CMCyd6DA=
K%3DJb-af14da5eg%40mail.gmail.com.

> Note that the patch
> format is octet-stream, causing extra CRs to exist in the patch.
> Something happened on your side when you sent your patch, I guess?

Had to attach the patch in .txt format to not block Vignesh's patch
from testing by CF Bot (if at all this thread was added there).

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com