public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bharath Rupireddy <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Add BF member koel-like indentation checks to SanityCheck CI
Date: Mon, 30 Oct 2023 12:50:44 +0530
Message-ID: <CALj2ACWMupLTuD+bWfr2oBsNDpFJiuFaCK17S3Ty0YJbywdSfA@mail.gmail.com> (raw)

Hi,

How about adding code indent checks (like what BF member koel has) to
the SanityCheck CI task? This helps catch indentation problems way
before things are committed so that developers can find them out in
their respective CI runs and lets developers learn the postgres code
indentation stuff. It also saves committers time - git log | grep
'koel' | wc -l gives me 11 commits and git log | grep 'indentation' |
wc -l gives me 97. Most, if not all of these commits went into fixing
code indentation problems that could have been reported a bit early
and fixed by developers/patch authors themselves.

Thoughts?

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Add BF member koel-like indentation checks to SanityCheck CI
  In-Reply-To: <CALj2ACWMupLTuD+bWfr2oBsNDpFJiuFaCK17S3Ty0YJbywdSfA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox