MIME-Version: 1.0
References: <CALj2ACWj7qF-YYVi05okBFJnPugkwsM8PSrEwfHs-tQqKO80Uw@mail.gmail.com>
 <46e53055d8d1c92704d3cd2709c722e7@oss.nttdata.com> <CALj2ACV0fr-9OTZqtWu-9XrtUbBZCYb0UK859gfvJ0oqm3YvUA@mail.gmail.com>
 <ZLn2v/eMkqmny4J6@paquier.xyz> <CALj2ACVUxgcQaGh3HpBJ6Xg9FRqj7UNDomd5E1y=tRKs2wcntA@mail.gmail.com>
 <ZLokkzw6pmvDU9bM@paquier.xyz> <CALj2ACVWW2NU78kJ=xEbz8qcZgWeae+cVp8TYbvGTdpYjVKjjA@mail.gmail.com>
 <e4e5bee9d241a00a0edd9ee4e90fe69c@oss.nttdata.com> <CALj2ACWR9ncAiDF73unqdJF1dmsA2R0efGXX2624X+YVxcAVWg@mail.gmail.com>
 <20230728022332.egqzobhskmlf6ntr@awork3.anarazel.de> <ZMNH6Q+W3lhMGXoh@paquier.xyz>
In-Reply-To: <ZMNH6Q+W3lhMGXoh@paquier.xyz>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Fri, 28 Jul 2023 10:47:39 +0530
Message-ID: <CALj2ACWQvLCHD6XLACtbzOu1861RbQ0LdpoVpNHJuvYZovsOpw@mail.gmail.com>
Subject: Re: Support worker_spi to execute the function dynamically.
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Masahiro Ikeda <ikedamsh@oss.nttdata.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CALj2ACWQvLCHD6XLACtbzOu1861RbQ0LdpoVpNHJuvYZovsOpw%40mail.gmail.com>
Precedence: bulk

On Fri, Jul 28, 2023 at 10:15=E2=80=AFAM Michael Paquier <michael@paquier.x=
yz> wrote:
>
> Having each bgworker on its own schema would be enough to prevent
> conflicts, but I'd like to add a second thing: a check on
> pg_stat_activity.wait_event after starting the workers.  I have added
> something like that in the patch I have posted today for the custom
> wait events at [1] and it enforces the startup sequences of the
> workers in a stricter way.
>
> Does the attached take care of your issue?

+# check their existence.  Use IDs that do not overlap with the schemas cre=
ated
+# by the previous workers.

While using different IDs in tests is a simple fix, -1 for it. I'd
prefer if worker_spi uses different schema prefixes for static and
dynamic bg workers to avoid conflicts. We can either look at
MyBgworkerEntry->bgw_type in worker_spi_main and have schema name as
'{static, dyamic}_worker_schema_%d', id or pass schema name in
bgw_extra.

--=20
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com