MIME-Version: 1.0
References: 
 <CALj2ACWt6wkFnu7sac3pUb4WLZ3jA1m3cu7FJE3EovpGKzhwKw@mail.gmail.com>
 <165852348876.1168.5615622255167011778.pgcf@coridan.postgresql.org>
In-Reply-To: 
 <165852348876.1168.5615622255167011778.pgcf@coridan.postgresql.org>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Mon, 25 Jul 2022 12:19:40 +0530
Message-ID: 
 <CALj2ACWUb_XPGz1Rgh_YWHs1dqX2Q7uSPY5in4w=JXbx4FssDQ@mail.gmail.com>
Subject: Re: Add last failed connection error message to pg_stat_wal_receiver
To: Cary Huang <cary.huang@highgo.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACWUb_XPGz1Rgh_YWHs1dqX2Q7uSPY5in4w%3DJXbx4FssDQ%40mail.gmail.com>
Precedence: bulk

On Sat, Jul 23, 2022 at 2:29 AM Cary Huang <cary.huang@highgo.ca> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
>
> Hello
>
> The patch can be applied to PG master branch without problem and it passe=
d regression and tap tests. I manually tested this feature too and the last=
 conn error is correctly shown in the pg_stat_get_wal_receiver output, whic=
h does exactly as described. I think this feature is nice to have to troubl=
eshoot replication issues on the standby side.

Thanks a lot Cary for reviewing. It will be great if you can add
yourself as a reviewer and set the status accordingly in the CF entry
here - https://commitfest.postgresql.org/38/3666/.

Regards,
Bharath Rupireddy.