MIME-Version: 1.0
References: 
 <CA+3i_M-+WVyrRcfnxa4gt+KQUzH-LTQ8D2JCGE_O0WzJJtZfUg@mail.gmail.com>
 <CAHg+QDfLh-yb+OacN6qPYF6H3SPDmVJUiors7vkSMq4yxfhNrA@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDfLh-yb+OacN6qPYF6H3SPDmVJUiors7vkSMq4yxfhNrA@mail.gmail.com>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Sat, 21 Mar 2026 17:43:15 -0700
Message-ID: 
 <CALj2ACWovfe_A43LP5fi0mJenZ-i99_ux68YCzX6D2CO5mB-gg@mail.gmail.com>
Subject: Re: log XLogPrefetch stats at end of recovery
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: Lakshmi N <lakshmin.jhs@gmail.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACWovfe_A43LP5fi0mJenZ-i99_ux68YCzX6D2CO5mB-gg%40mail.gmail.com>
Precedence: bulk

Hi,

On Sat, Mar 21, 2026 at 1:16=E2=80=AFAM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
>
> > While investigating a long recovery, I noticed that XLogPrefetch stats =
were not logged at the end of recovery. This log message will be useful to =
understand how effective XLogPrefetch was during recovery. Adding a patch t=
o address this.
>
> Applied this patch and validated the log message. This log message appear=
s to be useful to me, particularly while doing fleet wide analysis.
>
> 2026-03-20 23:33:13.756 PDT [2265441] LOG:  XLogPrefetcher stats: prefetc=
h=3D14, hit=3D6, skip_init=3D5, skip_new=3D28, skip_fpw=3D18, skip_rep=3D99=
6

This looks useful to understand how the prefetch helped during long recover=
ies.

> I am wondering if we can periodically log this in standby mode as well, n=
ot just before promoting?

Timer-based startup progress messaging allows logging such things
(ereport_startup_progress API). There was an attempt to enable "redo
in progress" for standbys, but that seemed to flood the standby logs
even at the default progress interval of 10 sec.

Having said that, the prefetcher stats could be added to the existing
ereport_startup_progress("redo in progress xxx") message that works
for crash recoveries=E2=80=94however, I don't prefer doing a bunch of atomi=
c
reads every progress interval of 10 sec. Therefore, logging at the end
of recovery looks good to me.

I reviewed the patch. I have the following comment:

+ elog(LOG, "XLogPrefetcher stats: prefetch=3D%lu, hit=3D%lu,
skip_init=3D%lu, skip_new=3D%lu, skip_fpw=3D%lu, skip_rep=3D%lu",

XLogPrefetcher is an internal data structure name, how about "redo
prefetch stats: xxxx" to be consistent with other redo log messages?

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com