Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcTQt-0001de-Qu for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Nov 2020 13:11:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kcTQr-0001xf-KB for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Nov 2020 13:11:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcTQr-0001xO-AR for pgsql-hackers@lists.postgresql.org; Tue, 10 Nov 2020 13:11:33 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kcTQk-0005ha-Dv for pgsql-hackers@postgresql.org; Tue, 10 Nov 2020 13:11:32 +0000 Received: by mail-pg1-x52f.google.com with SMTP id e21so10105361pgr.11 for ; Tue, 10 Nov 2020 05:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UF632w47s3FNndYtPjeTUgWxmf+6r16UGjiWA1IzLQ8=; b=hVL0/CqYzPI6Y/gz8on858I2BkhC7qCbDuuTFTE6R6Lh/UFiCtSkSctVOLERlb7Ye5 QZcvkjr1UPl/69Qt6ZB9xHOnHx3PNOtdo61KjT/Msuvq/YARKdeq/jq45sDF19Wh/sN9 R4gCtdYhYPBErIquRH5d2yW/hL1zUj6qPFNRyZX2NEot0Yt1vRqJCi48u9LYjAGYKkw/ lMb+BhaU1+i+woihShlwkvsGksWOgJ0e2LjY9XNJ/nvAEZ3UnblzOxqS4UbxpKyE9G1r FiR2nCK3Va7DwAI57TKYwwwc7Iqg3bQYxAbX5DNDFh2CM0ND+FZKBLRRlh+lDtaIBj2A kKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UF632w47s3FNndYtPjeTUgWxmf+6r16UGjiWA1IzLQ8=; b=Tc95oZzM5LRe6AipWkP0ChIr5c+Skp9z+MPgotJOB0B7IrM1leIAK/gvdjudhaGqyL WJmd3ohdTlJFVM+/UGoeO8IcceafwuU0ZdyCJ1xRVodrZbdkCUjzyTQXdPdEqdkVqqhk 0MiaN/qD6sjKhrm24eW8TzMxmGgmuEFVTEwnaAOWJ6qodYPBPIIpMeW21qT/lvjPtA+z UP+tB2ZYdYOE/I1CYwN4Fe2xe3wZCDMJalyNCi8jW4V3tqSGstq9x1P+KT1xkVHiedjs 1YF4Rv5kcsz1ldHhOcgtuFVsufovIIYIOute+tMf1u4eG1oETHhvHApEGr13XU9kSnuw PevA== X-Gm-Message-State: AOAM532Uz7J6jwQEbMXyJua+CRdrBj984oh0wIq/2s66Cxst7Eo9r8GT NUYbBBsTbyxMRlS8mvwaI0rKRZLZDaSA+E6Ls0A= X-Google-Smtp-Source: ABdhPJysEPWkodps7FEWMpU3b06fUkMkORTogXun/AbbA2CdpiTAUBkGTkonZl87nXrmfMtoSi7F3KvSUIgHfP994V4= X-Received: by 2002:aa7:9983:0:b029:18b:a0bb:4c70 with SMTP id k3-20020aa799830000b029018ba0bb4c70mr18788795pfh.31.1605013884070; Tue, 10 Nov 2020 05:11:24 -0800 (PST) MIME-Version: 1.0 References: <20201105.121206.819769369617763972.horikyota.ntt@gmail.com> <20201110.161740.1341818036035711165.horikyota.ntt@gmail.com> In-Reply-To: From: Bharath Rupireddy Date: Tue, 10 Nov 2020 18:41:12 +0530 Message-ID: Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module To: Fujii Masao Cc: Kyotaro Horiguchi , PostgreSQL-development Content-Type: multipart/mixed; boundary="0000000000006b8ebd05b3c06ace" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006b8ebd05b3c06ace Content-Type: text/plain; charset="UTF-8" Hi, Attaching a patch that replaces custom signal handlers for SIGHUP and SIGTERM in worker_spi.c. Thoughts? With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com --0000000000006b8ebd05b3c06ace Content-Type: application/x-patch; name="v1-0001-Use-standard-SIGHUP-SIGTERM-handlers-in-worker_sp.patch" Content-Disposition: attachment; filename="v1-0001-Use-standard-SIGHUP-SIGTERM-handlers-in-worker_sp.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_khbzjpij0 RnJvbSBhMjEyMTYzYjY0YmMzYWI0YjhkNDQ5M2U2ZDUzZjMyOTc5ZTNlOWJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGFyYXRoIFJ1cGlyZWRkeSA8YmhhcmF0aC5ydXBpcmVkZHlA ZW50ZXJwcmlzZWRiLmNvbT4KRGF0ZTogVHVlLCAxMCBOb3YgMjAyMCAxODoyNzowMCArMDUzMApT dWJqZWN0OiBbUEFUQ0ggdjFdIFVzZS1zdGFuZGFyZC1TSUdIVVAtU0lHVEVSTS1oYW5kbGVycy1p bi13b3JrZXJfc3BpLmMKCi0tLQogc3JjL3Rlc3QvbW9kdWxlcy93b3JrZXJfc3BpL3dvcmtlcl9z cGkuYyB8IDQ3ICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5z ZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvbW9kdWxl cy93b3JrZXJfc3BpL3dvcmtlcl9zcGkuYyBiL3NyYy90ZXN0L21vZHVsZXMvd29ya2VyX3NwaS93 b3JrZXJfc3BpLmMKaW5kZXggMjU4MjM3ZjliZi4uNTU5OGQyZTg1MCAxMDA2NDQKLS0tIGEvc3Jj L3Rlc3QvbW9kdWxlcy93b3JrZXJfc3BpL3dvcmtlcl9zcGkuYworKysgYi9zcmMvdGVzdC9tb2R1 bGVzL3dvcmtlcl9zcGkvd29ya2VyX3NwaS5jCkBAIC0yNSw2ICsyNSw3IEBACiAvKiBUaGVzZSBh cmUgYWx3YXlzIG5lY2Vzc2FyeSBmb3IgYSBiZ3dvcmtlciAqLwogI2luY2x1ZGUgIm1pc2NhZG1p bi5oIgogI2luY2x1ZGUgInBvc3RtYXN0ZXIvYmd3b3JrZXIuaCIKKyNpbmNsdWRlICJwb3N0bWFz dGVyL2ludGVycnVwdC5oIgogI2luY2x1ZGUgInN0b3JhZ2UvaXBjLmgiCiAjaW5jbHVkZSAic3Rv cmFnZS9sYXRjaC5oIgogI2luY2x1ZGUgInN0b3JhZ2UvbHdsb2NrLmgiCkBAIC00OCwxMCArNDks NiBAQCBQR19GVU5DVElPTl9JTkZPX1YxKHdvcmtlcl9zcGlfbGF1bmNoKTsKIHZvaWQJCV9QR19p bml0KHZvaWQpOwogdm9pZAkJd29ya2VyX3NwaV9tYWluKERhdHVtKSBwZ19hdHRyaWJ1dGVfbm9y ZXR1cm4oKTsKIAotLyogZmxhZ3Mgc2V0IGJ5IHNpZ25hbCBoYW5kbGVycyAqLwotc3RhdGljIHZv bGF0aWxlIHNpZ19hdG9taWNfdCBnb3Rfc2lnaHVwID0gZmFsc2U7Ci1zdGF0aWMgdm9sYXRpbGUg c2lnX2F0b21pY190IGdvdF9zaWd0ZXJtID0gZmFsc2U7Ci0KIC8qIEdVQyB2YXJpYWJsZXMgKi8K IHN0YXRpYyBpbnQJd29ya2VyX3NwaV9uYXB0aW1lID0gMTA7CiBzdGF0aWMgaW50CXdvcmtlcl9z cGlfdG90YWxfd29ya2VycyA9IDI7CkBAIC02NCwzOCArNjEsNiBAQCB0eXBlZGVmIHN0cnVjdCB3 b3JrdGFibGUKIAljb25zdCBjaGFyICpuYW1lOwogfSB3b3JrdGFibGU7CiAKLS8qCi0gKiBTaWdu YWwgaGFuZGxlciBmb3IgU0lHVEVSTQotICoJCVNldCBhIGZsYWcgdG8gbGV0IHRoZSBtYWluIGxv b3AgdG8gdGVybWluYXRlLCBhbmQgc2V0IG91ciBsYXRjaCB0byB3YWtlCi0gKgkJaXQgdXAuCi0g Ki8KLXN0YXRpYyB2b2lkCi13b3JrZXJfc3BpX3NpZ3Rlcm0oU0lHTkFMX0FSR1MpCi17Ci0JaW50 CQkJc2F2ZV9lcnJubyA9IGVycm5vOwotCi0JZ290X3NpZ3Rlcm0gPSB0cnVlOwotCVNldExhdGNo KE15TGF0Y2gpOwotCi0JZXJybm8gPSBzYXZlX2Vycm5vOwotfQotCi0vKgotICogU2lnbmFsIGhh bmRsZXIgZm9yIFNJR0hVUAotICoJCVNldCBhIGZsYWcgdG8gdGVsbCB0aGUgbWFpbiBsb29wIHRv IHJlcmVhZCB0aGUgY29uZmlnIGZpbGUsIGFuZCBzZXQKLSAqCQlvdXIgbGF0Y2ggdG8gd2FrZSBp dCB1cC4KLSAqLwotc3RhdGljIHZvaWQKLXdvcmtlcl9zcGlfc2lnaHVwKFNJR05BTF9BUkdTKQot ewotCWludAkJCXNhdmVfZXJybm8gPSBlcnJubzsKLQotCWdvdF9zaWdodXAgPSB0cnVlOwotCVNl dExhdGNoKE15TGF0Y2gpOwotCi0JZXJybm8gPSBzYXZlX2Vycm5vOwotfQotCiAvKgogICogSW5p dGlhbGl6ZSB3b3Jrc3BhY2UgZm9yIGEgd29ya2VyIHByb2Nlc3M6IGNyZWF0ZSB0aGUgc2NoZW1h IGlmIGl0IGRvZXNuJ3QKICAqIGFscmVhZHkgZXhpc3QuCkBAIC0xNzksOCArMTQ0LDggQEAgd29y a2VyX3NwaV9tYWluKERhdHVtIG1haW5fYXJnKQogCXRhYmxlLT5uYW1lID0gcHN0cmR1cCgiY291 bnRlZCIpOwogCiAJLyogRXN0YWJsaXNoIHNpZ25hbCBoYW5kbGVycyBiZWZvcmUgdW5ibG9ja2lu ZyBzaWduYWxzLiAqLwotCXBxc2lnbmFsKFNJR0hVUCwgd29ya2VyX3NwaV9zaWdodXApOwotCXBx c2lnbmFsKFNJR1RFUk0sIHdvcmtlcl9zcGlfc2lndGVybSk7CisJcHFzaWduYWwoU0lHSFVQLCBT aWduYWxIYW5kbGVyRm9yQ29uZmlnUmVsb2FkKTsKKwlwcXNpZ25hbChTSUdURVJNLCBTaWduYWxI YW5kbGVyRm9yU2h1dGRvd25SZXF1ZXN0KTsKIAogCS8qIFdlJ3JlIG5vdyByZWFkeSB0byByZWNl aXZlIHNpZ25hbHMgKi8KIAlCYWNrZ3JvdW5kV29ya2VyVW5ibG9ja1NpZ25hbHMoKTsKQEAgLTIy MSw3ICsxODYsNyBAQCB3b3JrZXJfc3BpX21haW4oRGF0dW0gbWFpbl9hcmcpCiAJLyoKIAkgKiBN YWluIGxvb3A6IGRvIHRoaXMgdW50aWwgdGhlIFNJR1RFUk0gaGFuZGxlciB0ZWxscyB1cyB0byB0 ZXJtaW5hdGUKIAkgKi8KLQl3aGlsZSAoIWdvdF9zaWd0ZXJtKQorCXdoaWxlICghU2h1dGRvd25S ZXF1ZXN0UGVuZGluZykKIAl7CiAJCWludAkJCXJldDsKIApAQCAtMjQyLDkgKzIwNyw5IEBAIHdv cmtlcl9zcGlfbWFpbihEYXR1bSBtYWluX2FyZykKIAkJLyoKIAkJICogSW4gY2FzZSBvZiBhIFNJ R0hVUCwganVzdCByZWxvYWQgdGhlIGNvbmZpZ3VyYXRpb24uCiAJCSAqLwotCQlpZiAoZ290X3Np Z2h1cCkKKwkJaWYgKENvbmZpZ1JlbG9hZFBlbmRpbmcpCiAJCXsKLQkJCWdvdF9zaWdodXAgPSBm YWxzZTsKKwkJCUNvbmZpZ1JlbG9hZFBlbmRpbmcgPSBmYWxzZTsKIAkJCVByb2Nlc3NDb25maWdG aWxlKFBHQ19TSUdIVVApOwogCQl9CiAKLS0gCjIuMjUuMQoK --0000000000006b8ebd05b3c06ace--