MIME-Version: 1.0
References: <603c8f070905281830g2e5419c4xad2946d149e21f9d@mail.gmail.com>
 <4A1F4FD5.7060204@timbira.com> <4A249CE9.6050708@cheapcomplexdevices.com>
 <1243950060.23910.58.camel@ebony.2ndQuadrant>
 <B8F900A1-1ACB-4C84-84D6-676B2B7DF8A2@gmail.com>
 <11926.1243953507@sss.pgh.pa.us>
 <CALtqXTeQ+QCFT0DWcM5LOjnf9_Fz59+ALFejNEFwpFhW-9o4ag@mail.gmail.com>
 <CAKFQuwYg+HtK+zFKENbsrLgz9x8LL1HWau6DR7Om6o1dT=tt6g@mail.gmail.com>
 <CALtqXTcrXtwZ3RRg2FH8yt8mDxRypXrUbw6a=zp0x2fKm_5xNg@mail.gmail.com>
 <CALDaNm3inETBcHYyBeevfKCjaxB24N4BVhDiZVdBooEdtxi1_w@mail.gmail.com>
 <CAM-w4HNhqLiqmQzw8QNKP9_vApa9xHN8Ph=EV_GJRsYzzUvg8w@mail.gmail.com>
In-Reply-To: 
 <CAM-w4HNhqLiqmQzw8QNKP9_vApa9xHN8Ph=EV_GJRsYzzUvg8w@mail.gmail.com>
From: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Date: Fri, 8 Jul 2022 23:12:47 +0500
Message-ID: 
 <CALtqXTfosCrM-7B2HxitSMo8CNPGWOZ+nstwPbAiZVxJ3tfjnA@mail.gmail.com>
Subject: Re: explain analyze rows=%.0f
To: Greg Stark <stark@mit.edu>
Cc: vignesh C <vignesh21@gmail.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>,
	Simon Riggs <simon@2ndquadrant.com>,
 Ron Mayer <rm_pg@cheapcomplexdevices.com>,
	Euler Taveira de Oliveira <euler@timbira.com>, Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: multipart/alternative; boundary="00000000000065bfb205e34f287b"
Archived-At: 
 <https://www.postgresql.org/message-id/CALtqXTfosCrM-7B2HxitSMo8CNPGWOZ%2BnstwPbAiZVxJ3tfjnA%40mail.gmail.com>
Precedence: bulk

--00000000000065bfb205e34f287b
Content-Type: text/plain; charset="UTF-8"

On Thu, Jul 7, 2022 at 10:53 PM Greg Stark <stark@mit.edu> wrote:

> > -               ->  Parallel Seq Scan on tenk1 (actual rows=1960
> loops=50)
> > +               ->  Parallel Seq Scan on tenk1 (actual rows=1960.00
>
> At the not inconsiderable risk of bike-shedding....
>
> I'm wondering if printing something like 0.00 will be somewhat
> deceptive when the real value is non-zero but less than 1 row per 200
> loops. I wonder if the number of decimal places should be calculated
> to produce a minimum of one non-zero digit for non-zero values.
>
> --
> greg
>

+               ->  Parallel Seq Scan on tenk1 (actual rows=1960.00

I have added a new check to remove any ".00" from the output because in
the case of parallel queries we are getting that. Secondly, it is
disturbing many test case outputs.

-- 
Ibrar Ahmed

--00000000000065bfb205e34f287b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif"><br></div></div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jul 7, 2022 at 10:53 PM Greg=
 Stark &lt;<a href=3D"mailto:stark@mit.edu">stark@mit.edu</a>&gt; wrote:<br=
></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">&gt; -=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-&gt;=C2=A0 Parallel Seq Scan =
on tenk1 (actual rows=3D1960 loops=3D50)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-&gt;=C2=A0 Pa=
rallel Seq Scan on tenk1 (actual rows=3D1960.00<br>
<br>
At the not inconsiderable risk of bike-shedding....<br>
<br>
I&#39;m wondering if printing something like 0.00 will be somewhat<br>
deceptive when the real value is non-zero but less than 1 row per 200<br>
loops. I wonder if the number of decimal places should be calculated<br>
to produce a minimum of one non-zero digit for non-zero values.<br>
<br>
-- <br>
greg<br>
</blockquote></div><br clear=3D"all"><div>+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0-&gt;=C2=A0 Parallel Seq Scan on tenk1 (actual rows=
=3D1960.00<br></div><div><br></div><div><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif">I have added a new check to remove any =
&quot;.00&quot; from the output because in</div><div class=3D"gmail_default=
" style=3D"font-family:verdana,sans-serif">the case of parallel queries we =
are getting that. Secondly, it is disturbing many test case outputs.</div><=
br></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"=
><div>Ibrar Ahmed</div></div></div></div>

--00000000000065bfb205e34f287b--